2023-04-18 19:11:17 +00:00
|
|
|
# don't forget to add fixtures in repo_unit.yml
|
2017-01-01 18:15:09 +00:00
|
|
|
-
|
|
|
|
|
id: 1
|
|
|
|
|
owner_id: 2
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user2
|
2017-01-01 18:15:09 +00:00
|
|
|
lower_name: repo1
|
|
|
|
|
name: repo1
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 4
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-02-08 06:29:21 +00:00
|
|
|
num_issues: 2
|
2017-02-06 03:43:31 +00:00
|
|
|
num_closed_issues: 1
|
2020-01-17 06:03:40 +00:00
|
|
|
num_pulls: 3
|
2017-01-01 18:15:09 +00:00
|
|
|
num_closed_pulls: 0
|
2019-06-06 00:37:45 +00:00
|
|
|
num_milestones: 3
|
|
|
|
|
num_closed_milestones: 1
|
2020-08-17 03:07:38 +00:00
|
|
|
num_projects: 1
|
|
|
|
|
num_closed_projects: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
2023-03-15 21:51:39 +00:00
|
|
|
size: 7320
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-01-01 18:15:09 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 2
|
|
|
|
|
owner_id: 2
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user2
|
2017-01-01 18:15:09 +00:00
|
|
|
lower_name: repo2
|
|
|
|
|
name: repo2
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
[MODERATION] User blocking
- Add the ability to block a user via their profile page.
- This will unstar their repositories and visa versa.
- Blocked users cannot create issues or pull requests on your the doer's repositories (mind that this is not the case for organizations).
- Blocked users cannot comment on the doer's opened issues or pull requests.
- Blocked users cannot add reactions to doer's comments.
- Blocked users cannot cause a notification trough mentioning the doer.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/540
(cherry picked from commit 687d852480388897db4d7b0cb397cf7135ab97b1)
(cherry picked from commit 0c32a4fde531018f74e01d9db6520895fcfa10cc)
(cherry picked from commit 1791130e3cb8470b9b39742e0004d5e4c7d1e64d)
(cherry picked from commit 37858b7e8fb6ba6c6ea0ac2562285b3b144efa19)
(cherry picked from commit a3e2bfd7e9eab82cc2c17061f6bb4e386a108c46)
(cherry picked from commit 7009b9fe87696b6182fab65ae82bf5a25cd39971)
Conflicts: https://codeberg.org/forgejo/forgejo/pulls/1014
routers/web/user/profile.go
templates/user/profile.tmpl
(cherry picked from commit b2aec3479177e725cfc7cbbb9d94753226928d1c)
(cherry picked from commit e2f1b73752f6bd3f830297d8f4ac438837471226)
[MODERATION] organization blocking a user (#802)
- Resolves #476
- Follow up for: #540
- Ensure that the doer and blocked person cannot follow each other.
- Ensure that the block person cannot watch doer's repositories.
- Add unblock button to the blocked user list.
- Add blocked since information to the blocked user list.
- Add extra testing to moderation code.
- Blocked user will unwatch doer's owned repository upon blocking.
- Add flash messages to let the user know the block/unblock action was successful.
- Add "You haven't blocked any users" message.
- Add organization blocking a user.
Co-authored-by: Gusted <postmaster@gusted.xyz>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/802
(cherry picked from commit 0505a1042197bd9136b58bc70ec7400a23471585)
(cherry picked from commit 37b4e6ef9b85e97d651cf350c9f3ea272ee8d76a)
(cherry picked from commit c17c121f2cf1f00e2a8d6fd6847705df47d0771e)
[MODERATION] organization blocking a user (#802) (squash)
Changes to adapt to:
6bbccdd177 Improve AJAX link and modal confirm dialog (#25210)
Refs: https://codeberg.org/forgejo/forgejo/pulls/882/files#issuecomment-945962
Refs: https://codeberg.org/forgejo/forgejo/pulls/882#issue-330561
(cherry picked from commit 523635f83cb2a1a4386769b79326088c5c4bbec7)
(cherry picked from commit 4743eaa6a0be0ef47de5b17c211dfe8bad1b7af9)
(cherry picked from commit eff5b43d2e843d5d537756d4fa58a8a010b6b527)
Conflicts: https://codeberg.org/forgejo/forgejo/pulls/1014
routers/web/user/profile.go
(cherry picked from commit 9d359be5ed11237088ccf6328571939af814984e)
(cherry picked from commit b1f3069a22a03734cffbfcd503ce004ba47561b7)
[MODERATION] add user blocking API
- Follow up for: #540, #802
- Add API routes for user blocking from user and organization
perspective.
- The new routes have integration testing.
- The new model functions have unit tests.
- Actually quite boring to write and to read this pull request.
(cherry picked from commit f3afaf15c7e34038363c9ce8e1ef957ec1e22b06)
(cherry picked from commit 6d754db3e5faff93a58fab2867737f81f40f6599)
(cherry picked from commit 2a89ddc0acffa9aea0f02b721934ef9e2b496a88)
(cherry picked from commit 4a147bff7e963ab9dffcfaefa5c2c01c59b4c732)
Conflicts:
routers/api/v1/api.go
templates/swagger/v1_json.tmpl
(cherry picked from commit bb8c33918569f65f25b014f0d7fe6ac20f9036fc)
(cherry picked from commit 5a11569a011b7d0a14391e2b5c07d0af825d7b0e)
(cherry picked from commit 2373c801ee6b84c368b498b16e6ad18650b38f42)
[MODERATION] restore redirect on unblock
ctx.RedirectToFirst(ctx.FormString("redirect_to"), ctx.ContextUser.HomeLink())
was replaced by
ctx.JSONOK()
in 128d77a3a Following up fixes for "Fix inconsistent user profile layout across tabs" (#25739)
thus changing the behavior (nicely spotted by the tests). This
restores it.
(cherry picked from commit 597c243707c3c86e7256faf1e6ba727224554de3)
(cherry picked from commit cfa539e590127b4b953b010fba3dea21c82a1714)
[MODERATION] Add test case (squash)
- Add an test case, to test an property of the function.
(cherry picked from commit 70dadb1916bfef8ba8cbc4e9b042cc8740f45e28)
[MODERATION] Block adding collaborators
- Ensure that the doer and blocked user cannot add each other as
collaborators to repositories.
- The Web UI gets an detailed message of the specific situation, the API
gets an generic Forbidden code.
- Unit tests has been added.
- Integration testing for Web and API has been added.
- This commit doesn't introduce removing each other as collaborators on
the block action, due to the complexity of database calls that needs to
be figured out. That deserves its own commit and test code.
(cherry picked from commit 747be949a1b3cd06f6586512f1af4630e55d7ad4)
[MODERATION] move locale_en-US.ini strings to avoid conflicts
Conflicts:
web_src/css/org.css
web_src/css/user.css
https://codeberg.org/forgejo/forgejo/pulls/1180
(cherry picked from commit e53f955c888ebaafc863a6e463da87f70f5605da)
Conflicts:
services/issue/comments.go
https://codeberg.org/forgejo/forgejo/pulls/1212
(cherry picked from commit b4a454b576eee0c7738b2f7df1acaf5bf7810d12)
Conflicts:
models/forgejo_migrations/migrate.go
options/locale/locale_en-US.ini
services/pull/pull.go
https://codeberg.org/forgejo/forgejo/pulls/1264
[MODERATION] Remove blocked user collaborations with doer
- When the doer blocks an user, who is also an collaborator on an
repository that the doer owns, remove that collaboration.
- Added unit tests.
- Refactor the unit test to be more organized.
(cherry picked from commit ec8701617830152680d69d50d64cb43cc2054a89)
(cherry picked from commit 313e6174d832501c57724ae7a6285194b7b81aab)
[MODERATION] QoL improvements (squash)
- Ensure that organisations cannot be blocked. It currently has no
effect, as all blocked operations cannot be executed from an
organisation standpoint.
- Refactored the API route to make use of the `UserAssignmentAPI`
middleware.
- Make more use of `t.Run` so that the test code is more clear about
which block of code belongs to which test case.
- Added more integration testing (to ensure the organisations cannot be
blocked and some authorization/permission checks).
(cherry picked from commit e9d638d0756ee20b6bf1eb999c988533a5066a68)
[MODERATION] s/{{avatar/{{ctx.AvatarUtils.Avatar/
(cherry picked from commit ce8b30be1327ab98df2ba061dd7e2a278b278c5b)
(cherry picked from commit f911dc402508b04cd5d5fb2f3332c2d640e4556e)
Conflicts:
options/locale/locale_en-US.ini
https://codeberg.org/forgejo/forgejo/pulls/1354
(cherry picked from commit c1b37b7fdaf06ee60da341dff76d703990c08082)
(cherry picked from commit 856a2e09036adf56d987c6eee364c431bc37fb2e)
[MODERATION] Show graceful error on comment creation
- When someone is blocked by the repository owner or issue poster and
try to comment on that issue, they get shown a graceful error.
- Adds integration test.
(cherry picked from commit 490646302e1e3dc3c59c9d75938b4647b6873ce7)
(cherry picked from commit d3d88667cbb928a6ff80658eba8ef0c6c508c9e0)
(cherry picked from commit 6818de13a921753e082b7c3d64c23917cc884e4b)
[MODERATION] Show graceful error on comment creation (squash) typo
(cherry picked from commit 1588d4834a37a744f092f2aeea6c9ef4795d7356)
(cherry picked from commit d510ea52d091503e841d66f2f604348add8b4535)
(cherry picked from commit 8249e93a14f628bb0e89fe3be678e4966539944e)
[MODERATION] Refactor integration testing (squash)
- Motivation for this PR is that I'd noticed that a lot of repeated
calls are happening between the test functions and that certain tests
weren't using helper functions like `GetCSRF`, therefor this refactor of
the integration tests to keep it: clean, small and hopefully more
maintainable and understandable.
- There are now three integration tests: `TestBlockUser`,
`TestBlockUserFromOrganization` and `TestBlockActions` (and has been
moved in that order in the source code).
- `TestBlockUser` is for doing blocking related actions as an user and
`TestBlockUserFromOrganization` as an organisation, even though they
execute the same kind of tests they do not share any database calls or
logic and therefor it currently doesn't make sense to merge them
together (hopefully such oppurtinutiy might be presented in the future).
- `TestBlockActions` now contain all tests for actions that should be
blocked after blocking has happened, most tests now share the same doer
and blocked users and a extra fixture has been added to make this
possible for the comment test.
- Less code, more comments and more re-use between tests.
(cherry picked from commit ffb393213d2f1269aad3c019d039cf60d0fe4b10)
(cherry picked from commit 85505e0f815fede589c272d301c95204f9596985)
(cherry picked from commit 0f3cf17761f6caedb17550f69de96990c2090af1)
[MODERATION] Fix network error (squash)
- Fix network error toast messages on user actions such as follow and
unfollow. This happened because the javascript code now expects an JSON
to be returned, but this wasn't the case due to
cfa539e590127b4953b010fba3dea21c82a1714.
- The integration testing has been adjusted to instead test for the
returned flash cookie.
(cherry picked from commit 112bc25e548d317a4ee00f9efa9068794a733e3b)
(cherry picked from commit 1194fe4899eb39dcb9a2410032ad0cc67a62b92b)
(cherry picked from commit 9abb95a8441e227874fe156095349a3173cc5a81)
[MODERATION] Modernize frontend (squash)
- Unify blocked users list.
- Use the new flex list classes for blocked users list to avoid using
the CSS helper classes and thereby be consistent in the design.
- Fix the modal by using the new modal class.
- Remove the icon in the modal as looks too big in the new design.
- Fix avatar not displaying as it was passing the context where the user
should've been passed.
- Don't use italics for 'Blocked since' text.
- Use namelink template to display the user's name and homelink.
(cherry picked from commit ec935a16a319b14e819ead828d1d9875280d9259)
(cherry picked from commit 67f37c83461aa393c53a799918e9708cb9b89b30)
Conflicts:
models/user/follow.go
models/user/user_test.go
routers/api/v1/user/follower.go
routers/web/shared/user/header.go
routers/web/user/profile.go
templates/swagger/v1_json.tmpl
https://codeberg.org/forgejo/forgejo/pulls/1468
(cherry picked from commit 6a9626839c6342cd2767ea12757ee2f78eaf443b)
Conflicts:
tests/integration/api_nodeinfo_test.go
https://codeberg.org/forgejo/forgejo/pulls/1508#issuecomment-1242385
(cherry picked from commit 7378b251b481ed1e60e816caf8f649e8397ee5fc)
Conflicts:
models/fixtures/watch.yml
models/issues/reaction.go
models/issues/reaction_test.go
routers/api/v1/repo/issue_reaction.go
routers/web/repo/issue.go
services/issue/issue.go
https://codeberg.org/forgejo/forgejo/pulls/1547
(cherry picked from commit c2028930c101223820de0bbafc318e9394c347b8)
(cherry picked from commit d3f9134aeeef784586e8412e8dbba0a8fceb0cd4)
(cherry picked from commit 7afe154c5c40bcc65accdf51c9224b2f7627a684)
(cherry picked from commit 99ac7353eb1e834a77fe42aa89208791cc2364ff)
(cherry picked from commit a9cde00c5c25ea8c427967cb7ab57abb618e44cb)
Conflicts:
services/user/delete.go
https://codeberg.org/forgejo/forgejo/pulls/1736
(cherry picked from commit 008c0cc63d1a3b8eb694bffbf77a7b25c56afd57)
[DEADCODE] add exceptions
(cherry picked from commit 12ddd2b10e3309f6430b0af42855c6af832832ee)
[MODERATION] Remove deadcode (squash)
- Remove deadcode that's no longer used by Forgejo.
(cherry picked from commit 0faeab4fa9b0aa59f86760b24ecbc07815026c82)
[MODERATION] Add repo transfers to blocked functionality (squash)
- When someone gets blocked, remove all pending repository transfers
from the blocked user to the doer.
- Do not allow to start transferring repositories to the doer as blocked user.
- Added unit testing.
- Added integration testing.
(cherry picked from commit 8a3caac33013482ddbee2fa51510c6918ba54466)
(cherry picked from commit a92b4cfeb63b90eb2d90d0feb51cec62e0502d84)
(cherry picked from commit acaaaf07d999974dbe5f9c5e792621c597bfb542)
(cherry picked from commit 735818863c1793aa6f6983afedc4bd3b36026ca5)
(cherry picked from commit f50fa43b32160d0d88eca1dbdca09b5f575fb62b)
(cherry picked from commit e16683643388fb3c60ea478f1419a6af4f4aa283)
(cherry picked from commit 82a0e4a3814a66ce44be6a031bdf08484586c61b)
(cherry picked from commit ff233c19c4a5edcc2b99a6f41a2d19dbe8c08b3b)
(cherry picked from commit 8ad87d215f2b6adb978de77e53ba2bf7ea571430)
[MODERATION] Fix unblock action (squash)
- Pass the whole context instead of only giving pieces.
- This fixes CSRF not correctly being inserted into the unblock buttons.
(cherry picked from commit 2aa51922ba6a0ea2f8644277baa74fc8f34ab95a)
(cherry picked from commit 7ee8db0f018340bc97f125415503e3e5db5f5082)
(cherry picked from commit e4f8b999bcd3b68b3ef7f54f5b17c3ada0308121)
(cherry picked from commit 05aea60b1302bbd3ea574a9c6c34e1005a5d73bf)
(cherry picked from commit dc0d61b012cfaf2385f71e97cda5f220b58b9fa4)
(cherry picked from commit f53fa583de671ff60a0a1d0f3ab8c260e1ba4e1f)
(cherry picked from commit c65b89a58d11b32009c710c2f5e75f0cd3539395)
(cherry picked from commit 69e50b9969db3ab71cefaed520757876a9629a5c)
(cherry picked from commit ec127440b86cb5fcf51799d8bd76a9fd6b9cebcc)
[MODERATION] cope with shared fixtures
* There is one more issue in the fixtures and this breaks some tests
* The users in the shared fixtures were renamed for clarity and that
breaks some tests
(cherry picked from commit 707a4edbdf67d0eb168d7bb430cf85dd8cd63c52)
Conflicts:
modules/indexer/issues/indexer_test.go
https://codeberg.org/forgejo/forgejo/pulls/1508
(cherry picked from commit 82cc044366c749df80ffad44eed2988b8e64211e)
(cherry picked from commit 2776aec7e85850f1d7f01a090a72491550fb9d29)
(cherry picked from commit 1fbde36dc784b5b2cc6193f02ff0d436b0f2a629)
(cherry picked from commit 1293db3c4e5df218501f5add9f9d41101ffcb8aa)
(cherry picked from commit 6476802175bac3ef78dd8f24ff6bebc16f398a78)
(cherry picked from commit 5740f2fc830356acb7929a02fe304008b94a0ca5)
(cherry picked from commit afc12d7b6e9b773fa89718aa79cd95c0e0ce4406)
[MODERATION] Fix transfer confirmation (squash)
- Fix problem caused by the clearer confirmation for dangerous actions commit.
(cherry picked from commit 3488f4a9cb1f7f73103ae0017d644f13ca3ab798)
(cherry picked from commit ed7de91f6ace23a1459bc6552edf719d62c7c941)
(cherry picked from commit 2d97929b9b7b8d979eb12bf0994d3f169d41f7fd)
(cherry picked from commit 50d035a7b058b9c4486c38cd4be0b02a4e1bf4d9)
(cherry picked from commit 0a0c07d78a1dee3489b97ab359bb957e3f7fb94b)
(cherry picked from commit 85e55c4dbc2f513f3d5254dac20915e8c3c22886)
(cherry picked from commit d8282122ad6e8b497de35d1ed89e3093a2cd5ee2)
(cherry picked from commit 3f0b3b6cc582c3d672d371dd9fe1203a56cb88c0)
[MODERATION] Purge issues on user deletion (squash)
(cherry picked from commit 4f529d9596ffbfc4e754c28830ba028f6344dc5b)
(cherry picked from commit f0e3acadd321fcb99e8ea3e3ce1c69df25c4ca4d)
(cherry picked from commit 682c4effe69dc0d4ed304fa7ce6259d9ce573629)
(cherry picked from commit e43c2d84fd4b6fd31e2370cec1034262d12e5c34)
(cherry picked from commit 9c8e53ccc78053026e4f667889959c23c8d95934)
(cherry picked from commit a9eb7ac783b2c16ee3702a88203bf857cb4147fc)
[MODERATION] Purge issues on user deletion (squash) revert shared fixtures workarounds
(cherry picked from commit 7224653a40e32186892e89bfedd49edecf5b8f81)
(cherry picked from commit aa6e8672f9473a9100e7575051dec9eda37709a0)
(cherry picked from commit 58c7947e95648f50237ddcd46b6bd025b224a70f)
(cherry picked from commit f1aacb1851b232082febcd7870a40a56de3855a6)
(cherry picked from commit 0bf174af87f7de9a8d869304f709e2bf41f3dde9)
(cherry picked from commit f9706f4335df3b7688ed60853d917efa72fb464a)
[MODERATION] Prepare moderation for context locale changes (squash)
- Resolves https://codeberg.org/forgejo/forgejo/issues/1711
(cherry picked from commit 2e289baea943dcece88f02d110b03d344308a261)
(cherry picked from commit 97b16bc19ae680db62608d6020b00fe5ac451c60)
[MODERATION] User blocking (squash) do not use shared fixture
It conflicts with a fixtured added in the commit
Fix comment permissions (#28213) (#28216)
(cherry picked from commit ab40799dcab24e9f495d765268b791931da81684)
(cherry picked from commit 996c92cafdb5b33a6d2d05d94038e950d97eb7de)
(cherry picked from commit 259912e3a69071c5ad57871464d0b79f69a8e72c)
Conflicts:
options/locale/locale_en-US.ini
https://codeberg.org/forgejo/forgejo/pulls/1921
(cherry picked from commit 1e82abc032c18015b92c93a7617a5dd06d50bd2d)
(cherry picked from commit a176fee1607d571b25b345184f1c50d403029610)
(cherry picked from commit 0480b76dfeda968849e900da9454a3efd82590fa)
(cherry picked from commit 4bc06b7b3841c74e3d790b1ef635c2b382ca7123)
(cherry picked from commit 073094cf722a927a623408d66537c758d7d64e4c)
(cherry picked from commit ac6201c647a4d3a2cfb2b0303b851a8fe7a29444)
(cherry picked from commit 7e0812674da3fbd1e96bdda820962edad6826fbd)
(cherry picked from commit 068c741e5696957710b3d1c2e18c00be2ffaa278)
Conflicts:
models/repo_transfer.go
models/repo_transfer_test.go
routers/web/user/profile.go
https://codeberg.org/forgejo/forgejo/pulls/2298
2023-08-14 23:07:38 +00:00
|
|
|
num_watches: 1
|
2022-10-17 16:23:27 +00:00
|
|
|
num_stars: 1
|
|
|
|
|
num_forks: 0
|
2019-02-10 19:27:19 +00:00
|
|
|
num_issues: 2
|
2017-01-01 18:15:09 +00:00
|
|
|
num_closed_issues: 1
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: true
|
2017-01-08 03:10:53 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 3
|
|
|
|
|
owner_id: 3
|
2023-09-14 02:59:53 +00:00
|
|
|
owner_name: org3
|
2017-01-08 03:10:53 +00:00
|
|
|
lower_name: repo3
|
|
|
|
|
name: repo3
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-09-12 06:48:13 +00:00
|
|
|
num_issues: 1
|
2017-01-08 03:10:53 +00:00
|
|
|
num_closed_issues: 0
|
2020-10-20 18:18:25 +00:00
|
|
|
num_pulls: 1
|
2017-01-08 03:10:53 +00:00
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
2020-08-17 03:07:38 +00:00
|
|
|
num_projects: 1
|
|
|
|
|
num_closed_projects: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_private: true
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
[MODERATION] User blocking
- Add the ability to block a user via their profile page.
- This will unstar their repositories and visa versa.
- Blocked users cannot create issues or pull requests on your the doer's repositories (mind that this is not the case for organizations).
- Blocked users cannot comment on the doer's opened issues or pull requests.
- Blocked users cannot add reactions to doer's comments.
- Blocked users cannot cause a notification trough mentioning the doer.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/540
(cherry picked from commit 687d852480388897db4d7b0cb397cf7135ab97b1)
(cherry picked from commit 0c32a4fde531018f74e01d9db6520895fcfa10cc)
(cherry picked from commit 1791130e3cb8470b9b39742e0004d5e4c7d1e64d)
(cherry picked from commit 37858b7e8fb6ba6c6ea0ac2562285b3b144efa19)
(cherry picked from commit a3e2bfd7e9eab82cc2c17061f6bb4e386a108c46)
(cherry picked from commit 7009b9fe87696b6182fab65ae82bf5a25cd39971)
Conflicts: https://codeberg.org/forgejo/forgejo/pulls/1014
routers/web/user/profile.go
templates/user/profile.tmpl
(cherry picked from commit b2aec3479177e725cfc7cbbb9d94753226928d1c)
(cherry picked from commit e2f1b73752f6bd3f830297d8f4ac438837471226)
[MODERATION] organization blocking a user (#802)
- Resolves #476
- Follow up for: #540
- Ensure that the doer and blocked person cannot follow each other.
- Ensure that the block person cannot watch doer's repositories.
- Add unblock button to the blocked user list.
- Add blocked since information to the blocked user list.
- Add extra testing to moderation code.
- Blocked user will unwatch doer's owned repository upon blocking.
- Add flash messages to let the user know the block/unblock action was successful.
- Add "You haven't blocked any users" message.
- Add organization blocking a user.
Co-authored-by: Gusted <postmaster@gusted.xyz>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/802
(cherry picked from commit 0505a1042197bd9136b58bc70ec7400a23471585)
(cherry picked from commit 37b4e6ef9b85e97d651cf350c9f3ea272ee8d76a)
(cherry picked from commit c17c121f2cf1f00e2a8d6fd6847705df47d0771e)
[MODERATION] organization blocking a user (#802) (squash)
Changes to adapt to:
6bbccdd177 Improve AJAX link and modal confirm dialog (#25210)
Refs: https://codeberg.org/forgejo/forgejo/pulls/882/files#issuecomment-945962
Refs: https://codeberg.org/forgejo/forgejo/pulls/882#issue-330561
(cherry picked from commit 523635f83cb2a1a4386769b79326088c5c4bbec7)
(cherry picked from commit 4743eaa6a0be0ef47de5b17c211dfe8bad1b7af9)
(cherry picked from commit eff5b43d2e843d5d537756d4fa58a8a010b6b527)
Conflicts: https://codeberg.org/forgejo/forgejo/pulls/1014
routers/web/user/profile.go
(cherry picked from commit 9d359be5ed11237088ccf6328571939af814984e)
(cherry picked from commit b1f3069a22a03734cffbfcd503ce004ba47561b7)
[MODERATION] add user blocking API
- Follow up for: #540, #802
- Add API routes for user blocking from user and organization
perspective.
- The new routes have integration testing.
- The new model functions have unit tests.
- Actually quite boring to write and to read this pull request.
(cherry picked from commit f3afaf15c7e34038363c9ce8e1ef957ec1e22b06)
(cherry picked from commit 6d754db3e5faff93a58fab2867737f81f40f6599)
(cherry picked from commit 2a89ddc0acffa9aea0f02b721934ef9e2b496a88)
(cherry picked from commit 4a147bff7e963ab9dffcfaefa5c2c01c59b4c732)
Conflicts:
routers/api/v1/api.go
templates/swagger/v1_json.tmpl
(cherry picked from commit bb8c33918569f65f25b014f0d7fe6ac20f9036fc)
(cherry picked from commit 5a11569a011b7d0a14391e2b5c07d0af825d7b0e)
(cherry picked from commit 2373c801ee6b84c368b498b16e6ad18650b38f42)
[MODERATION] restore redirect on unblock
ctx.RedirectToFirst(ctx.FormString("redirect_to"), ctx.ContextUser.HomeLink())
was replaced by
ctx.JSONOK()
in 128d77a3a Following up fixes for "Fix inconsistent user profile layout across tabs" (#25739)
thus changing the behavior (nicely spotted by the tests). This
restores it.
(cherry picked from commit 597c243707c3c86e7256faf1e6ba727224554de3)
(cherry picked from commit cfa539e590127b4b953b010fba3dea21c82a1714)
[MODERATION] Add test case (squash)
- Add an test case, to test an property of the function.
(cherry picked from commit 70dadb1916bfef8ba8cbc4e9b042cc8740f45e28)
[MODERATION] Block adding collaborators
- Ensure that the doer and blocked user cannot add each other as
collaborators to repositories.
- The Web UI gets an detailed message of the specific situation, the API
gets an generic Forbidden code.
- Unit tests has been added.
- Integration testing for Web and API has been added.
- This commit doesn't introduce removing each other as collaborators on
the block action, due to the complexity of database calls that needs to
be figured out. That deserves its own commit and test code.
(cherry picked from commit 747be949a1b3cd06f6586512f1af4630e55d7ad4)
[MODERATION] move locale_en-US.ini strings to avoid conflicts
Conflicts:
web_src/css/org.css
web_src/css/user.css
https://codeberg.org/forgejo/forgejo/pulls/1180
(cherry picked from commit e53f955c888ebaafc863a6e463da87f70f5605da)
Conflicts:
services/issue/comments.go
https://codeberg.org/forgejo/forgejo/pulls/1212
(cherry picked from commit b4a454b576eee0c7738b2f7df1acaf5bf7810d12)
Conflicts:
models/forgejo_migrations/migrate.go
options/locale/locale_en-US.ini
services/pull/pull.go
https://codeberg.org/forgejo/forgejo/pulls/1264
[MODERATION] Remove blocked user collaborations with doer
- When the doer blocks an user, who is also an collaborator on an
repository that the doer owns, remove that collaboration.
- Added unit tests.
- Refactor the unit test to be more organized.
(cherry picked from commit ec8701617830152680d69d50d64cb43cc2054a89)
(cherry picked from commit 313e6174d832501c57724ae7a6285194b7b81aab)
[MODERATION] QoL improvements (squash)
- Ensure that organisations cannot be blocked. It currently has no
effect, as all blocked operations cannot be executed from an
organisation standpoint.
- Refactored the API route to make use of the `UserAssignmentAPI`
middleware.
- Make more use of `t.Run` so that the test code is more clear about
which block of code belongs to which test case.
- Added more integration testing (to ensure the organisations cannot be
blocked and some authorization/permission checks).
(cherry picked from commit e9d638d0756ee20b6bf1eb999c988533a5066a68)
[MODERATION] s/{{avatar/{{ctx.AvatarUtils.Avatar/
(cherry picked from commit ce8b30be1327ab98df2ba061dd7e2a278b278c5b)
(cherry picked from commit f911dc402508b04cd5d5fb2f3332c2d640e4556e)
Conflicts:
options/locale/locale_en-US.ini
https://codeberg.org/forgejo/forgejo/pulls/1354
(cherry picked from commit c1b37b7fdaf06ee60da341dff76d703990c08082)
(cherry picked from commit 856a2e09036adf56d987c6eee364c431bc37fb2e)
[MODERATION] Show graceful error on comment creation
- When someone is blocked by the repository owner or issue poster and
try to comment on that issue, they get shown a graceful error.
- Adds integration test.
(cherry picked from commit 490646302e1e3dc3c59c9d75938b4647b6873ce7)
(cherry picked from commit d3d88667cbb928a6ff80658eba8ef0c6c508c9e0)
(cherry picked from commit 6818de13a921753e082b7c3d64c23917cc884e4b)
[MODERATION] Show graceful error on comment creation (squash) typo
(cherry picked from commit 1588d4834a37a744f092f2aeea6c9ef4795d7356)
(cherry picked from commit d510ea52d091503e841d66f2f604348add8b4535)
(cherry picked from commit 8249e93a14f628bb0e89fe3be678e4966539944e)
[MODERATION] Refactor integration testing (squash)
- Motivation for this PR is that I'd noticed that a lot of repeated
calls are happening between the test functions and that certain tests
weren't using helper functions like `GetCSRF`, therefor this refactor of
the integration tests to keep it: clean, small and hopefully more
maintainable and understandable.
- There are now three integration tests: `TestBlockUser`,
`TestBlockUserFromOrganization` and `TestBlockActions` (and has been
moved in that order in the source code).
- `TestBlockUser` is for doing blocking related actions as an user and
`TestBlockUserFromOrganization` as an organisation, even though they
execute the same kind of tests they do not share any database calls or
logic and therefor it currently doesn't make sense to merge them
together (hopefully such oppurtinutiy might be presented in the future).
- `TestBlockActions` now contain all tests for actions that should be
blocked after blocking has happened, most tests now share the same doer
and blocked users and a extra fixture has been added to make this
possible for the comment test.
- Less code, more comments and more re-use between tests.
(cherry picked from commit ffb393213d2f1269aad3c019d039cf60d0fe4b10)
(cherry picked from commit 85505e0f815fede589c272d301c95204f9596985)
(cherry picked from commit 0f3cf17761f6caedb17550f69de96990c2090af1)
[MODERATION] Fix network error (squash)
- Fix network error toast messages on user actions such as follow and
unfollow. This happened because the javascript code now expects an JSON
to be returned, but this wasn't the case due to
cfa539e590127b4953b010fba3dea21c82a1714.
- The integration testing has been adjusted to instead test for the
returned flash cookie.
(cherry picked from commit 112bc25e548d317a4ee00f9efa9068794a733e3b)
(cherry picked from commit 1194fe4899eb39dcb9a2410032ad0cc67a62b92b)
(cherry picked from commit 9abb95a8441e227874fe156095349a3173cc5a81)
[MODERATION] Modernize frontend (squash)
- Unify blocked users list.
- Use the new flex list classes for blocked users list to avoid using
the CSS helper classes and thereby be consistent in the design.
- Fix the modal by using the new modal class.
- Remove the icon in the modal as looks too big in the new design.
- Fix avatar not displaying as it was passing the context where the user
should've been passed.
- Don't use italics for 'Blocked since' text.
- Use namelink template to display the user's name and homelink.
(cherry picked from commit ec935a16a319b14e819ead828d1d9875280d9259)
(cherry picked from commit 67f37c83461aa393c53a799918e9708cb9b89b30)
Conflicts:
models/user/follow.go
models/user/user_test.go
routers/api/v1/user/follower.go
routers/web/shared/user/header.go
routers/web/user/profile.go
templates/swagger/v1_json.tmpl
https://codeberg.org/forgejo/forgejo/pulls/1468
(cherry picked from commit 6a9626839c6342cd2767ea12757ee2f78eaf443b)
Conflicts:
tests/integration/api_nodeinfo_test.go
https://codeberg.org/forgejo/forgejo/pulls/1508#issuecomment-1242385
(cherry picked from commit 7378b251b481ed1e60e816caf8f649e8397ee5fc)
Conflicts:
models/fixtures/watch.yml
models/issues/reaction.go
models/issues/reaction_test.go
routers/api/v1/repo/issue_reaction.go
routers/web/repo/issue.go
services/issue/issue.go
https://codeberg.org/forgejo/forgejo/pulls/1547
(cherry picked from commit c2028930c101223820de0bbafc318e9394c347b8)
(cherry picked from commit d3f9134aeeef784586e8412e8dbba0a8fceb0cd4)
(cherry picked from commit 7afe154c5c40bcc65accdf51c9224b2f7627a684)
(cherry picked from commit 99ac7353eb1e834a77fe42aa89208791cc2364ff)
(cherry picked from commit a9cde00c5c25ea8c427967cb7ab57abb618e44cb)
Conflicts:
services/user/delete.go
https://codeberg.org/forgejo/forgejo/pulls/1736
(cherry picked from commit 008c0cc63d1a3b8eb694bffbf77a7b25c56afd57)
[DEADCODE] add exceptions
(cherry picked from commit 12ddd2b10e3309f6430b0af42855c6af832832ee)
[MODERATION] Remove deadcode (squash)
- Remove deadcode that's no longer used by Forgejo.
(cherry picked from commit 0faeab4fa9b0aa59f86760b24ecbc07815026c82)
[MODERATION] Add repo transfers to blocked functionality (squash)
- When someone gets blocked, remove all pending repository transfers
from the blocked user to the doer.
- Do not allow to start transferring repositories to the doer as blocked user.
- Added unit testing.
- Added integration testing.
(cherry picked from commit 8a3caac33013482ddbee2fa51510c6918ba54466)
(cherry picked from commit a92b4cfeb63b90eb2d90d0feb51cec62e0502d84)
(cherry picked from commit acaaaf07d999974dbe5f9c5e792621c597bfb542)
(cherry picked from commit 735818863c1793aa6f6983afedc4bd3b36026ca5)
(cherry picked from commit f50fa43b32160d0d88eca1dbdca09b5f575fb62b)
(cherry picked from commit e16683643388fb3c60ea478f1419a6af4f4aa283)
(cherry picked from commit 82a0e4a3814a66ce44be6a031bdf08484586c61b)
(cherry picked from commit ff233c19c4a5edcc2b99a6f41a2d19dbe8c08b3b)
(cherry picked from commit 8ad87d215f2b6adb978de77e53ba2bf7ea571430)
[MODERATION] Fix unblock action (squash)
- Pass the whole context instead of only giving pieces.
- This fixes CSRF not correctly being inserted into the unblock buttons.
(cherry picked from commit 2aa51922ba6a0ea2f8644277baa74fc8f34ab95a)
(cherry picked from commit 7ee8db0f018340bc97f125415503e3e5db5f5082)
(cherry picked from commit e4f8b999bcd3b68b3ef7f54f5b17c3ada0308121)
(cherry picked from commit 05aea60b1302bbd3ea574a9c6c34e1005a5d73bf)
(cherry picked from commit dc0d61b012cfaf2385f71e97cda5f220b58b9fa4)
(cherry picked from commit f53fa583de671ff60a0a1d0f3ab8c260e1ba4e1f)
(cherry picked from commit c65b89a58d11b32009c710c2f5e75f0cd3539395)
(cherry picked from commit 69e50b9969db3ab71cefaed520757876a9629a5c)
(cherry picked from commit ec127440b86cb5fcf51799d8bd76a9fd6b9cebcc)
[MODERATION] cope with shared fixtures
* There is one more issue in the fixtures and this breaks some tests
* The users in the shared fixtures were renamed for clarity and that
breaks some tests
(cherry picked from commit 707a4edbdf67d0eb168d7bb430cf85dd8cd63c52)
Conflicts:
modules/indexer/issues/indexer_test.go
https://codeberg.org/forgejo/forgejo/pulls/1508
(cherry picked from commit 82cc044366c749df80ffad44eed2988b8e64211e)
(cherry picked from commit 2776aec7e85850f1d7f01a090a72491550fb9d29)
(cherry picked from commit 1fbde36dc784b5b2cc6193f02ff0d436b0f2a629)
(cherry picked from commit 1293db3c4e5df218501f5add9f9d41101ffcb8aa)
(cherry picked from commit 6476802175bac3ef78dd8f24ff6bebc16f398a78)
(cherry picked from commit 5740f2fc830356acb7929a02fe304008b94a0ca5)
(cherry picked from commit afc12d7b6e9b773fa89718aa79cd95c0e0ce4406)
[MODERATION] Fix transfer confirmation (squash)
- Fix problem caused by the clearer confirmation for dangerous actions commit.
(cherry picked from commit 3488f4a9cb1f7f73103ae0017d644f13ca3ab798)
(cherry picked from commit ed7de91f6ace23a1459bc6552edf719d62c7c941)
(cherry picked from commit 2d97929b9b7b8d979eb12bf0994d3f169d41f7fd)
(cherry picked from commit 50d035a7b058b9c4486c38cd4be0b02a4e1bf4d9)
(cherry picked from commit 0a0c07d78a1dee3489b97ab359bb957e3f7fb94b)
(cherry picked from commit 85e55c4dbc2f513f3d5254dac20915e8c3c22886)
(cherry picked from commit d8282122ad6e8b497de35d1ed89e3093a2cd5ee2)
(cherry picked from commit 3f0b3b6cc582c3d672d371dd9fe1203a56cb88c0)
[MODERATION] Purge issues on user deletion (squash)
(cherry picked from commit 4f529d9596ffbfc4e754c28830ba028f6344dc5b)
(cherry picked from commit f0e3acadd321fcb99e8ea3e3ce1c69df25c4ca4d)
(cherry picked from commit 682c4effe69dc0d4ed304fa7ce6259d9ce573629)
(cherry picked from commit e43c2d84fd4b6fd31e2370cec1034262d12e5c34)
(cherry picked from commit 9c8e53ccc78053026e4f667889959c23c8d95934)
(cherry picked from commit a9eb7ac783b2c16ee3702a88203bf857cb4147fc)
[MODERATION] Purge issues on user deletion (squash) revert shared fixtures workarounds
(cherry picked from commit 7224653a40e32186892e89bfedd49edecf5b8f81)
(cherry picked from commit aa6e8672f9473a9100e7575051dec9eda37709a0)
(cherry picked from commit 58c7947e95648f50237ddcd46b6bd025b224a70f)
(cherry picked from commit f1aacb1851b232082febcd7870a40a56de3855a6)
(cherry picked from commit 0bf174af87f7de9a8d869304f709e2bf41f3dde9)
(cherry picked from commit f9706f4335df3b7688ed60853d917efa72fb464a)
[MODERATION] Prepare moderation for context locale changes (squash)
- Resolves https://codeberg.org/forgejo/forgejo/issues/1711
(cherry picked from commit 2e289baea943dcece88f02d110b03d344308a261)
(cherry picked from commit 97b16bc19ae680db62608d6020b00fe5ac451c60)
[MODERATION] User blocking (squash) do not use shared fixture
It conflicts with a fixtured added in the commit
Fix comment permissions (#28213) (#28216)
(cherry picked from commit ab40799dcab24e9f495d765268b791931da81684)
(cherry picked from commit 996c92cafdb5b33a6d2d05d94038e950d97eb7de)
(cherry picked from commit 259912e3a69071c5ad57871464d0b79f69a8e72c)
Conflicts:
options/locale/locale_en-US.ini
https://codeberg.org/forgejo/forgejo/pulls/1921
(cherry picked from commit 1e82abc032c18015b92c93a7617a5dd06d50bd2d)
(cherry picked from commit a176fee1607d571b25b345184f1c50d403029610)
(cherry picked from commit 0480b76dfeda968849e900da9454a3efd82590fa)
(cherry picked from commit 4bc06b7b3841c74e3d790b1ef635c2b382ca7123)
(cherry picked from commit 073094cf722a927a623408d66537c758d7d64e4c)
(cherry picked from commit ac6201c647a4d3a2cfb2b0303b851a8fe7a29444)
(cherry picked from commit 7e0812674da3fbd1e96bdda820962edad6826fbd)
(cherry picked from commit 068c741e5696957710b3d1c2e18c00be2ffaa278)
Conflicts:
models/repo_transfer.go
models/repo_transfer_test.go
routers/web/user/profile.go
https://codeberg.org/forgejo/forgejo/pulls/2298
2023-08-14 23:07:38 +00:00
|
|
|
status: 2
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-01-08 03:10:53 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 4
|
|
|
|
|
owner_id: 5
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user5
|
2017-01-08 03:10:53 +00:00
|
|
|
lower_name: repo4
|
|
|
|
|
name: repo4
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 1
|
|
|
|
|
num_forks: 0
|
2017-01-08 03:10:53 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
2020-08-17 03:07:38 +00:00
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 1
|
2022-10-17 16:23:27 +00:00
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-01-24 16:16:36 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 5
|
|
|
|
|
owner_id: 3
|
2023-09-14 02:59:53 +00:00
|
|
|
owner_name: org3
|
2017-01-24 16:16:36 +00:00
|
|
|
lower_name: repo5
|
|
|
|
|
name: repo5
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2021-08-13 20:47:25 +00:00
|
|
|
num_issues: 1
|
2017-01-24 16:16:36 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
2023-07-01 02:52:52 +00:00
|
|
|
is_empty: false
|
2022-10-17 16:23:27 +00:00
|
|
|
is_archived: false
|
2017-01-24 16:16:36 +00:00
|
|
|
is_mirror: true
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-02-06 15:18:36 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 6
|
|
|
|
|
owner_id: 10
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user10
|
2017-02-06 15:18:36 +00:00
|
|
|
lower_name: repo6
|
|
|
|
|
name: repo6
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-02-06 15:18:36 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-02-06 15:18:36 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-02-06 15:18:36 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 7
|
|
|
|
|
owner_id: 10
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user10
|
2017-02-06 15:18:36 +00:00
|
|
|
lower_name: repo7
|
|
|
|
|
name: repo7
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-02-06 15:18:36 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-02-06 15:18:36 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-02-06 15:18:36 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 8
|
|
|
|
|
owner_id: 10
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user10
|
2017-02-06 15:18:36 +00:00
|
|
|
lower_name: repo8
|
|
|
|
|
name: repo8
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-02-06 15:18:36 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-02-06 15:18:36 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-02-11 10:57:57 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 9
|
|
|
|
|
owner_id: 11
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user11
|
2017-02-11 10:57:57 +00:00
|
|
|
lower_name: repo9
|
|
|
|
|
name: repo9
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-02-11 10:57:57 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-02-11 10:57:57 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-02-15 15:24:23 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 10
|
|
|
|
|
owner_id: 12
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user12
|
2017-02-15 15:24:23 +00:00
|
|
|
lower_name: repo10
|
|
|
|
|
name: repo10
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 1
|
[MODERATION] User blocking
- Add the ability to block a user via their profile page.
- This will unstar their repositories and visa versa.
- Blocked users cannot create issues or pull requests on your the doer's repositories (mind that this is not the case for organizations).
- Blocked users cannot comment on the doer's opened issues or pull requests.
- Blocked users cannot add reactions to doer's comments.
- Blocked users cannot cause a notification trough mentioning the doer.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/540
(cherry picked from commit 687d852480388897db4d7b0cb397cf7135ab97b1)
(cherry picked from commit 0c32a4fde531018f74e01d9db6520895fcfa10cc)
(cherry picked from commit 1791130e3cb8470b9b39742e0004d5e4c7d1e64d)
(cherry picked from commit 37858b7e8fb6ba6c6ea0ac2562285b3b144efa19)
(cherry picked from commit a3e2bfd7e9eab82cc2c17061f6bb4e386a108c46)
(cherry picked from commit 7009b9fe87696b6182fab65ae82bf5a25cd39971)
Conflicts: https://codeberg.org/forgejo/forgejo/pulls/1014
routers/web/user/profile.go
templates/user/profile.tmpl
(cherry picked from commit b2aec3479177e725cfc7cbbb9d94753226928d1c)
(cherry picked from commit e2f1b73752f6bd3f830297d8f4ac438837471226)
[MODERATION] organization blocking a user (#802)
- Resolves #476
- Follow up for: #540
- Ensure that the doer and blocked person cannot follow each other.
- Ensure that the block person cannot watch doer's repositories.
- Add unblock button to the blocked user list.
- Add blocked since information to the blocked user list.
- Add extra testing to moderation code.
- Blocked user will unwatch doer's owned repository upon blocking.
- Add flash messages to let the user know the block/unblock action was successful.
- Add "You haven't blocked any users" message.
- Add organization blocking a user.
Co-authored-by: Gusted <postmaster@gusted.xyz>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/802
(cherry picked from commit 0505a1042197bd9136b58bc70ec7400a23471585)
(cherry picked from commit 37b4e6ef9b85e97d651cf350c9f3ea272ee8d76a)
(cherry picked from commit c17c121f2cf1f00e2a8d6fd6847705df47d0771e)
[MODERATION] organization blocking a user (#802) (squash)
Changes to adapt to:
6bbccdd177 Improve AJAX link and modal confirm dialog (#25210)
Refs: https://codeberg.org/forgejo/forgejo/pulls/882/files#issuecomment-945962
Refs: https://codeberg.org/forgejo/forgejo/pulls/882#issue-330561
(cherry picked from commit 523635f83cb2a1a4386769b79326088c5c4bbec7)
(cherry picked from commit 4743eaa6a0be0ef47de5b17c211dfe8bad1b7af9)
(cherry picked from commit eff5b43d2e843d5d537756d4fa58a8a010b6b527)
Conflicts: https://codeberg.org/forgejo/forgejo/pulls/1014
routers/web/user/profile.go
(cherry picked from commit 9d359be5ed11237088ccf6328571939af814984e)
(cherry picked from commit b1f3069a22a03734cffbfcd503ce004ba47561b7)
[MODERATION] add user blocking API
- Follow up for: #540, #802
- Add API routes for user blocking from user and organization
perspective.
- The new routes have integration testing.
- The new model functions have unit tests.
- Actually quite boring to write and to read this pull request.
(cherry picked from commit f3afaf15c7e34038363c9ce8e1ef957ec1e22b06)
(cherry picked from commit 6d754db3e5faff93a58fab2867737f81f40f6599)
(cherry picked from commit 2a89ddc0acffa9aea0f02b721934ef9e2b496a88)
(cherry picked from commit 4a147bff7e963ab9dffcfaefa5c2c01c59b4c732)
Conflicts:
routers/api/v1/api.go
templates/swagger/v1_json.tmpl
(cherry picked from commit bb8c33918569f65f25b014f0d7fe6ac20f9036fc)
(cherry picked from commit 5a11569a011b7d0a14391e2b5c07d0af825d7b0e)
(cherry picked from commit 2373c801ee6b84c368b498b16e6ad18650b38f42)
[MODERATION] restore redirect on unblock
ctx.RedirectToFirst(ctx.FormString("redirect_to"), ctx.ContextUser.HomeLink())
was replaced by
ctx.JSONOK()
in 128d77a3a Following up fixes for "Fix inconsistent user profile layout across tabs" (#25739)
thus changing the behavior (nicely spotted by the tests). This
restores it.
(cherry picked from commit 597c243707c3c86e7256faf1e6ba727224554de3)
(cherry picked from commit cfa539e590127b4b953b010fba3dea21c82a1714)
[MODERATION] Add test case (squash)
- Add an test case, to test an property of the function.
(cherry picked from commit 70dadb1916bfef8ba8cbc4e9b042cc8740f45e28)
[MODERATION] Block adding collaborators
- Ensure that the doer and blocked user cannot add each other as
collaborators to repositories.
- The Web UI gets an detailed message of the specific situation, the API
gets an generic Forbidden code.
- Unit tests has been added.
- Integration testing for Web and API has been added.
- This commit doesn't introduce removing each other as collaborators on
the block action, due to the complexity of database calls that needs to
be figured out. That deserves its own commit and test code.
(cherry picked from commit 747be949a1b3cd06f6586512f1af4630e55d7ad4)
[MODERATION] move locale_en-US.ini strings to avoid conflicts
Conflicts:
web_src/css/org.css
web_src/css/user.css
https://codeberg.org/forgejo/forgejo/pulls/1180
(cherry picked from commit e53f955c888ebaafc863a6e463da87f70f5605da)
Conflicts:
services/issue/comments.go
https://codeberg.org/forgejo/forgejo/pulls/1212
(cherry picked from commit b4a454b576eee0c7738b2f7df1acaf5bf7810d12)
Conflicts:
models/forgejo_migrations/migrate.go
options/locale/locale_en-US.ini
services/pull/pull.go
https://codeberg.org/forgejo/forgejo/pulls/1264
[MODERATION] Remove blocked user collaborations with doer
- When the doer blocks an user, who is also an collaborator on an
repository that the doer owns, remove that collaboration.
- Added unit tests.
- Refactor the unit test to be more organized.
(cherry picked from commit ec8701617830152680d69d50d64cb43cc2054a89)
(cherry picked from commit 313e6174d832501c57724ae7a6285194b7b81aab)
[MODERATION] QoL improvements (squash)
- Ensure that organisations cannot be blocked. It currently has no
effect, as all blocked operations cannot be executed from an
organisation standpoint.
- Refactored the API route to make use of the `UserAssignmentAPI`
middleware.
- Make more use of `t.Run` so that the test code is more clear about
which block of code belongs to which test case.
- Added more integration testing (to ensure the organisations cannot be
blocked and some authorization/permission checks).
(cherry picked from commit e9d638d0756ee20b6bf1eb999c988533a5066a68)
[MODERATION] s/{{avatar/{{ctx.AvatarUtils.Avatar/
(cherry picked from commit ce8b30be1327ab98df2ba061dd7e2a278b278c5b)
(cherry picked from commit f911dc402508b04cd5d5fb2f3332c2d640e4556e)
Conflicts:
options/locale/locale_en-US.ini
https://codeberg.org/forgejo/forgejo/pulls/1354
(cherry picked from commit c1b37b7fdaf06ee60da341dff76d703990c08082)
(cherry picked from commit 856a2e09036adf56d987c6eee364c431bc37fb2e)
[MODERATION] Show graceful error on comment creation
- When someone is blocked by the repository owner or issue poster and
try to comment on that issue, they get shown a graceful error.
- Adds integration test.
(cherry picked from commit 490646302e1e3dc3c59c9d75938b4647b6873ce7)
(cherry picked from commit d3d88667cbb928a6ff80658eba8ef0c6c508c9e0)
(cherry picked from commit 6818de13a921753e082b7c3d64c23917cc884e4b)
[MODERATION] Show graceful error on comment creation (squash) typo
(cherry picked from commit 1588d4834a37a744f092f2aeea6c9ef4795d7356)
(cherry picked from commit d510ea52d091503e841d66f2f604348add8b4535)
(cherry picked from commit 8249e93a14f628bb0e89fe3be678e4966539944e)
[MODERATION] Refactor integration testing (squash)
- Motivation for this PR is that I'd noticed that a lot of repeated
calls are happening between the test functions and that certain tests
weren't using helper functions like `GetCSRF`, therefor this refactor of
the integration tests to keep it: clean, small and hopefully more
maintainable and understandable.
- There are now three integration tests: `TestBlockUser`,
`TestBlockUserFromOrganization` and `TestBlockActions` (and has been
moved in that order in the source code).
- `TestBlockUser` is for doing blocking related actions as an user and
`TestBlockUserFromOrganization` as an organisation, even though they
execute the same kind of tests they do not share any database calls or
logic and therefor it currently doesn't make sense to merge them
together (hopefully such oppurtinutiy might be presented in the future).
- `TestBlockActions` now contain all tests for actions that should be
blocked after blocking has happened, most tests now share the same doer
and blocked users and a extra fixture has been added to make this
possible for the comment test.
- Less code, more comments and more re-use between tests.
(cherry picked from commit ffb393213d2f1269aad3c019d039cf60d0fe4b10)
(cherry picked from commit 85505e0f815fede589c272d301c95204f9596985)
(cherry picked from commit 0f3cf17761f6caedb17550f69de96990c2090af1)
[MODERATION] Fix network error (squash)
- Fix network error toast messages on user actions such as follow and
unfollow. This happened because the javascript code now expects an JSON
to be returned, but this wasn't the case due to
cfa539e590127b4953b010fba3dea21c82a1714.
- The integration testing has been adjusted to instead test for the
returned flash cookie.
(cherry picked from commit 112bc25e548d317a4ee00f9efa9068794a733e3b)
(cherry picked from commit 1194fe4899eb39dcb9a2410032ad0cc67a62b92b)
(cherry picked from commit 9abb95a8441e227874fe156095349a3173cc5a81)
[MODERATION] Modernize frontend (squash)
- Unify blocked users list.
- Use the new flex list classes for blocked users list to avoid using
the CSS helper classes and thereby be consistent in the design.
- Fix the modal by using the new modal class.
- Remove the icon in the modal as looks too big in the new design.
- Fix avatar not displaying as it was passing the context where the user
should've been passed.
- Don't use italics for 'Blocked since' text.
- Use namelink template to display the user's name and homelink.
(cherry picked from commit ec935a16a319b14e819ead828d1d9875280d9259)
(cherry picked from commit 67f37c83461aa393c53a799918e9708cb9b89b30)
Conflicts:
models/user/follow.go
models/user/user_test.go
routers/api/v1/user/follower.go
routers/web/shared/user/header.go
routers/web/user/profile.go
templates/swagger/v1_json.tmpl
https://codeberg.org/forgejo/forgejo/pulls/1468
(cherry picked from commit 6a9626839c6342cd2767ea12757ee2f78eaf443b)
Conflicts:
tests/integration/api_nodeinfo_test.go
https://codeberg.org/forgejo/forgejo/pulls/1508#issuecomment-1242385
(cherry picked from commit 7378b251b481ed1e60e816caf8f649e8397ee5fc)
Conflicts:
models/fixtures/watch.yml
models/issues/reaction.go
models/issues/reaction_test.go
routers/api/v1/repo/issue_reaction.go
routers/web/repo/issue.go
services/issue/issue.go
https://codeberg.org/forgejo/forgejo/pulls/1547
(cherry picked from commit c2028930c101223820de0bbafc318e9394c347b8)
(cherry picked from commit d3f9134aeeef784586e8412e8dbba0a8fceb0cd4)
(cherry picked from commit 7afe154c5c40bcc65accdf51c9224b2f7627a684)
(cherry picked from commit 99ac7353eb1e834a77fe42aa89208791cc2364ff)
(cherry picked from commit a9cde00c5c25ea8c427967cb7ab57abb618e44cb)
Conflicts:
services/user/delete.go
https://codeberg.org/forgejo/forgejo/pulls/1736
(cherry picked from commit 008c0cc63d1a3b8eb694bffbf77a7b25c56afd57)
[DEADCODE] add exceptions
(cherry picked from commit 12ddd2b10e3309f6430b0af42855c6af832832ee)
[MODERATION] Remove deadcode (squash)
- Remove deadcode that's no longer used by Forgejo.
(cherry picked from commit 0faeab4fa9b0aa59f86760b24ecbc07815026c82)
[MODERATION] Add repo transfers to blocked functionality (squash)
- When someone gets blocked, remove all pending repository transfers
from the blocked user to the doer.
- Do not allow to start transferring repositories to the doer as blocked user.
- Added unit testing.
- Added integration testing.
(cherry picked from commit 8a3caac33013482ddbee2fa51510c6918ba54466)
(cherry picked from commit a92b4cfeb63b90eb2d90d0feb51cec62e0502d84)
(cherry picked from commit acaaaf07d999974dbe5f9c5e792621c597bfb542)
(cherry picked from commit 735818863c1793aa6f6983afedc4bd3b36026ca5)
(cherry picked from commit f50fa43b32160d0d88eca1dbdca09b5f575fb62b)
(cherry picked from commit e16683643388fb3c60ea478f1419a6af4f4aa283)
(cherry picked from commit 82a0e4a3814a66ce44be6a031bdf08484586c61b)
(cherry picked from commit ff233c19c4a5edcc2b99a6f41a2d19dbe8c08b3b)
(cherry picked from commit 8ad87d215f2b6adb978de77e53ba2bf7ea571430)
[MODERATION] Fix unblock action (squash)
- Pass the whole context instead of only giving pieces.
- This fixes CSRF not correctly being inserted into the unblock buttons.
(cherry picked from commit 2aa51922ba6a0ea2f8644277baa74fc8f34ab95a)
(cherry picked from commit 7ee8db0f018340bc97f125415503e3e5db5f5082)
(cherry picked from commit e4f8b999bcd3b68b3ef7f54f5b17c3ada0308121)
(cherry picked from commit 05aea60b1302bbd3ea574a9c6c34e1005a5d73bf)
(cherry picked from commit dc0d61b012cfaf2385f71e97cda5f220b58b9fa4)
(cherry picked from commit f53fa583de671ff60a0a1d0f3ab8c260e1ba4e1f)
(cherry picked from commit c65b89a58d11b32009c710c2f5e75f0cd3539395)
(cherry picked from commit 69e50b9969db3ab71cefaed520757876a9629a5c)
(cherry picked from commit ec127440b86cb5fcf51799d8bd76a9fd6b9cebcc)
[MODERATION] cope with shared fixtures
* There is one more issue in the fixtures and this breaks some tests
* The users in the shared fixtures were renamed for clarity and that
breaks some tests
(cherry picked from commit 707a4edbdf67d0eb168d7bb430cf85dd8cd63c52)
Conflicts:
modules/indexer/issues/indexer_test.go
https://codeberg.org/forgejo/forgejo/pulls/1508
(cherry picked from commit 82cc044366c749df80ffad44eed2988b8e64211e)
(cherry picked from commit 2776aec7e85850f1d7f01a090a72491550fb9d29)
(cherry picked from commit 1fbde36dc784b5b2cc6193f02ff0d436b0f2a629)
(cherry picked from commit 1293db3c4e5df218501f5add9f9d41101ffcb8aa)
(cherry picked from commit 6476802175bac3ef78dd8f24ff6bebc16f398a78)
(cherry picked from commit 5740f2fc830356acb7929a02fe304008b94a0ca5)
(cherry picked from commit afc12d7b6e9b773fa89718aa79cd95c0e0ce4406)
[MODERATION] Fix transfer confirmation (squash)
- Fix problem caused by the clearer confirmation for dangerous actions commit.
(cherry picked from commit 3488f4a9cb1f7f73103ae0017d644f13ca3ab798)
(cherry picked from commit ed7de91f6ace23a1459bc6552edf719d62c7c941)
(cherry picked from commit 2d97929b9b7b8d979eb12bf0994d3f169d41f7fd)
(cherry picked from commit 50d035a7b058b9c4486c38cd4be0b02a4e1bf4d9)
(cherry picked from commit 0a0c07d78a1dee3489b97ab359bb957e3f7fb94b)
(cherry picked from commit 85e55c4dbc2f513f3d5254dac20915e8c3c22886)
(cherry picked from commit d8282122ad6e8b497de35d1ed89e3093a2cd5ee2)
(cherry picked from commit 3f0b3b6cc582c3d672d371dd9fe1203a56cb88c0)
[MODERATION] Purge issues on user deletion (squash)
(cherry picked from commit 4f529d9596ffbfc4e754c28830ba028f6344dc5b)
(cherry picked from commit f0e3acadd321fcb99e8ea3e3ce1c69df25c4ca4d)
(cherry picked from commit 682c4effe69dc0d4ed304fa7ce6259d9ce573629)
(cherry picked from commit e43c2d84fd4b6fd31e2370cec1034262d12e5c34)
(cherry picked from commit 9c8e53ccc78053026e4f667889959c23c8d95934)
(cherry picked from commit a9eb7ac783b2c16ee3702a88203bf857cb4147fc)
[MODERATION] Purge issues on user deletion (squash) revert shared fixtures workarounds
(cherry picked from commit 7224653a40e32186892e89bfedd49edecf5b8f81)
(cherry picked from commit aa6e8672f9473a9100e7575051dec9eda37709a0)
(cherry picked from commit 58c7947e95648f50237ddcd46b6bd025b224a70f)
(cherry picked from commit f1aacb1851b232082febcd7870a40a56de3855a6)
(cherry picked from commit 0bf174af87f7de9a8d869304f709e2bf41f3dde9)
(cherry picked from commit f9706f4335df3b7688ed60853d917efa72fb464a)
[MODERATION] Prepare moderation for context locale changes (squash)
- Resolves https://codeberg.org/forgejo/forgejo/issues/1711
(cherry picked from commit 2e289baea943dcece88f02d110b03d344308a261)
(cherry picked from commit 97b16bc19ae680db62608d6020b00fe5ac451c60)
[MODERATION] User blocking (squash) do not use shared fixture
It conflicts with a fixtured added in the commit
Fix comment permissions (#28213) (#28216)
(cherry picked from commit ab40799dcab24e9f495d765268b791931da81684)
(cherry picked from commit 996c92cafdb5b33a6d2d05d94038e950d97eb7de)
(cherry picked from commit 259912e3a69071c5ad57871464d0b79f69a8e72c)
Conflicts:
options/locale/locale_en-US.ini
https://codeberg.org/forgejo/forgejo/pulls/1921
(cherry picked from commit 1e82abc032c18015b92c93a7617a5dd06d50bd2d)
(cherry picked from commit a176fee1607d571b25b345184f1c50d403029610)
(cherry picked from commit 0480b76dfeda968849e900da9454a3efd82590fa)
(cherry picked from commit 4bc06b7b3841c74e3d790b1ef635c2b382ca7123)
(cherry picked from commit 073094cf722a927a623408d66537c758d7d64e4c)
(cherry picked from commit ac6201c647a4d3a2cfb2b0303b851a8fe7a29444)
(cherry picked from commit 7e0812674da3fbd1e96bdda820962edad6826fbd)
(cherry picked from commit 068c741e5696957710b3d1c2e18c00be2ffaa278)
Conflicts:
models/repo_transfer.go
models/repo_transfer_test.go
routers/web/user/profile.go
https://codeberg.org/forgejo/forgejo/pulls/2298
2023-08-14 23:07:38 +00:00
|
|
|
num_issues: 0
|
2017-02-15 15:24:23 +00:00
|
|
|
num_closed_issues: 0
|
2019-06-30 07:57:59 +00:00
|
|
|
num_pulls: 1
|
2017-02-15 15:24:23 +00:00
|
|
|
num_closed_pulls: 0
|
2021-03-13 18:06:52 +00:00
|
|
|
num_milestones: 1
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2017-02-15 15:24:23 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-02-15 15:24:23 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 11
|
|
|
|
|
owner_id: 13
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user13
|
2017-02-15 15:24:23 +00:00
|
|
|
lower_name: repo11
|
|
|
|
|
name: repo11
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-02-15 15:24:23 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2017-02-15 15:24:23 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 10
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-02-22 13:15:14 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 12
|
|
|
|
|
owner_id: 14
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user14
|
2017-02-22 13:15:14 +00:00
|
|
|
lower_name: test_repo_12
|
|
|
|
|
name: test_repo_12
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-02-22 13:15:14 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-02-22 13:15:14 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-02-22 13:15:14 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 13
|
|
|
|
|
owner_id: 14
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user14
|
2017-02-22 13:15:14 +00:00
|
|
|
lower_name: test_repo_13
|
|
|
|
|
name: test_repo_13
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-02-22 13:15:14 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-02-22 13:15:14 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-02-22 13:15:14 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 14
|
|
|
|
|
owner_id: 14
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user14
|
2017-02-22 13:15:14 +00:00
|
|
|
lower_name: test_repo_14
|
|
|
|
|
name: test_repo_14
|
2019-08-25 17:06:36 +00:00
|
|
|
description: test_description_14
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-02-22 13:15:14 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-02-22 13:15:14 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-07-27 09:23:38 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 15
|
|
|
|
|
owner_id: 2
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user2
|
2017-07-27 09:23:38 +00:00
|
|
|
lower_name: repo15
|
|
|
|
|
name: repo15
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
2022-02-25 21:22:20 +00:00
|
|
|
is_private: true
|
2022-10-17 16:23:27 +00:00
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-09-05 13:45:18 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 16
|
|
|
|
|
owner_id: 2
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user2
|
2017-09-05 13:45:18 +00:00
|
|
|
lower_name: repo16
|
|
|
|
|
name: repo16
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-09-05 13:45:18 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-09-22 10:51:16 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 17
|
|
|
|
|
owner_id: 15
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user15
|
2017-09-22 10:51:16 +00:00
|
|
|
lower_name: big_test_public_1
|
|
|
|
|
name: big_test_public_1
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-09-22 10:51:16 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-09-22 10:51:16 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-09-22 10:51:16 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 18
|
|
|
|
|
owner_id: 15
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user15
|
2017-09-22 10:51:16 +00:00
|
|
|
lower_name: big_test_public_2
|
|
|
|
|
name: big_test_public_2
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-09-22 10:51:16 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-09-22 10:51:16 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-09-22 10:51:16 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 19
|
|
|
|
|
owner_id: 15
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user15
|
2017-09-22 10:51:16 +00:00
|
|
|
lower_name: big_test_private_1
|
|
|
|
|
name: big_test_private_1
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-09-22 10:51:16 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-09-22 10:51:16 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-09-22 10:51:16 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 20
|
|
|
|
|
owner_id: 15
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user15
|
2017-09-22 10:51:16 +00:00
|
|
|
lower_name: big_test_private_2
|
|
|
|
|
name: big_test_private_2
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-09-22 10:51:16 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-09-22 10:51:16 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-09-22 10:51:16 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 21
|
|
|
|
|
owner_id: 16
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user16
|
2017-09-22 10:51:16 +00:00
|
|
|
lower_name: big_test_public_3
|
|
|
|
|
name: big_test_public_3
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-09-22 10:51:16 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-09-22 10:51:16 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-09-22 10:51:16 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 22
|
|
|
|
|
owner_id: 16
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user16
|
2017-09-22 10:51:16 +00:00
|
|
|
lower_name: big_test_private_3
|
|
|
|
|
name: big_test_private_3
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-09-22 10:51:16 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-09-22 10:51:16 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-09-22 10:51:16 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 23
|
|
|
|
|
owner_id: 17
|
2023-09-14 02:59:53 +00:00
|
|
|
owner_name: org17
|
2017-09-22 10:51:16 +00:00
|
|
|
lower_name: big_test_public_4
|
|
|
|
|
name: big_test_public_4
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-09-22 10:51:16 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
2023-09-21 11:59:50 +00:00
|
|
|
num_pulls: 1
|
2017-09-22 10:51:16 +00:00
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-09-22 10:51:16 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-09-22 10:51:16 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 24
|
|
|
|
|
owner_id: 17
|
2023-09-14 02:59:53 +00:00
|
|
|
owner_name: org17
|
2017-09-22 10:51:16 +00:00
|
|
|
lower_name: big_test_private_4
|
|
|
|
|
name: big_test_private_4
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-09-22 10:51:16 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-09-22 10:51:16 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-10-26 21:16:13 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 25
|
|
|
|
|
owner_id: 20
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user20
|
2017-10-26 21:16:13 +00:00
|
|
|
lower_name: big_test_public_mirror_5
|
|
|
|
|
name: big_test_public_mirror_5
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-10-26 21:16:13 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-10-26 21:16:13 +00:00
|
|
|
is_mirror: true
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-10-26 21:16:13 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 26
|
|
|
|
|
owner_id: 20
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user20
|
2017-10-26 21:16:13 +00:00
|
|
|
lower_name: big_test_private_mirror_5
|
|
|
|
|
name: big_test_private_mirror_5
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-10-26 21:16:13 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-10-26 21:16:13 +00:00
|
|
|
is_mirror: true
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-10-26 21:16:13 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 27
|
|
|
|
|
owner_id: 19
|
2023-09-14 02:59:53 +00:00
|
|
|
owner_name: org19
|
2017-10-26 21:16:13 +00:00
|
|
|
lower_name: big_test_public_mirror_6
|
|
|
|
|
name: big_test_public_mirror_6
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 1
|
2017-10-26 21:16:13 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-10-26 21:16:13 +00:00
|
|
|
is_mirror: true
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2017-10-26 21:16:13 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 28
|
|
|
|
|
owner_id: 19
|
2023-09-14 02:59:53 +00:00
|
|
|
owner_name: org19
|
2017-10-26 21:16:13 +00:00
|
|
|
lower_name: big_test_private_mirror_6
|
|
|
|
|
name: big_test_private_mirror_6
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 1
|
2017-10-26 21:16:13 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-10-26 21:16:13 +00:00
|
|
|
is_mirror: true
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2018-06-21 16:00:13 +00:00
|
|
|
|
2017-10-26 21:16:13 +00:00
|
|
|
-
|
|
|
|
|
id: 29
|
|
|
|
|
owner_id: 20
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user20
|
2017-10-26 21:16:13 +00:00
|
|
|
lower_name: big_test_public_fork_7
|
|
|
|
|
name: big_test_public_fork_7
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-10-26 21:16:13 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-10-26 21:16:13 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: true
|
|
|
|
|
fork_id: 27
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2018-06-21 16:00:13 +00:00
|
|
|
|
2017-10-26 21:16:13 +00:00
|
|
|
-
|
|
|
|
|
id: 30
|
|
|
|
|
owner_id: 20
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user20
|
2017-10-26 21:16:13 +00:00
|
|
|
lower_name: big_test_private_fork_7
|
|
|
|
|
name: big_test_private_fork_7
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2017-10-26 21:16:13 +00:00
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2017-10-26 21:16:13 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: true
|
|
|
|
|
fork_id: 28
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2018-05-01 07:04:36 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 31
|
|
|
|
|
owner_id: 2
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user2
|
2018-05-01 07:04:36 +00:00
|
|
|
lower_name: repo20
|
|
|
|
|
name: repo20
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2018-05-01 07:04:36 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2018-05-01 07:04:36 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2018-06-21 16:00:13 +00:00
|
|
|
|
|
|
|
|
-
|
2018-11-28 11:26:14 +00:00
|
|
|
id: 32 # org public repo
|
2018-06-21 16:00:13 +00:00
|
|
|
owner_id: 3
|
2023-09-14 02:59:53 +00:00
|
|
|
owner_name: org3
|
2018-06-21 16:00:13 +00:00
|
|
|
lower_name: repo21
|
|
|
|
|
name: repo21
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2018-06-21 16:00:13 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2022-05-16 09:49:17 +00:00
|
|
|
num_issues: 2
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2018-06-21 16:00:13 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2018-09-07 01:37:02 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 33
|
|
|
|
|
owner_id: 2
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user2
|
2018-09-07 01:37:02 +00:00
|
|
|
lower_name: utf8
|
|
|
|
|
name: utf8
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
2018-09-07 01:37:02 +00:00
|
|
|
is_private: false
|
2022-10-17 16:23:27 +00:00
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2018-09-13 02:33:48 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 34
|
|
|
|
|
owner_id: 21
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user21
|
2018-09-13 02:33:48 +00:00
|
|
|
lower_name: golang
|
|
|
|
|
name: golang
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2018-09-13 02:33:48 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2018-09-13 02:33:48 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2018-09-13 02:33:48 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 35
|
|
|
|
|
owner_id: 21
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user21
|
2018-09-13 02:33:48 +00:00
|
|
|
lower_name: graphql
|
|
|
|
|
name: graphql
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2018-09-13 02:33:48 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2018-09-13 02:33:48 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-04-12 02:28:44 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 36
|
|
|
|
|
owner_id: 2
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user2
|
2019-04-12 02:28:44 +00:00
|
|
|
lower_name: commits_search_test
|
|
|
|
|
name: commits_search_test
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-04-12 02:28:44 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2019-04-12 02:28:44 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-04-17 05:31:08 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 37
|
|
|
|
|
owner_id: 2
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user2
|
2019-04-17 05:31:08 +00:00
|
|
|
lower_name: git_hooks_test
|
|
|
|
|
name: git_hooks_test
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-04-17 05:31:08 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2019-04-17 05:31:08 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-04-25 18:59:10 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 38
|
|
|
|
|
owner_id: 22
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: limited_org
|
2019-04-25 18:59:10 +00:00
|
|
|
lower_name: public_repo_on_limited_org
|
|
|
|
|
name: public_repo_on_limited_org
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-04-25 18:59:10 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2019-04-25 18:59:10 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-04-25 18:59:10 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 39
|
|
|
|
|
owner_id: 22
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: limited_org
|
2019-04-25 18:59:10 +00:00
|
|
|
lower_name: private_repo_on_limited_org
|
|
|
|
|
name: private_repo_on_limited_org
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-04-25 18:59:10 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2019-04-25 18:59:10 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-04-25 18:59:10 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 40
|
|
|
|
|
owner_id: 23
|
2021-10-28 02:54:40 +00:00
|
|
|
owner_name: privated_org
|
2019-04-25 18:59:10 +00:00
|
|
|
lower_name: public_repo_on_private_org
|
|
|
|
|
name: public_repo_on_private_org
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-04-25 18:59:10 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2019-04-25 18:59:10 +00:00
|
|
|
is_mirror: false
|
2019-10-13 13:23:14 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-04-25 18:59:10 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 41
|
|
|
|
|
owner_id: 23
|
2021-10-28 02:54:40 +00:00
|
|
|
owner_name: privated_org
|
2019-04-25 18:59:10 +00:00
|
|
|
lower_name: private_repo_on_private_org
|
|
|
|
|
name: private_repo_on_private_org
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-04-25 18:59:10 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2019-09-11 17:26:28 +00:00
|
|
|
is_mirror: false
|
2022-10-17 16:23:27 +00:00
|
|
|
status: 0
|
|
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-09-11 17:26:28 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 42
|
|
|
|
|
owner_id: 2
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user2
|
2019-09-11 17:26:28 +00:00
|
|
|
lower_name: glob
|
|
|
|
|
name: glob
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-09-11 17:26:28 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2020-01-01 22:51:10 +00:00
|
|
|
num_issues: 1
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
2020-01-01 22:51:10 +00:00
|
|
|
num_milestones: 1
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
2022-06-04 18:30:01 +00:00
|
|
|
is_archived: false
|
2022-10-17 16:23:27 +00:00
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
|
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-09-23 20:08:03 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 43
|
|
|
|
|
owner_id: 26
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: org26
|
2019-09-23 20:08:03 +00:00
|
|
|
lower_name: repo26
|
|
|
|
|
name: repo26
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-09-23 20:08:03 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: true
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2019-10-13 13:23:14 +00:00
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-11-11 15:15:29 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 44
|
|
|
|
|
owner_id: 27
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user27
|
2019-11-11 15:15:29 +00:00
|
|
|
lower_name: template1
|
|
|
|
|
name: template1
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-11-11 15:15:29 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2019-11-11 15:15:29 +00:00
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: true
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-11-11 15:15:29 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 45
|
|
|
|
|
owner_id: 27
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: user27
|
2019-11-11 15:15:29 +00:00
|
|
|
lower_name: template2
|
|
|
|
|
name: template2
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-11-11 15:15:29 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
2019-11-11 15:15:29 +00:00
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: true
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-12-07 04:21:18 +00:00
|
|
|
|
2020-01-01 22:51:10 +00:00
|
|
|
-
|
2019-12-07 04:21:18 +00:00
|
|
|
id: 46
|
|
|
|
|
owner_id: 26
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: org26
|
2019-12-07 04:21:18 +00:00
|
|
|
lower_name: repo_external_tracker
|
|
|
|
|
name: repo_external_tracker
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-12-07 04:21:18 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2019-12-07 04:21:18 +00:00
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-12-07 04:21:18 +00:00
|
|
|
|
2020-01-01 22:51:10 +00:00
|
|
|
-
|
2019-12-07 04:21:18 +00:00
|
|
|
id: 47
|
|
|
|
|
owner_id: 26
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: org26
|
2019-12-07 04:21:18 +00:00
|
|
|
lower_name: repo_external_tracker_numeric
|
|
|
|
|
name: repo_external_tracker_numeric
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-12-07 04:21:18 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2019-12-07 04:21:18 +00:00
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2019-12-07 04:21:18 +00:00
|
|
|
|
2020-01-01 22:51:10 +00:00
|
|
|
-
|
2019-12-07 04:21:18 +00:00
|
|
|
id: 48
|
|
|
|
|
owner_id: 26
|
2020-01-12 09:36:21 +00:00
|
|
|
owner_name: org26
|
2019-12-07 04:21:18 +00:00
|
|
|
lower_name: repo_external_tracker_alpha
|
|
|
|
|
name: repo_external_tracker_alpha
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
2019-12-07 04:21:18 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
2019-12-07 04:21:18 +00:00
|
|
|
num_pulls: 1
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
2019-12-07 04:21:18 +00:00
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
[RFC] Make archival asynchronous (#11296)
* Make archival asynchronous
The prime benefit being sought here is for large archives to not
clog up the rendering process and cause unsightly proxy timeouts.
As a secondary benefit, archive-in-progress is moved out of the
way into a /tmp file so that new archival requests for the same
commit will not get fulfilled based on an archive that isn't yet
finished.
This asynchronous system is fairly primitive; request comes in, we'll
spawn off a new goroutine to handle it, then we'll mark it as done.
Status requests will see if the file exists in the final location,
and report the archival as done when it exists.
Fixes #11265
* Archive links: drop initial delay to three-quarters of a second
Some, or perhaps even most, archives will not take all that long to archive.
The archive process starts as soon as the download button is initially
clicked, so in theory they could be done quite quickly. Drop the initial
delay down to three-quarters of a second to make it more responsive in the
common case of the archive being quickly created.
* archiver: restructure a little bit to facilitate testing
This introduces two sync.Cond pointers to the archiver package. If they're
non-nil when we go to process a request, we'll wait until signalled (at all)
to proceed. The tests will then create the sync.Cond so that it can signal
at-will and sanity-check the state of the queue at different phases.
The author believes that nil-checking these two sync.Cond pointers on every
archive processing will introduce minimal overhead with no impact on
maintainability.
* gofmt nit: no space around binary + operator
* services: archiver: appease golangci-lint, lock queueMutex
Locking/unlocking the queueMutex is allowed, but not required, for
Cond.Signal() and Cond.Broadcast(). The magic at play here is just a little
too much for golangci-lint, as we take the address of queueMutex and this is
mostly used in archiver.go; the variable still gets flagged as unused.
* archiver: tests: fix several timing nits
Once we've signaled a cond var, it may take some small amount of time for
the goroutines released to hit the spot we're wanting them to be at. Give
them an appropriate amount of time.
* archiver: tests: no underscore in var name, ungh
* archiver: tests: Test* is run in a separate context than TestMain
We must setup the mutex/cond variables at the beginning of any test that's
going to use it, or else these will be nil when the test is actually ran.
* archiver: tests: hopefully final tweak
Things got shuffled around such that we carefully build up and release
requests from the queue, so we can validate the state of the queue at each
step. Fix some assertions that no longer hold true as fallout.
* repo: Download: restore some semblance of previous behavior
When archival was made async, the GET endpoint was only useful if a previous
POST had initiated the download. This commit restores the previous behavior,
to an extent; we'll now submit the archive request there and return a
"202 Accepted" to indicate that it's processing if we didn't manage to
complete the request within ~2 seconds of submission.
This lets a client directly GET the archive, and gives them some indication
that they may attempt to GET it again at a later time.
* archiver: tests: simplify a bit further
We don't need to risk failure and use time.ParseDuration to get 2 *
time.Second.
else if isn't really necessary if the conditions are simple enough and lead
to the same result.
* archiver: tests: resolve potential source of flakiness
Increase all timeouts to 10 seconds; these aren't hard-coded sleeps, so
there's no guarantee we'll actually take that long. If we need longer to
not have a false-positive, then so be it.
While here, various assert.{Not,}Equal arguments are flipped around so that
the wording in error output reflects reality, where the expected argument is
second and actual third.
* archiver: setup infrastructure for notifying consumers of completion
This API will *not* allow consumers to subscribe to specific requests being
completed, just *any* request being completed. The caller is responsible for
determining if their request is satisfied and waiting again if needed.
* repo: archive: make GET endpoint synchronous again
If the request isn't complete, this endpoint will now submit the request and
wait for completion using the new API. This may still be susceptible to
timeouts for larger repos, but other endpoints now exist that the web
interface will use to negotiate its way through larger archive processes.
* archiver: tests: amend test to include WaitForCompletion()
This is a trivial one, so go ahead and include it.
* archiver: tests: fix test by calling NewContext()
The mutex is otherwise uninitialized, so we need to ensure that we're
actually initializing it if we plan to test it.
* archiver: tests: integrate new WaitForCompletion a little better
We can use this to wait for archives to come in, rather than spinning and
hoping with a timeout.
* archiver: tests: combine numQueued declaration with next-instruction assignment
* routers: repo: reap unused archiving flag from DownloadStatus()
This had some planned usage before, indicating whether this request
initiated the archival process or not. After several rounds of refactoring,
this use was deemed not necessary for much of anything and got boiled down
to !complete in all cases.
* services: archiver: restructure to use a channel
We now offer two forms of waiting for a request:
- WaitForCompletion: wait for completion with no timeout
- TimedWaitForCompletion: wait for completion with timeout
In both cases, we wait for the given request's cchan to close; in the latter
case, we do so with the caller-provided timeout. This completely removes the
need for busy-wait loops in Download/InitiateDownload, as it's fairly clean
to wait on a channel with timeout.
* services: archiver: use defer to unlock now that we can
This previously carried the lock into the goroutine, but an intermediate
step just added the request to archiveInProgress outside of the new
goroutine and removed the need for the goroutine to start out with it.
* Revert "archiver: tests: combine numQueued declaration with next-instruction assignment"
This reverts commit bcc52140238e16680f2e05e448e9be51372afdf5.
Revert "archiver: tests: integrate new WaitForCompletion a little better"
This reverts commit 9fc8bedb5667d24d3a3c7843dc28a229efffb1e6.
Revert "archiver: tests: fix test by calling NewContext()"
This reverts commit 709c35685eaaf261ebbb7d3420e3376a4ee8e7f2.
Revert "archiver: tests: amend test to include WaitForCompletion()"
This reverts commit 75261f56bc05d1fa8ff7e81dcbc0ccd93fdc9d50.
* archiver: tests: first attempt at WaitForCompletion() tests
* archiver: tests: slight improvement, less busy-loop
Just wait for the requests to complete in order, instead of busy-waiting
with a timeout. This is slightly less fragile.
While here, reverse the arguments of a nearby assert.Equal() so that
expected/actual are correct in any test output.
* archiver: address lint nits
* services: archiver: only close the channel once
* services: archiver: use a struct{} for the wait channel
This makes it obvious that the channel is only being used as a signal,
rather than anything useful being piped through it.
* archiver: tests: fix expectations
Move the close of the channel into doArchive() itself; notably, before these
goroutines move on to waiting on the Release cond.
The tests are adjusted to reflect that we can't WaitForCompletion() after
they've already completed, as WaitForCompletion() doesn't indicate that
they've been released from the queue yet.
* archiver: tests: set cchan to nil for comparison
* archiver: move ctx.Error's back into the route handlers
We shouldn't be setting this in a service, we should just be validating the
request that we were handed.
* services: archiver: use regex to match a hash
This makes sure we don't try and use refName as a hash when it's clearly not
one, e.g. heads/pull/foo.
* routers: repo: remove the weird /archive/status endpoint
We don't need to do this anymore, we can just continue POSTing to the
archive/* endpoint until we're told the download's complete. This avoids a
potential naming conflict, where a ref could start with "status/"
* archiver: tests: bump reasonable timeout to 15s
* archiver: tests: actually release timedReq
* archiver: tests: run through inFlight instead of manually checking
While we're here, add a test for manually re-processing an archive that's
already been complete. Re-open the channel and mark it incomplete, so that
doArchive can just mark it complete again.
* initArchiveLinks: prevent default behavior from clicking
* archiver: alias gitea's context, golang context import pending
* archiver: simplify logic, just reconstruct slices
While the previous logic was perhaps slightly more efficient, the
new variant's readability is much improved.
* archiver: don't block shutdown on waiting for archive
The technique established launches a goroutine to do the wait,
which will close a wait channel upon termination. For the timeout
case, we also send back a value indicating whether the timeout was
hit or not.
The timeouts are expected to be relatively small, but still a multi-
second delay to shutdown due to this could be unfortunate.
* archiver: simplify shutdown logic
We can just grab the shutdown channel from the graceful manager instead of
constructing a channel to halt the caller and/or pass a result back.
* Style issues
* Fix mis-merge
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-11-07 20:27:28 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 49
|
|
|
|
|
owner_id: 27
|
|
|
|
|
owner_name: user27
|
|
|
|
|
lower_name: repo49
|
|
|
|
|
name: repo49
|
2023-08-18 09:21:24 +00:00
|
|
|
description: A wonderful repository with more than just a README.md
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
[RFC] Make archival asynchronous (#11296)
* Make archival asynchronous
The prime benefit being sought here is for large archives to not
clog up the rendering process and cause unsightly proxy timeouts.
As a secondary benefit, archive-in-progress is moved out of the
way into a /tmp file so that new archival requests for the same
commit will not get fulfilled based on an archive that isn't yet
finished.
This asynchronous system is fairly primitive; request comes in, we'll
spawn off a new goroutine to handle it, then we'll mark it as done.
Status requests will see if the file exists in the final location,
and report the archival as done when it exists.
Fixes #11265
* Archive links: drop initial delay to three-quarters of a second
Some, or perhaps even most, archives will not take all that long to archive.
The archive process starts as soon as the download button is initially
clicked, so in theory they could be done quite quickly. Drop the initial
delay down to three-quarters of a second to make it more responsive in the
common case of the archive being quickly created.
* archiver: restructure a little bit to facilitate testing
This introduces two sync.Cond pointers to the archiver package. If they're
non-nil when we go to process a request, we'll wait until signalled (at all)
to proceed. The tests will then create the sync.Cond so that it can signal
at-will and sanity-check the state of the queue at different phases.
The author believes that nil-checking these two sync.Cond pointers on every
archive processing will introduce minimal overhead with no impact on
maintainability.
* gofmt nit: no space around binary + operator
* services: archiver: appease golangci-lint, lock queueMutex
Locking/unlocking the queueMutex is allowed, but not required, for
Cond.Signal() and Cond.Broadcast(). The magic at play here is just a little
too much for golangci-lint, as we take the address of queueMutex and this is
mostly used in archiver.go; the variable still gets flagged as unused.
* archiver: tests: fix several timing nits
Once we've signaled a cond var, it may take some small amount of time for
the goroutines released to hit the spot we're wanting them to be at. Give
them an appropriate amount of time.
* archiver: tests: no underscore in var name, ungh
* archiver: tests: Test* is run in a separate context than TestMain
We must setup the mutex/cond variables at the beginning of any test that's
going to use it, or else these will be nil when the test is actually ran.
* archiver: tests: hopefully final tweak
Things got shuffled around such that we carefully build up and release
requests from the queue, so we can validate the state of the queue at each
step. Fix some assertions that no longer hold true as fallout.
* repo: Download: restore some semblance of previous behavior
When archival was made async, the GET endpoint was only useful if a previous
POST had initiated the download. This commit restores the previous behavior,
to an extent; we'll now submit the archive request there and return a
"202 Accepted" to indicate that it's processing if we didn't manage to
complete the request within ~2 seconds of submission.
This lets a client directly GET the archive, and gives them some indication
that they may attempt to GET it again at a later time.
* archiver: tests: simplify a bit further
We don't need to risk failure and use time.ParseDuration to get 2 *
time.Second.
else if isn't really necessary if the conditions are simple enough and lead
to the same result.
* archiver: tests: resolve potential source of flakiness
Increase all timeouts to 10 seconds; these aren't hard-coded sleeps, so
there's no guarantee we'll actually take that long. If we need longer to
not have a false-positive, then so be it.
While here, various assert.{Not,}Equal arguments are flipped around so that
the wording in error output reflects reality, where the expected argument is
second and actual third.
* archiver: setup infrastructure for notifying consumers of completion
This API will *not* allow consumers to subscribe to specific requests being
completed, just *any* request being completed. The caller is responsible for
determining if their request is satisfied and waiting again if needed.
* repo: archive: make GET endpoint synchronous again
If the request isn't complete, this endpoint will now submit the request and
wait for completion using the new API. This may still be susceptible to
timeouts for larger repos, but other endpoints now exist that the web
interface will use to negotiate its way through larger archive processes.
* archiver: tests: amend test to include WaitForCompletion()
This is a trivial one, so go ahead and include it.
* archiver: tests: fix test by calling NewContext()
The mutex is otherwise uninitialized, so we need to ensure that we're
actually initializing it if we plan to test it.
* archiver: tests: integrate new WaitForCompletion a little better
We can use this to wait for archives to come in, rather than spinning and
hoping with a timeout.
* archiver: tests: combine numQueued declaration with next-instruction assignment
* routers: repo: reap unused archiving flag from DownloadStatus()
This had some planned usage before, indicating whether this request
initiated the archival process or not. After several rounds of refactoring,
this use was deemed not necessary for much of anything and got boiled down
to !complete in all cases.
* services: archiver: restructure to use a channel
We now offer two forms of waiting for a request:
- WaitForCompletion: wait for completion with no timeout
- TimedWaitForCompletion: wait for completion with timeout
In both cases, we wait for the given request's cchan to close; in the latter
case, we do so with the caller-provided timeout. This completely removes the
need for busy-wait loops in Download/InitiateDownload, as it's fairly clean
to wait on a channel with timeout.
* services: archiver: use defer to unlock now that we can
This previously carried the lock into the goroutine, but an intermediate
step just added the request to archiveInProgress outside of the new
goroutine and removed the need for the goroutine to start out with it.
* Revert "archiver: tests: combine numQueued declaration with next-instruction assignment"
This reverts commit bcc52140238e16680f2e05e448e9be51372afdf5.
Revert "archiver: tests: integrate new WaitForCompletion a little better"
This reverts commit 9fc8bedb5667d24d3a3c7843dc28a229efffb1e6.
Revert "archiver: tests: fix test by calling NewContext()"
This reverts commit 709c35685eaaf261ebbb7d3420e3376a4ee8e7f2.
Revert "archiver: tests: amend test to include WaitForCompletion()"
This reverts commit 75261f56bc05d1fa8ff7e81dcbc0ccd93fdc9d50.
* archiver: tests: first attempt at WaitForCompletion() tests
* archiver: tests: slight improvement, less busy-loop
Just wait for the requests to complete in order, instead of busy-waiting
with a timeout. This is slightly less fragile.
While here, reverse the arguments of a nearby assert.Equal() so that
expected/actual are correct in any test output.
* archiver: address lint nits
* services: archiver: only close the channel once
* services: archiver: use a struct{} for the wait channel
This makes it obvious that the channel is only being used as a signal,
rather than anything useful being piped through it.
* archiver: tests: fix expectations
Move the close of the channel into doArchive() itself; notably, before these
goroutines move on to waiting on the Release cond.
The tests are adjusted to reflect that we can't WaitForCompletion() after
they've already completed, as WaitForCompletion() doesn't indicate that
they've been released from the queue yet.
* archiver: tests: set cchan to nil for comparison
* archiver: move ctx.Error's back into the route handlers
We shouldn't be setting this in a service, we should just be validating the
request that we were handed.
* services: archiver: use regex to match a hash
This makes sure we don't try and use refName as a hash when it's clearly not
one, e.g. heads/pull/foo.
* routers: repo: remove the weird /archive/status endpoint
We don't need to do this anymore, we can just continue POSTing to the
archive/* endpoint until we're told the download's complete. This avoids a
potential naming conflict, where a ref could start with "status/"
* archiver: tests: bump reasonable timeout to 15s
* archiver: tests: actually release timedReq
* archiver: tests: run through inFlight instead of manually checking
While we're here, add a test for manually re-processing an archive that's
already been complete. Re-open the channel and mark it incomplete, so that
doArchive can just mark it complete again.
* initArchiveLinks: prevent default behavior from clicking
* archiver: alias gitea's context, golang context import pending
* archiver: simplify logic, just reconstruct slices
While the previous logic was perhaps slightly more efficient, the
new variant's readability is much improved.
* archiver: don't block shutdown on waiting for archive
The technique established launches a goroutine to do the wait,
which will close a wait channel upon termination. For the timeout
case, we also send back a value indicating whether the timeout was
hit or not.
The timeouts are expected to be relatively small, but still a multi-
second delay to shutdown due to this could be unfortunate.
* archiver: simplify shutdown logic
We can just grab the shutdown channel from the graceful manager instead of
constructing a channel to halt the caller and/or pass a result back.
* Style issues
* Fix mis-merge
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-11-07 20:27:28 +00:00
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
[RFC] Make archival asynchronous (#11296)
* Make archival asynchronous
The prime benefit being sought here is for large archives to not
clog up the rendering process and cause unsightly proxy timeouts.
As a secondary benefit, archive-in-progress is moved out of the
way into a /tmp file so that new archival requests for the same
commit will not get fulfilled based on an archive that isn't yet
finished.
This asynchronous system is fairly primitive; request comes in, we'll
spawn off a new goroutine to handle it, then we'll mark it as done.
Status requests will see if the file exists in the final location,
and report the archival as done when it exists.
Fixes #11265
* Archive links: drop initial delay to three-quarters of a second
Some, or perhaps even most, archives will not take all that long to archive.
The archive process starts as soon as the download button is initially
clicked, so in theory they could be done quite quickly. Drop the initial
delay down to three-quarters of a second to make it more responsive in the
common case of the archive being quickly created.
* archiver: restructure a little bit to facilitate testing
This introduces two sync.Cond pointers to the archiver package. If they're
non-nil when we go to process a request, we'll wait until signalled (at all)
to proceed. The tests will then create the sync.Cond so that it can signal
at-will and sanity-check the state of the queue at different phases.
The author believes that nil-checking these two sync.Cond pointers on every
archive processing will introduce minimal overhead with no impact on
maintainability.
* gofmt nit: no space around binary + operator
* services: archiver: appease golangci-lint, lock queueMutex
Locking/unlocking the queueMutex is allowed, but not required, for
Cond.Signal() and Cond.Broadcast(). The magic at play here is just a little
too much for golangci-lint, as we take the address of queueMutex and this is
mostly used in archiver.go; the variable still gets flagged as unused.
* archiver: tests: fix several timing nits
Once we've signaled a cond var, it may take some small amount of time for
the goroutines released to hit the spot we're wanting them to be at. Give
them an appropriate amount of time.
* archiver: tests: no underscore in var name, ungh
* archiver: tests: Test* is run in a separate context than TestMain
We must setup the mutex/cond variables at the beginning of any test that's
going to use it, or else these will be nil when the test is actually ran.
* archiver: tests: hopefully final tweak
Things got shuffled around such that we carefully build up and release
requests from the queue, so we can validate the state of the queue at each
step. Fix some assertions that no longer hold true as fallout.
* repo: Download: restore some semblance of previous behavior
When archival was made async, the GET endpoint was only useful if a previous
POST had initiated the download. This commit restores the previous behavior,
to an extent; we'll now submit the archive request there and return a
"202 Accepted" to indicate that it's processing if we didn't manage to
complete the request within ~2 seconds of submission.
This lets a client directly GET the archive, and gives them some indication
that they may attempt to GET it again at a later time.
* archiver: tests: simplify a bit further
We don't need to risk failure and use time.ParseDuration to get 2 *
time.Second.
else if isn't really necessary if the conditions are simple enough and lead
to the same result.
* archiver: tests: resolve potential source of flakiness
Increase all timeouts to 10 seconds; these aren't hard-coded sleeps, so
there's no guarantee we'll actually take that long. If we need longer to
not have a false-positive, then so be it.
While here, various assert.{Not,}Equal arguments are flipped around so that
the wording in error output reflects reality, where the expected argument is
second and actual third.
* archiver: setup infrastructure for notifying consumers of completion
This API will *not* allow consumers to subscribe to specific requests being
completed, just *any* request being completed. The caller is responsible for
determining if their request is satisfied and waiting again if needed.
* repo: archive: make GET endpoint synchronous again
If the request isn't complete, this endpoint will now submit the request and
wait for completion using the new API. This may still be susceptible to
timeouts for larger repos, but other endpoints now exist that the web
interface will use to negotiate its way through larger archive processes.
* archiver: tests: amend test to include WaitForCompletion()
This is a trivial one, so go ahead and include it.
* archiver: tests: fix test by calling NewContext()
The mutex is otherwise uninitialized, so we need to ensure that we're
actually initializing it if we plan to test it.
* archiver: tests: integrate new WaitForCompletion a little better
We can use this to wait for archives to come in, rather than spinning and
hoping with a timeout.
* archiver: tests: combine numQueued declaration with next-instruction assignment
* routers: repo: reap unused archiving flag from DownloadStatus()
This had some planned usage before, indicating whether this request
initiated the archival process or not. After several rounds of refactoring,
this use was deemed not necessary for much of anything and got boiled down
to !complete in all cases.
* services: archiver: restructure to use a channel
We now offer two forms of waiting for a request:
- WaitForCompletion: wait for completion with no timeout
- TimedWaitForCompletion: wait for completion with timeout
In both cases, we wait for the given request's cchan to close; in the latter
case, we do so with the caller-provided timeout. This completely removes the
need for busy-wait loops in Download/InitiateDownload, as it's fairly clean
to wait on a channel with timeout.
* services: archiver: use defer to unlock now that we can
This previously carried the lock into the goroutine, but an intermediate
step just added the request to archiveInProgress outside of the new
goroutine and removed the need for the goroutine to start out with it.
* Revert "archiver: tests: combine numQueued declaration with next-instruction assignment"
This reverts commit bcc52140238e16680f2e05e448e9be51372afdf5.
Revert "archiver: tests: integrate new WaitForCompletion a little better"
This reverts commit 9fc8bedb5667d24d3a3c7843dc28a229efffb1e6.
Revert "archiver: tests: fix test by calling NewContext()"
This reverts commit 709c35685eaaf261ebbb7d3420e3376a4ee8e7f2.
Revert "archiver: tests: amend test to include WaitForCompletion()"
This reverts commit 75261f56bc05d1fa8ff7e81dcbc0ccd93fdc9d50.
* archiver: tests: first attempt at WaitForCompletion() tests
* archiver: tests: slight improvement, less busy-loop
Just wait for the requests to complete in order, instead of busy-waiting
with a timeout. This is slightly less fragile.
While here, reverse the arguments of a nearby assert.Equal() so that
expected/actual are correct in any test output.
* archiver: address lint nits
* services: archiver: only close the channel once
* services: archiver: use a struct{} for the wait channel
This makes it obvious that the channel is only being used as a signal,
rather than anything useful being piped through it.
* archiver: tests: fix expectations
Move the close of the channel into doArchive() itself; notably, before these
goroutines move on to waiting on the Release cond.
The tests are adjusted to reflect that we can't WaitForCompletion() after
they've already completed, as WaitForCompletion() doesn't indicate that
they've been released from the queue yet.
* archiver: tests: set cchan to nil for comparison
* archiver: move ctx.Error's back into the route handlers
We shouldn't be setting this in a service, we should just be validating the
request that we were handed.
* services: archiver: use regex to match a hash
This makes sure we don't try and use refName as a hash when it's clearly not
one, e.g. heads/pull/foo.
* routers: repo: remove the weird /archive/status endpoint
We don't need to do this anymore, we can just continue POSTing to the
archive/* endpoint until we're told the download's complete. This avoids a
potential naming conflict, where a ref could start with "status/"
* archiver: tests: bump reasonable timeout to 15s
* archiver: tests: actually release timedReq
* archiver: tests: run through inFlight instead of manually checking
While we're here, add a test for manually re-processing an archive that's
already been complete. Re-open the channel and mark it incomplete, so that
doArchive can just mark it complete again.
* initArchiveLinks: prevent default behavior from clicking
* archiver: alias gitea's context, golang context import pending
* archiver: simplify logic, just reconstruct slices
While the previous logic was perhaps slightly more efficient, the
new variant's readability is much improved.
* archiver: don't block shutdown on waiting for archive
The technique established launches a goroutine to do the wait,
which will close a wait channel upon termination. For the timeout
case, we also send back a value indicating whether the timeout was
hit or not.
The timeouts are expected to be relatively small, but still a multi-
second delay to shutdown due to this could be unfortunate.
* archiver: simplify shutdown logic
We can just grab the shutdown channel from the graceful manager instead of
constructing a channel to halt the caller and/or pass a result back.
* Style issues
* Fix mis-merge
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-11-07 20:27:28 +00:00
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2021-01-13 04:19:17 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 50
|
|
|
|
|
owner_id: 30
|
|
|
|
|
owner_name: user30
|
|
|
|
|
lower_name: repo50
|
|
|
|
|
name: repo50
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2021-01-13 04:19:17 +00:00
|
|
|
num_issues: 1
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
2021-01-13 04:19:17 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2021-01-13 04:19:17 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 51
|
|
|
|
|
owner_id: 30
|
|
|
|
|
owner_name: user30
|
|
|
|
|
lower_name: repo51
|
|
|
|
|
name: repo51
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
2021-01-13 04:19:17 +00:00
|
|
|
num_issues: 1
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: true
|
|
|
|
|
is_mirror: false
|
2021-03-13 18:06:52 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2022-02-26 06:15:25 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 52
|
|
|
|
|
owner_id: 30
|
|
|
|
|
owner_name: user30
|
|
|
|
|
lower_name: empty
|
|
|
|
|
name: empty
|
2023-04-19 13:40:42 +00:00
|
|
|
default_branch: master
|
2022-10-17 16:23:27 +00:00
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
2022-02-26 06:15:25 +00:00
|
|
|
is_private: true
|
2022-10-17 16:23:27 +00:00
|
|
|
is_empty: true
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
2022-02-26 06:15:25 +00:00
|
|
|
status: 0
|
2022-10-17 16:23:27 +00:00
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2022-12-12 12:45:21 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 53
|
|
|
|
|
owner_id: 30
|
|
|
|
|
owner_name: user30
|
|
|
|
|
lower_name: renderer
|
|
|
|
|
name: renderer
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-12-12 12:45:21 +00:00
|
|
|
is_archived: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_private: false
|
|
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 0
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_watches: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
status: 0
|
|
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2022-12-22 23:41:56 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 54
|
|
|
|
|
owner_id: 2
|
|
|
|
|
owner_name: user2
|
|
|
|
|
lower_name: lfs
|
|
|
|
|
name: lfs
|
Do not overwrite empty DefaultBranch (#22708)
Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)
I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 20:48:48 +00:00
|
|
|
default_branch: master
|
2022-12-22 23:41:56 +00:00
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_private: true
|
|
|
|
|
status: 0
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-18 19:17:39 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 55
|
|
|
|
|
owner_id: 2
|
|
|
|
|
owner_name: user2
|
|
|
|
|
lower_name: scoped_label
|
|
|
|
|
name: scoped_label
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_private: true
|
|
|
|
|
num_issues: 1
|
|
|
|
|
status: 0
|
2023-03-09 01:24:23 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 56
|
|
|
|
|
owner_id: 2
|
|
|
|
|
owner_name: user2
|
|
|
|
|
lower_name: readme-test
|
|
|
|
|
name: readme-test
|
|
|
|
|
default_branch: master
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_private: true
|
|
|
|
|
status: 0
|
|
|
|
|
num_issues: 0
|
2023-04-18 19:11:17 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 57
|
|
|
|
|
owner_id: 2
|
|
|
|
|
owner_name: user2
|
|
|
|
|
lower_name: repo-release
|
|
|
|
|
name: repo-release
|
|
|
|
|
default_branch: main
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_private: false
|
|
|
|
|
status: 0
|
|
|
|
|
num_issues: 0
|
2023-07-28 19:18:12 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 58 # org public repo
|
|
|
|
|
owner_id: 2
|
|
|
|
|
owner_name: user2
|
|
|
|
|
lower_name: commitsonpr
|
|
|
|
|
name: commitsonpr
|
|
|
|
|
default_branch: main
|
|
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 1
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
|
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
2024-01-16 15:06:51 +00:00
|
|
|
|
2023-08-18 09:21:24 +00:00
|
|
|
-
|
|
|
|
|
id: 1059
|
|
|
|
|
owner_id: 2
|
|
|
|
|
owner_name: user2
|
|
|
|
|
lower_name: repo59
|
|
|
|
|
name: repo59
|
|
|
|
|
default_branch: master
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_private: false
|
|
|
|
|
status: 0
|
|
|
|
|
num_issues: 0
|
|
|
|
|
|
2024-01-16 15:06:51 +00:00
|
|
|
-
|
|
|
|
|
id: 59
|
|
|
|
|
owner_id: 2
|
|
|
|
|
owner_name: user2
|
|
|
|
|
lower_name: test_commit_revert
|
|
|
|
|
name: test_commit_revert
|
|
|
|
|
default_branch: main
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_private: true
|
|
|
|
|
status: 0
|
|
|
|
|
num_issues: 0
|
2024-02-24 12:38:43 +00:00
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 60
|
|
|
|
|
owner_id: 40
|
|
|
|
|
owner_name: user40
|
|
|
|
|
lower_name: repo60
|
|
|
|
|
name: repo60
|
|
|
|
|
default_branch: main
|
|
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 1
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
|
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|
|
|
|
|
|
|
|
|
|
-
|
|
|
|
|
id: 61
|
|
|
|
|
owner_id: 41
|
|
|
|
|
owner_name: org41
|
|
|
|
|
lower_name: repo61
|
|
|
|
|
name: repo61
|
|
|
|
|
default_branch: main
|
|
|
|
|
num_watches: 0
|
|
|
|
|
num_stars: 0
|
|
|
|
|
num_forks: 0
|
|
|
|
|
num_issues: 0
|
|
|
|
|
num_closed_issues: 0
|
|
|
|
|
num_pulls: 1
|
|
|
|
|
num_closed_pulls: 0
|
|
|
|
|
num_milestones: 0
|
|
|
|
|
num_closed_milestones: 0
|
|
|
|
|
num_projects: 0
|
|
|
|
|
num_closed_projects: 0
|
|
|
|
|
is_private: false
|
|
|
|
|
is_empty: false
|
|
|
|
|
is_archived: false
|
|
|
|
|
is_mirror: false
|
|
|
|
|
status: 0
|
|
|
|
|
is_fork: false
|
|
|
|
|
fork_id: 0
|
|
|
|
|
is_template: false
|
|
|
|
|
template_id: 0
|
|
|
|
|
size: 0
|
|
|
|
|
is_fsck_enabled: true
|
|
|
|
|
close_issues_via_commit_in_any_branch: false
|