Nulo/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

modules/log: remove noop written variables (#10182)

Browse source 
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
This commit is contained in:
Lars Lehtonen 2020-02-07 12:35:30 -08:00 committed by GitHub
parent 11789aebb0
commit 0754ceca5b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/log/conn_test.go
View file

@ -27,8 +27,6 @@ func listenReadAndClose(t *testing.T, l net.Listener, expected string) {
} }
func TestConnLogger(t *testing.T) { func TestConnLogger(t *testing.T) {
var written []byte
protocol := "tcp" protocol := "tcp"
address := ":3099" address := ":3099"
@ -79,8 +77,6 @@ func TestConnLogger(t *testing.T) {
}() }()
wg.Wait() wg.Wait()
written = written[:0]
event.level = WARN event.level = WARN
expected = fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg) expected = fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg)
wg.Add(2) wg.Add(2)
@ -156,8 +152,6 @@ func TestConnLoggerFailConnect(t *testing.T) {
} }
func TestConnLoggerClose(t *testing.T) { func TestConnLoggerClose(t *testing.T) {
var written []byte
protocol := "tcp" protocol := "tcp"
address := ":3099" address := ":3099"
@ -217,8 +211,6 @@ func TestConnLoggerClose(t *testing.T) {
assert.Equal(t, level, connLogger.Level) assert.Equal(t, level, connLogger.Level)
assert.Equal(t, level, logger.GetLevel()) assert.Equal(t, level, logger.GetLevel())
written = written[:0]
event.level = WARN event.level = WARN
expected = fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg) expected = fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg)
wg.Add(2) wg.Add(2)