Nulo/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove unnecessary loading of settings in update hook (#9496)

Browse source 
This PR simply makes update an empty command rather than needlessly load the settings for each reference.
This commit is contained in:
zeripath 2019-12-27 15:21:33 +00:00 committed by GitHub
parent 3d5f31f77d
commit 154424623a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
cmd/hook.go
View file

@ -181,18 +181,7 @@ Gitea or set your environment appropriately.`, "")
}
func runHookUpdate(c *cli.Context) error {
if len(os.Getenv("SSH_ORIGINAL_COMMAND")) == 0 {
if setting.OnlyAllowPushIfGiteaEnvironmentSet {
fail(`Rejecting changes as Gitea environment not set.
If you are pushing over SSH you must push with a key managed by
Gitea or set your environment appropriately.`, "")
} else {
return nil
}
}
setup("hooks/update.log", false)
// Update is empty and is kept only for backwards compatibility
return nil
}