From 1aa7e27dd052860b8e0bbe9b457adc13e0b4a743 Mon Sep 17 00:00:00 2001 From: David Svantesson Date: Mon, 2 Dec 2019 19:32:40 +0100 Subject: [PATCH] Change review content column to type text in db (#9229) --- models/migrations/migrations.go | 2 ++ models/migrations/v110.go | 36 +++++++++++++++++++++++++++++++++ models/review.go | 2 +- 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 models/migrations/v110.go diff --git a/models/migrations/migrations.go b/models/migrations/migrations.go index df82fe9b8b..2de32f8e78 100644 --- a/models/migrations/migrations.go +++ b/models/migrations/migrations.go @@ -274,6 +274,8 @@ var migrations = []Migration{ NewMigration("Add comment_id on table notification", addCommentIDOnNotification), // v109 -> v110 NewMigration("add can_create_org_repo to team", addCanCreateOrgRepoColumnForTeam), + // v110 -> v111 + NewMigration("change review content type to text", changeReviewContentToText), } // Migrate database to current version diff --git a/models/migrations/v110.go b/models/migrations/v110.go new file mode 100644 index 0000000000..dc46c2ef77 --- /dev/null +++ b/models/migrations/v110.go @@ -0,0 +1,36 @@ +// Copyright 2019 The Gitea Authors. All rights reserved. +// Use of this source code is governed by a MIT-style +// license that can be found in the LICENSE file. + +package migrations + +import ( + "xorm.io/core" + "xorm.io/xorm" +) + +func changeReviewContentToText(x *xorm.Engine) error { + + if x.Dialect().DBType() == core.MYSQL { + _, err := x.Exec("ALTER TABLE review MODIFY COLUMN content TEXT") + return err + } + + if x.Dialect().DBType() == core.ORACLE { + _, err := x.Exec("ALTER TABLE review MODIFY content TEXT") + return err + } + + if x.Dialect().DBType() == core.MSSQL { + _, err := x.Exec("ALTER TABLE review ALTER COLUMN content TEXT") + return err + } + + if x.Dialect().DBType() == core.POSTGRES { + _, err := x.Exec("ALTER TABLE review ALTER COLUMN content TYPE TEXT") + return err + } + + // SQLite doesn't support ALTER COLUMN, and it seem to already make String to _TEXT_ default so no migration needed + return nil +} diff --git a/models/review.go b/models/review.go index 715aaeb43a..62781bc0f6 100644 --- a/models/review.go +++ b/models/review.go @@ -52,7 +52,7 @@ type Review struct { ReviewerID int64 `xorm:"index"` Issue *Issue `xorm:"-"` IssueID int64 `xorm:"index"` - Content string + Content string `xorm:"TEXT"` CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"` UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`