Nulo/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix environments for KaTeX and error reporting (#22453)

Browse source 
In #22447 it was noticed that display environments were not working
correctly. This was due to the setting displayMode not being set.

Further it was noticed that the error was not being displayed correctly.

This PR fixes both of these issues by forcibly setting the displayMode
setting and corrects an error in displayError.

Fix #22447

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
zeripath 2023-01-16 10:25:46 +00:00 committed by GitHub
parent 2782c14396
commit 1e7f3c16a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
web_src/js/markup/math.js
View file

@ -1,6 +1,6 @@
function displayError(el, err) { function displayError(el, err) {
const target = targetElement(el); const target = targetElement(el);
target.remove('is-loading'); target.classList.remove('is-loading');
const errorNode = document.createElement('div'); const errorNode = document.createElement('div');
errorNode.setAttribute('class', 'ui message error markup-block-error mono'); errorNode.setAttribute('class', 'ui message error markup-block-error mono');
errorNode.textContent = err.str || err.message || String(err); errorNode.textContent = err.str || err.message || String(err);
@ -23,13 +23,15 @@ export async function renderMath() {
for (const el of els) { for (const el of els) {
const source = el.textContent; const source = el.textContent;
const nodeName = el.classList.contains('display') ? 'p' : 'span'; const displayMode = el.classList.contains('display');
const nodeName = displayMode ? 'p' : 'span';
try { try {
const tempEl = document.createElement(nodeName); const tempEl = document.createElement(nodeName);
katex.render(source, tempEl, { katex.render(source, tempEl, {
maxSize: 25, maxSize: 25,
maxExpand: 50, maxExpand: 50,
displayMode,
}); });
targetElement(el).replaceWith(tempEl); targetElement(el).replaceWith(tempEl);
} catch (error) { } catch (error) {