Fix migrate release from github (#19510)

* Fix migrate release from github

* Fix bug
This commit is contained in:
Lunny Xiao 2022-04-27 07:24:06 +08:00 committed by GitHub
parent 41fcf7b7de
commit 2728f0c213
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -7,6 +7,7 @@ package migrations
import ( import (
"context" "context"
"errors"
"fmt" "fmt"
"io" "io"
"os" "os"
@ -253,7 +254,6 @@ func (g *GiteaLocalUploader) CreateReleases(releases ...*base.Release) error {
LowerTagName: strings.ToLower(release.TagName), LowerTagName: strings.ToLower(release.TagName),
Target: release.TargetCommitish, Target: release.TargetCommitish,
Title: release.Name, Title: release.Name,
Sha1: release.TargetCommitish,
Note: release.Body, Note: release.Body,
IsDraft: release.Draft, IsDraft: release.Draft,
IsPrerelease: release.Prerelease, IsPrerelease: release.Prerelease,
@ -265,17 +265,20 @@ func (g *GiteaLocalUploader) CreateReleases(releases ...*base.Release) error {
return err return err
} }
// calc NumCommits if no draft // calc NumCommits if possible
if !release.Draft { if rel.TagName != "" {
commit, err := g.gitRepo.GetTagCommit(rel.TagName) commit, err := g.gitRepo.GetTagCommit(rel.TagName)
if !errors.Is(err, git.ErrNotExist{}) {
if err != nil { if err != nil {
return fmt.Errorf("GetTagCommit[%v]: %v", rel.TagName, err) return fmt.Errorf("GetTagCommit[%v]: %v", rel.TagName, err)
} }
rel.Sha1 = commit.ID.String()
rel.NumCommits, err = commit.CommitsCount() rel.NumCommits, err = commit.CommitsCount()
if err != nil { if err != nil {
return fmt.Errorf("CommitsCount: %v", err) return fmt.Errorf("CommitsCount: %v", err)
} }
} }
}
for _, asset := range release.Assets { for _, asset := range release.Assets {
if asset.Created.IsZero() { if asset.Created.IsZero() {