From 27beed74b550959c08f12697917861bec23978cd Mon Sep 17 00:00:00 2001 From: silverwind Date: Sat, 9 Mar 2024 18:37:29 +0100 Subject: [PATCH] Suppress error from monaco-editor (#29684) Fixes: https://github.com/go-gitea/gitea/issues/29414 I see no way for us to catch this error, so downgrade it until https://github.com/microsoft/monaco-editor/issues/4325 is fixed, which will likely take a few weeks to propagate up from vscode. The entries in `updates.config.js` will make [`updates`](https://github.com/silverwind/updates) not upgrade these anymore and I think it's good documentation as well to have the reasons why we don't upgrade these dependencies. (cherry picked from commit 9bf693d98ddf8efa058a5fbbb6a3da5e0c12ab27) --- web_src/js/bootstrap.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/web_src/js/bootstrap.js b/web_src/js/bootstrap.js index c0047b0ac2..698d17fa36 100644 --- a/web_src/js/bootstrap.js +++ b/web_src/js/bootstrap.js @@ -6,10 +6,18 @@ // This file must be imported before any lazy-loading is being attempted. __webpack_public_path__ = `${window.config?.assetUrlPrefix ?? '/assets'}/`; +const filteredErrors = new Set([ + 'getModifierState is not a function', // https://github.com/microsoft/monaco-editor/issues/4325 +]); + export function showGlobalErrorMessage(msg) { const pageContent = document.querySelector('.page-content'); if (!pageContent) return; + for (const filteredError of filteredErrors) { + if (msg.includes(filteredError)) return; + } + // compact the message to a data attribute to avoid too many duplicated messages const msgCompact = msg.replace(/\W/g, '').trim(); let msgDiv = pageContent.querySelector(`.js-global-error[data-global-error-msg-compact="${msgCompact}"]`);