From a8ce03660fb6e14effcdb12974d925c99a4c2348 Mon Sep 17 00:00:00 2001
From: Gusted <postmaster@gusted.xyz>
Date: Fri, 5 Jan 2024 20:00:13 +0100
Subject: [PATCH] [GITEA] Make reference URL absolute

- Backport of #2100
- Make the reference URL in the "Reference in New issue" feature
absolute again as it wouldn't render as a link otherwise.
- Adds integration test.
- Regression by 769be877f2ce572b94b7c0a85853a2f7836075ac
- Resolves #2012

(cherry picked from commit c74bae28973092eeeaf2fb9a17cbe41d286648db)
---
 .../repo/issue/view_content/context_menu.tmpl |  4 +--
 tests/integration/issue_test.go               | 28 +++++++++++++++++++
 2 files changed, 30 insertions(+), 2 deletions(-)

diff --git a/templates/repo/issue/view_content/context_menu.tmpl b/templates/repo/issue/view_content/context_menu.tmpl
index 4afd73c371..a6afe8e07c 100644
--- a/templates/repo/issue/view_content/context_menu.tmpl
+++ b/templates/repo/issue/view_content/context_menu.tmpl
@@ -5,9 +5,9 @@
 	<div class="menu">
 		{{$referenceUrl := ""}}
 		{{if .issue}}
-			{{$referenceUrl = printf "%s#%s" .ctxData.Issue.Link .item.HashTag}}
+			{{$referenceUrl = printf "%s#%s" .ctxData.Issue.HTMLURL .item.HashTag}}
 		{{else}}
-			{{$referenceUrl = printf "%s/files#%s" .ctxData.Issue.Link .item.HashTag}}
+			{{$referenceUrl = printf "%s/files#%s" .ctxData.Issue.HTMLURL .item.HashTag}}
 		{{end}}
 		<div class="item context js-aria-clickable" data-clipboard-text-type="url" data-clipboard-text="{{$referenceUrl}}">{{ctx.Locale.Tr "repo.issues.context.copy_link"}}</div>
 		{{if and .ctxData.IsSigned (not .ctxData.Repository.IsArchived)}}
diff --git a/tests/integration/issue_test.go b/tests/integration/issue_test.go
index 39eaf3ba1b..5be57ee413 100644
--- a/tests/integration/issue_test.go
+++ b/tests/integration/issue_test.go
@@ -699,3 +699,31 @@ func TestIssuePinMove(t *testing.T) {
 	issue = unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: issue.ID})
 	assert.EqualValues(t, newPosition, issue.PinOrder)
 }
+
+func TestAbsoluteReferenceURL(t *testing.T) {
+	defer tests.PrepareTestEnv(t)()
+	session := loginUser(t, "user2")
+
+	issue1 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
+	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issue1.RepoID})
+
+	req := NewRequest(t, "GET", fmt.Sprintf("%s/issues/%d", repo.FullName(), issue1.Index))
+	resp := session.MakeRequest(t, req, http.StatusOK)
+	htmlDoc := NewHTMLParser(t, resp.Body)
+
+	t.Run("Issue", func(t *testing.T) {
+		defer tests.PrintCurrentTest(t)()
+
+		referenceURL, ok := htmlDoc.Find(".reference-issue").Attr("data-reference")
+		assert.True(t, ok)
+		assert.EqualValues(t, setting.AppURL+"user2/repo1/issues/1#issue-1", referenceURL)
+	})
+
+	t.Run("Comment", func(t *testing.T) {
+		defer tests.PrintCurrentTest(t)()
+
+		referenceURL, ok := htmlDoc.Find(`[id^="issuecomment"] .reference-issue`).Attr("data-reference")
+		assert.True(t, ok)
+		assert.EqualValues(t, setting.AppURL+"user2/repo1/issues/1#issuecomment-2", referenceURL)
+	})
+}