From 321909de7eac1384ff2905e6134ccaef1c2d0abc Mon Sep 17 00:00:00 2001 From: Giteabot Date: Wed, 19 Jul 2023 19:05:22 -0400 Subject: [PATCH] avoid hard-coding height in language dropdown menu (#25986) (#25997) Backport #25986 by @earl-warren This commit removes the hard-coded height of 500px, using that as a max-height instead. The height of items in the dropdown menu, assuming a default font size of 16px, is 36px, so the old CSS would cause overly large dropdown menus in instances where less than 14 languages are offered. Refs: https://codeberg.org/forgejo/forgejo/pulls/1000 Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com> Co-authored-by: rome-user (cherry picked from commit 28e8c691a6e021e755e33c066c26edf36bf08125) --- web_src/css/home.css | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/web_src/css/home.css b/web_src/css/home.css index a5c042a2b1..22f1a2dc98 100644 --- a/web_src/css/home.css +++ b/web_src/css/home.css @@ -74,8 +74,7 @@ } .page-footer .ui.dropdown.language .menu { - height: 500px; - max-height: calc(100vh - 60px); + max-height: min(500px, calc(100vh - 60px)); overflow-y: auto; margin-bottom: 10px; }