Nulo/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove the parallelizing when loading repo for dashboard (#24705)

Browse source 
Ref: #24638

IMO, parallelizing might run out server resources more quickly. Gitea
shouldn't use a lot of go-routine in a web handler.

And add a comment about how many repositories there could be at most.

Co-authored-by: Yarden Shoham <git@yardenshoham.com>
This commit is contained in:
wxiaoguang 2023-05-14 21:45:47 +08:00 committed by GitHub
parent 116f8e12a7
commit 3af2c8e4ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
routers/web/repo/repo.go
View file

@ -9,7 +9,6 @@ import (
"fmt" "fmt"
"net/http" "net/http"
"strings" "strings"
"sync"
"code.gitea.io/gitea/models" "code.gitea.io/gitea/models"
"code.gitea.io/gitea/models/db" "code.gitea.io/gitea/models/db"
@ -579,20 +578,15 @@ func SearchRepo(ctx *context.Context) {
} }
// collect the latest commit of each repo // collect the latest commit of each repo
repoIDsToLatestCommitSHAs := make(map[int64]string) // at most there are dozens of repos (limited by MaxResponseItems), so it's not a big problem at the moment
wg := sync.WaitGroup{} repoIDsToLatestCommitSHAs := make(map[int64]string, len(repos))
wg.Add(len(repos))
for _, repo := range repos { for _, repo := range repos {
go func(repo *repo_model.Repository) {
defer wg.Done()
commitID, err := repo_service.GetBranchCommitID(ctx, repo, repo.DefaultBranch) commitID, err := repo_service.GetBranchCommitID(ctx, repo, repo.DefaultBranch)
if err != nil { if err != nil {
return continue
} }
repoIDsToLatestCommitSHAs[repo.ID] = commitID repoIDsToLatestCommitSHAs[repo.ID] = commitID
}(repo)
} }
wg.Wait()
// call the database O(1) times to get the commit statuses for all repos // call the database O(1) times to get the commit statuses for all repos
repoToItsLatestCommitStatuses, err := git_model.GetLatestCommitStatusForPairs(ctx, repoIDsToLatestCommitSHAs, db.ListOptions{}) repoToItsLatestCommitStatuses, err := git_model.GetLatestCommitStatusForPairs(ctx, repoIDsToLatestCommitSHAs, db.ListOptions{})