Fix lint errors (#2547)

This commit is contained in:
Ethan Koenig 2017-09-19 01:08:30 -07:00 committed by Lauris BH
parent d155d0e665
commit 4cb9394a97
9 changed files with 9 additions and 41 deletions

View file

@ -282,11 +282,7 @@ func DeleteGPGKey(doer *User, id int64) (err error) {
return err return err
} }
if err = sess.Commit(); err != nil { return sess.Commit()
return err
}
return nil
} }
// CommitVerification represents a commit validation of signature // CommitVerification represents a commit validation of signature

View file

@ -571,11 +571,7 @@ func (issue *Issue) ReadBy(userID int64) error {
return err return err
} }
if err := setNotificationStatusReadIfUnread(x, userID, issue.ID); err != nil { return setNotificationStatusReadIfUnread(x, userID, issue.ID)
return err
}
return nil
} }
func updateIssueCols(e Engine, issue *Issue, cols ...string) error { func updateIssueCols(e Engine, issue *Issue, cols ...string) error {

View file

@ -498,10 +498,7 @@ func SMTPAuth(a smtp.Auth, cfg *SMTPConfig) error {
} }
if ok, _ := c.Extension("AUTH"); ok { if ok, _ := c.Extension("AUTH"); ok {
if err = c.Auth(a); err != nil { return c.Auth(a)
return err
}
return nil
} }
return ErrUnsupportedLoginType return ErrUnsupportedLoginType
} }

View file

@ -119,9 +119,5 @@ func addUnitsToTables(x *xorm.Engine) error {
} }
} }
if err := sess.Commit(); err != nil { return sess.Commit()
return err
}
return nil
} }

View file

@ -51,8 +51,5 @@ func useNewPublickeyFormat(x *xorm.Engine) error {
} }
f.Close() f.Close()
if err = os.Rename(tmpPath, fpath); err != nil { return os.Rename(tmpPath, fpath)
return err
}
return nil
} }

View file

@ -235,11 +235,7 @@ func DeleteOrganization(org *User) (err error) {
} }
} }
if err = sess.Commit(); err != nil { return sess.Commit()
return err
}
return nil
} }
func deleteOrg(e *xorm.Session, u *User) error { func deleteOrg(e *xorm.Session, u *User) error {

View file

@ -599,11 +599,7 @@ func RewriteAllPublicKeys() error {
defer f.Close() defer f.Close()
} }
if err = os.Rename(tmpPath, fPath); err != nil { return os.Rename(tmpPath, fPath)
return err
}
return nil
} }
// ________ .__ ____ __. // ________ .__ ____ __.

View file

@ -70,10 +70,7 @@ func (s *ContentStore) Put(meta *models.LFSMetaObject, r io.Reader) error {
return errHashMismatch return errHashMismatch
} }
if err := os.Rename(tmpPath, path); err != nil { return os.Rename(tmpPath, path)
return err
}
return nil
} }
// Exists returns true if the object exists in the content store. // Exists returns true if the object exists in the content store.

View file

@ -110,10 +110,7 @@ func (w *FileLogWriter) StartLogger() error {
return err return err
} }
w.mw.SetFd(fd) w.mw.SetFd(fd)
if err = w.initFd(); err != nil { return w.initFd()
return err
}
return nil
} }
func (w *FileLogWriter) docheck(size int) { func (w *FileLogWriter) docheck(size int) {