Nulo/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add missing test case and fix typo in tests (#24915)

Browse source 
This PR adds a missing assertion in the `TestGetOrgUsersByOrgID`
function. It also incidentally fixes a small typo.
This commit is contained in:
Philip Peterson 2023-05-24 15:06:04 -04:00 committed by GitHub
parent 2250ddd112
commit 63d5e762d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
models/organization/org_test.go
View file

@ -265,6 +265,12 @@ func TestGetOrgUsersByOrgID(t *testing.T) {
UID: 4, UID: 4,
IsPublic: false, IsPublic: false,
}, *orgUsers[1]) }, *orgUsers[1])
assert.Equal(t, organization.OrgUser{
ID: orgUsers[2].ID,
OrgID: 3,
UID: 28,
IsPublic: true,
}, *orgUsers[2])
} }
orgUsers, err = organization.GetOrgUsersByOrgID(db.DefaultContext, &organization.FindOrgMembersOpts{ orgUsers, err = organization.GetOrgUsersByOrgID(db.DefaultContext, &organization.FindOrgMembersOpts{

4
models/organization/org_user_test.go
View file

@ -85,7 +85,7 @@ func TestUserListIsPublicMember(t *testing.T) {
{22, map[int64]bool{}}, {22, map[int64]bool{}},
} }
for _, v := range tt { for _, v := range tt {
t.Run(fmt.Sprintf("IsPublicMemberOfOrdIg%d", v.orgid), func(t *testing.T) { t.Run(fmt.Sprintf("IsPublicMemberOfOrgId%d", v.orgid), func(t *testing.T) {
testUserListIsPublicMember(t, v.orgid, v.expected) testUserListIsPublicMember(t, v.orgid, v.expected)
}) })
} }
@ -112,7 +112,7 @@ func TestUserListIsUserOrgOwner(t *testing.T) {
{22, map[int64]bool{}}, // No member {22, map[int64]bool{}}, // No member
} }
for _, v := range tt { for _, v := range tt {
t.Run(fmt.Sprintf("IsUserOrgOwnerOfOrdIg%d", v.orgid), func(t *testing.T) { t.Run(fmt.Sprintf("IsUserOrgOwnerOfOrgId%d", v.orgid), func(t *testing.T) {
testUserListIsUserOrgOwner(t, v.orgid, v.expected) testUserListIsUserOrgOwner(t, v.orgid, v.expected)
}) })
} }