From 7679f4d51a637ae47880e09dbb185651cb7163c7 Mon Sep 17 00:00:00 2001 From: Giteabot Date: Thu, 8 Jun 2023 12:03:42 -0400 Subject: [PATCH] Fix open redirect check for more cases (#25143) (#25154) Backport #25143 by @lafriks If redirect_to parameter has set value starting with `\\example.com` redirect will be created with header `Location: /\\example.com` that will redirect to example.com domain. Co-authored-by: Lauris BH --- modules/context/context_response.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/context/context_response.go b/modules/context/context_response.go index aeeb51ba37..1f215eb8ad 100644 --- a/modules/context/context_response.go +++ b/modules/context/context_response.go @@ -49,9 +49,9 @@ func (ctx *Context) RedirectToFirst(location ...string) { continue } - // Unfortunately browsers consider a redirect Location with preceding "//" and "/\" as meaning redirect to "http(s)://REST_OF_PATH" + // Unfortunately browsers consider a redirect Location with preceding "//", "\\" and "/\" as meaning redirect to "http(s)://REST_OF_PATH" // Therefore we should ignore these redirect locations to prevent open redirects - if len(loc) > 1 && loc[0] == '/' && (loc[1] == '/' || loc[1] == '\\') { + if len(loc) > 1 && (loc[0] == '/' || loc[0] == '\\') && (loc[1] == '/' || loc[1] == '\\') { continue }