Add missing triggers to update issue indexer (#26539)
Fix #26536 Follow #26012 Whatever the comment type is, always update the issue indexer. So the issue indexer will be updated when there is a change in Status, Assignee, Label, and so on. I added the logic for `NotifyUpdateComment`, but missed it for `NotifyCreateIssueComment` and `NotifyDeleteComment`.
This commit is contained in:
parent
82f6e3d845
commit
7e75e58ae4
|
@ -36,18 +36,7 @@ func (r *indexerNotifier) NotifyAdoptRepository(ctx context.Context, doer, u *us
|
||||||
func (r *indexerNotifier) NotifyCreateIssueComment(ctx context.Context, doer *user_model.User, repo *repo_model.Repository,
|
func (r *indexerNotifier) NotifyCreateIssueComment(ctx context.Context, doer *user_model.User, repo *repo_model.Repository,
|
||||||
issue *issues_model.Issue, comment *issues_model.Comment, mentions []*user_model.User,
|
issue *issues_model.Issue, comment *issues_model.Comment, mentions []*user_model.User,
|
||||||
) {
|
) {
|
||||||
if comment.Type == issues_model.CommentTypeComment {
|
issue_indexer.UpdateIssueIndexer(issue.ID)
|
||||||
if issue.Comments == nil {
|
|
||||||
if err := issue.LoadDiscussComments(ctx); err != nil {
|
|
||||||
log.Error("LoadDiscussComments failed: %v", err)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
issue.Comments = append(issue.Comments, comment)
|
|
||||||
}
|
|
||||||
|
|
||||||
issue_indexer.UpdateIssueIndexer(issue.ID)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func (r *indexerNotifier) NotifyNewIssue(ctx context.Context, issue *issues_model.Issue, mentions []*user_model.User) {
|
func (r *indexerNotifier) NotifyNewIssue(ctx context.Context, issue *issues_model.Issue, mentions []*user_model.User) {
|
||||||
|
@ -55,42 +44,27 @@ func (r *indexerNotifier) NotifyNewIssue(ctx context.Context, issue *issues_mode
|
||||||
}
|
}
|
||||||
|
|
||||||
func (r *indexerNotifier) NotifyNewPullRequest(ctx context.Context, pr *issues_model.PullRequest, mentions []*user_model.User) {
|
func (r *indexerNotifier) NotifyNewPullRequest(ctx context.Context, pr *issues_model.PullRequest, mentions []*user_model.User) {
|
||||||
|
if err := pr.LoadIssue(ctx); err != nil {
|
||||||
|
log.Error("LoadIssue: %v", err)
|
||||||
|
return
|
||||||
|
}
|
||||||
issue_indexer.UpdateIssueIndexer(pr.Issue.ID)
|
issue_indexer.UpdateIssueIndexer(pr.Issue.ID)
|
||||||
}
|
}
|
||||||
|
|
||||||
func (r *indexerNotifier) NotifyUpdateComment(ctx context.Context, doer *user_model.User, c *issues_model.Comment, oldContent string) {
|
func (r *indexerNotifier) NotifyUpdateComment(ctx context.Context, doer *user_model.User, c *issues_model.Comment, oldContent string) {
|
||||||
// Whatever the comment type is, just update the issue indexer.
|
if err := c.LoadIssue(ctx); err != nil {
|
||||||
// So that the issue indexer will be updated when Status/Assignee/Label and so on changed.
|
log.Error("LoadIssue: %v", err)
|
||||||
|
return
|
||||||
|
}
|
||||||
issue_indexer.UpdateIssueIndexer(c.Issue.ID)
|
issue_indexer.UpdateIssueIndexer(c.Issue.ID)
|
||||||
}
|
}
|
||||||
|
|
||||||
func (r *indexerNotifier) NotifyDeleteComment(ctx context.Context, doer *user_model.User, comment *issues_model.Comment) {
|
func (r *indexerNotifier) NotifyDeleteComment(ctx context.Context, doer *user_model.User, comment *issues_model.Comment) {
|
||||||
if comment.Type == issues_model.CommentTypeComment {
|
if err := comment.LoadIssue(ctx); err != nil {
|
||||||
if err := comment.LoadIssue(ctx); err != nil {
|
log.Error("LoadIssue: %v", err)
|
||||||
log.Error("LoadIssue: %v", err)
|
return
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
var found bool
|
|
||||||
if comment.Issue.Comments != nil {
|
|
||||||
for i := 0; i < len(comment.Issue.Comments); i++ {
|
|
||||||
if comment.Issue.Comments[i].ID == comment.ID {
|
|
||||||
comment.Issue.Comments = append(comment.Issue.Comments[:i], comment.Issue.Comments[i+1:]...)
|
|
||||||
found = true
|
|
||||||
break
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if !found {
|
|
||||||
if err := comment.Issue.LoadDiscussComments(ctx); err != nil {
|
|
||||||
log.Error("LoadDiscussComments failed: %v", err)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
}
|
|
||||||
// reload comments to delete the old comment
|
|
||||||
issue_indexer.UpdateIssueIndexer(comment.Issue.ID)
|
|
||||||
}
|
}
|
||||||
|
issue_indexer.UpdateIssueIndexer(comment.Issue.ID)
|
||||||
}
|
}
|
||||||
|
|
||||||
func (r *indexerNotifier) NotifyDeleteRepository(ctx context.Context, doer *user_model.User, repo *repo_model.Repository) {
|
func (r *indexerNotifier) NotifyDeleteRepository(ctx context.Context, doer *user_model.User, repo *repo_model.Repository) {
|
||||||
|
|
Loading…
Reference in a new issue