Nulo/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add Index to comment.dependent_issue_id (#27325) (#27340)

Browse source 
Backport #27325 by @JakobDev

This Column is missing index. It is used by
[issue_service.deleteIssue](7ea2a910ce/services/issue/issue.go (L300)).

Co-authored-by: JakobDev <jakobdev@gmx.de>
This commit is contained in:
Giteabot 2023-09-29 10:00:14 +08:00 committed by GitHub
parent c61b9c5f3c
commit 7ea7f2b37f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
models/issues/comment.go
View file

@ -246,7 +246,7 @@ type Comment struct {
NewTitle string
OldRef string
NewRef string
DependentIssueID int64
DependentIssueID int64 `xorm:"index"` // This is used by issue_service.deleteIssue
DependentIssue *Issue `xorm:"-"`
CommitID int64

2
models/migrations/migrations.go
View file

@ -536,6 +536,8 @@ var migrations = []Migration{
NewMigration("Add RemoteAddress to mirrors", v1_21.AddRemoteAddressToMirrors),
// v277 -> v278
NewMigration("Add Index to issue_user.issue_id", v1_21.AddIndexToIssueUserIssueID),
// v278 -> v279
NewMigration("Add Index to comment.dependent_issue_id", v1_21.AddIndexToCommentDependentIssueID),
}
// GetCurrentDBVersion returns the current db version

16
models/migrations/v1_21/v278.go Normal file
View file

@ -0,0 +1,16 @@
// Copyright 2023 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package v1_21 //nolint
import (
"xorm.io/xorm"
)
func AddIndexToCommentDependentIssueID(x *xorm.Engine) error {
type Comment struct {
DependentIssueID int64 `xorm:"index"`
}
return x.Sync(new(Comment))
}