Nulo/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix #1271: Call location.reload after XHR finishes (#2071)

Browse source 
location.reload was being called when the related dropdown
was hidden, even if a request initiated before to update this
value hadn't finished. This caused troubles on Firefox.
This commit is contained in:
Guillermo Bonvehí 2017-06-28 05:55:28 -03:00 committed by Lunny Xiao
parent 6b13dafe61
commit 858197b453
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
public/js/index.js
View file

@ -189,12 +189,6 @@ function initCommentForm() {
var $list = $('.ui' + select_id + '.list'); var $list = $('.ui' + select_id + '.list');
var hasUpdateAction = $menu.data('action') == 'update'; var hasUpdateAction = $menu.data('action') == 'update';
$(select_id).dropdown('setting', 'onHide', function(){
if (hasUpdateAction) {
location.reload();
}
});
$menu.find('.item:not(.no-select)').click(function () { $menu.find('.item:not(.no-select)').click(function () {
$(this).parent().find('.item').each(function () { $(this).parent().find('.item').each(function () {
$(this).removeClass('selected active') $(this).removeClass('selected active')
@ -206,7 +200,8 @@ function initCommentForm() {
$menu.data('update-url'), $menu.data('update-url'),
"", "",
$menu.data('issue-id'), $menu.data('issue-id'),
$(this).data('id') $(this).data('id'),
function() { location.reload(); }
); );
} }
switch (input_id) { switch (input_id) {
@ -232,7 +227,8 @@ function initCommentForm() {
$menu.data('update-url'), $menu.data('update-url'),
"", "",
$menu.data('issue-id'), $menu.data('issue-id'),
$(this).data('id') $(this).data('id'),
function() { location.reload(); }
); );
} }