From 8babbe7ccf4e6b73aa8b67dc88c470c516f0b6cc Mon Sep 17 00:00:00 2001 From: Giteabot Date: Thu, 29 Feb 2024 06:13:49 +0800 Subject: [PATCH] Fix counter display number incorrectly displayed on the page (#29448) (#29478) Backport #29448 by @charles7668 issue : #28239 The counter number script uses the 'checkbox' attribute to determine whether an item is selected or not. However, the input event only increments the counter value, and when more items are displayed, it does not update all previously loaded items. As a result, the display becomes incorrect because it triggers the update counter script, but checkboxes that are selected without the 'checked' attribute are not counted Co-authored-by: charles <30816317+charles7668@users.noreply.github.com> (cherry picked from commit 5477728282de19b1638691b88449b1933ed5a4d8) --- web_src/js/features/pull-view-file.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/web_src/js/features/pull-view-file.js b/web_src/js/features/pull-view-file.js index 86b65f68cf..f68c8887bb 100644 --- a/web_src/js/features/pull-view-file.js +++ b/web_src/js/features/pull-view-file.js @@ -44,9 +44,11 @@ export function initViewedCheckboxListenerFor() { // Mark the file as viewed visually - will especially change the background if (this.checked) { form.classList.add(viewedStyleClass); + checkbox.setAttribute('checked', ''); prReview.numberOfViewedFiles++; } else { form.classList.remove(viewedStyleClass); + checkbox.removeAttribute('checked'); prReview.numberOfViewedFiles--; }