Nulo/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix system config cache expiration timing (#28072) (#28090)

Browse source 
Backport #28072

To avoid unnecessary database access, the `cacheTime` should always be
set if the revision has been checked.

Fix #28057

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Giteabot 2023-11-16 21:37:57 +08:00 committed by GitHub
parent 073d8c50dd
commit 9f63d27ec4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
models/system/setting.go
View file

@ -115,24 +115,26 @@ func (d *dbConfigCachedGetter) GetValue(ctx context.Context, key string) (v stri
func (d *dbConfigCachedGetter) GetRevision(ctx context.Context) int { func (d *dbConfigCachedGetter) GetRevision(ctx context.Context) int {
d.mu.RLock() d.mu.RLock()
defer d.mu.RUnlock() cachedDuration := time.Since(d.cacheTime)
if time.Since(d.cacheTime) < time.Second { cachedRevision := d.revision
return d.revision
}
if GetRevision(ctx) != d.revision {
d.mu.RUnlock() d.mu.RUnlock()
if cachedDuration < time.Second {
return cachedRevision
}
d.mu.Lock() d.mu.Lock()
defer d.mu.Unlock()
if GetRevision(ctx) != d.revision {
rev, set, err := GetAllSettings(ctx) rev, set, err := GetAllSettings(ctx)
if err != nil { if err != nil {
log.Error("Unable to get all settings: %v", err) log.Error("Unable to get all settings: %v", err)
} else { } else {
d.cacheTime = time.Now()
d.revision = rev d.revision = rev
d.settings = set d.settings = set
} }
d.mu.Unlock()
d.mu.RLock()
} }
d.cacheTime = time.Now()
return d.revision return d.revision
} }