From a6f5efa0bb7bab30b6acd654c5ccf1c273c8b60c Mon Sep 17 00:00:00 2001 From: Ethan Koenig Date: Fri, 13 Jan 2017 21:21:30 -0500 Subject: [PATCH] Fix ambiguity bug in getCommentsByRepoIDSince (#665) --- models/issue_comment.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/models/issue_comment.go b/models/issue_comment.go index 73c9db1cdb..e9a401b864 100644 --- a/models/issue_comment.go +++ b/models/issue_comment.go @@ -420,9 +420,11 @@ func getCommentsByIssueIDSince(e Engine, issueID, since int64) ([]*Comment, erro func getCommentsByRepoIDSince(e Engine, repoID, since int64) ([]*Comment, error) { comments := make([]*Comment, 0, 10) - sess := e.Where("issue.repo_id = ?", repoID).Join("INNER", "issue", "issue.id = comment.issue_id", repoID).Asc("created_unix") + sess := e.Where("issue.repo_id = ?", repoID). + Join("INNER", "issue", "issue.id = comment.issue_id"). + Asc("comment.created_unix") if since > 0 { - sess.And("updated_unix >= ?", since) + sess.And("comment.updated_unix >= ?", since) } return comments, sess.Find(&comments) }