Nulo/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix checkbox field markup (#30666)

Browse source 
Fixes https://github.com/go-gitea/gitea/issues/30664.

Previous use was not a supported way by fomantic and the misuse only
became visible after the checkbox migration.

(cherry picked from commit 1a2ae64b16f10b8d1e17197d18b9eb373faf58db)
This commit is contained in:
silverwind 2024-04-23 23:53:57 +02:00 committed by 0ko
parent 9d1ffeaf8d
commit b917571d81
2 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
templates/user/settings/applications_oauth2_edit_form.tmpl
View file

@ -41,9 +41,11 @@
<label for="redirect-uris">{{ctx.Locale.Tr "settings.oauth2_redirect_uris"}}</label> <label for="redirect-uris">{{ctx.Locale.Tr "settings.oauth2_redirect_uris"}}</label>
<textarea name="redirect_uris" id="redirect-uris" required>{{StringUtils.Join .App.RedirectURIs "\n"}}</textarea> <textarea name="redirect_uris" id="redirect-uris" required>{{StringUtils.Join .App.RedirectURIs "\n"}}</textarea>
</div> </div>
<div class="field ui checkbox {{if .Err_ConfidentialClient}}error{{end}}"> <div class="field {{if .Err_ConfidentialClient}}error{{end}}">
<label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label> <div class="ui checkbox">
<input type="checkbox" name="confidential_client" {{if .App.ConfidentialClient}}checked{{end}}> <label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label>
<input type="checkbox" name="confidential_client" {{if .App.ConfidentialClient}}checked{{end}}>
</div>
</div> </div>
<button class="ui primary button"> <button class="ui primary button">
{{ctx.Locale.Tr "settings.save_application"}} {{ctx.Locale.Tr "settings.save_application"}}

8
templates/user/settings/applications_oauth2_list.tmpl
View file

@ -61,9 +61,11 @@
<label for="redirect-uris">{{ctx.Locale.Tr "settings.oauth2_redirect_uris"}}</label> <label for="redirect-uris">{{ctx.Locale.Tr "settings.oauth2_redirect_uris"}}</label>
<textarea name="redirect_uris" id="redirect-uris"></textarea> <textarea name="redirect_uris" id="redirect-uris"></textarea>
</div> </div>
<div class="field ui checkbox {{if .Err_ConfidentialClient}}error{{end}}"> <div class="field {{if .Err_ConfidentialClient}}error{{end}}">
<label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label> <div class="ui checkbox">
<input type="checkbox" name="confidential_client" checked> <label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label>
<input type="checkbox" name="confidential_client" checked>
</div>
</div> </div>
<button class="ui primary button"> <button class="ui primary button">
{{ctx.Locale.Tr "settings.create_oauth2_application_button"}} {{ctx.Locale.Tr "settings.create_oauth2_application_button"}}