Fix footer display (#24251) (#24269)

Backport #24251

Fix #24249

Diff with ignoring spaces:
https://github.com/go-gitea/gitea/pull/24269/files?diff=split&w=1


Manually tested


![image](https://user-images.githubusercontent.com/2114189/233766806-18eb18ad-0c4d-44f7-b0fc-b40466c64445.png)

Co-authored-by: Lauris BH <lauris@nix.lv>
This commit is contained in:
wxiaoguang 2023-04-22 16:21:56 +08:00 committed by GitHub
parent 5ccb626cda
commit da4448421e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 59 additions and 69 deletions

View file

@ -1,36 +1,34 @@
<footer role="group" aria-label="{{.locale.Tr "aria.footer"}}"> <footer role="group" aria-label="{{.locale.Tr "aria.footer"}}">
<div class="ui container"> <div class="ui left" role="contentinfo" aria-label="{{.locale.Tr "aria.footer.software"}}">
<div class="ui left" role="contentinfo" aria-label="{{.locale.Tr "aria.footer.software"}}"> <a target="_blank" rel="noopener noreferrer" href="https://gitea.io">{{.locale.Tr "powered_by" "Gitea"}}</a>
<a target="_blank" rel="noopener noreferrer" href="https://gitea.io">{{.locale.Tr "powered_by" "Gitea"}}</a> {{if (or .ShowFooterVersion .PageIsAdmin)}}
{{if (or .ShowFooterVersion .PageIsAdmin)}} {{.locale.Tr "version"}}:
{{.locale.Tr "version"}}: {{if .IsAdmin}}
{{if .IsAdmin}} <a href="{{AppSubUrl}}/admin/config">{{AppVer}}</a>
<a href="{{AppSubUrl}}/admin/config">{{AppVer}}</a> {{else}}
{{else}} {{AppVer}}
{{AppVer}}
{{end}}
{{end}}
{{if and .TemplateLoadTimes ShowFooterTemplateLoadTime}}
{{.locale.Tr "page"}}: <strong>{{LoadTimes .PageStartTime}}</strong>
{{.locale.Tr "template"}}{{if .TemplateName}} {{.TemplateName}}{{end}}: <strong>{{call .TemplateLoadTimes}}</strong>
{{end}}
</div>
<div class="ui right links" role="group" aria-label="{{.locale.Tr "aria.footer.links"}}">
{{if .ShowFooterBranding}}
<a target="_blank" rel="noopener noreferrer" href="https://github.com/go-gitea/gitea">{{svg "octicon-mark-github"}}<span class="sr-only">GitHub</span></a>
{{end}} {{end}}
{{end}}
{{if and .TemplateLoadTimes ShowFooterTemplateLoadTime}}
{{.locale.Tr "page"}}: <strong>{{LoadTimes .PageStartTime}}</strong>
{{.locale.Tr "template"}}{{if .TemplateName}} {{.TemplateName}}{{end}}: <strong>{{call .TemplateLoadTimes}}</strong>
{{end}}
</div>
<div class="ui right links" role="group" aria-label="{{.locale.Tr "aria.footer.links"}}">
{{if .ShowFooterBranding}}
<a target="_blank" rel="noopener noreferrer" href="https://github.com/go-gitea/gitea">{{svg "octicon-mark-github"}}<span class="sr-only">GitHub</span></a>
{{end}}
<div class="ui language bottom floating slide up dropdown link item"> <div class="ui language bottom floating slide up dropdown link item">
{{svg "octicon-globe"}} {{svg "octicon-globe"}}
<span>{{.locale.LangName}}</span> <span>{{.locale.LangName}}</span>
<div class="menu language-menu"> <div class="menu language-menu">
{{range .AllLangs}} {{range .AllLangs}}
<a lang="{{.Lang}}" data-url="{{AppSubUrl}}/?lang={{.Lang}}" class="item {{if eq $.locale.Lang .Lang}}active selected{{end}}">{{.Name}}</a> <a lang="{{.Lang}}" data-url="{{AppSubUrl}}/?lang={{.Lang}}" class="item {{if eq $.locale.Lang .Lang}}active selected{{end}}">{{.Name}}</a>
{{end}} {{end}}
</div>
</div> </div>
<a href="{{AssetUrlPrefix}}/js/licenses.txt">{{.locale.Tr "licenses"}}</a>
{{if .EnableSwagger}}<a href="{{AppSubUrl}}/api/swagger">API</a>{{end}}
{{template "custom/extra_links_footer" .}}
</div> </div>
<a href="{{AssetUrlPrefix}}/js/licenses.txt">{{.locale.Tr "licenses"}}</a>
{{if .EnableSwagger}}<a href="{{AppSubUrl}}/api/swagger">API</a>{{end}}
{{template "custom/extra_links_footer" .}}
</div> </div>
</footer> </footer>

View file

@ -1821,46 +1821,6 @@ img.ui.avatar,
color: var(--color-warning-text); color: var(--color-warning-text);
} }
footer {
background-color: var(--color-footer);
border-top: 1px solid var(--color-secondary);
width: 100%;
flex-basis: 40px;
color: var(--color-text-light);
}
footer .container {
padding: 0 0.5rem;
max-width: 100%;
}
footer .container .links > * {
border-left: 1px solid var(--color-secondary-dark-1);
padding-left: 8px;
margin-left: 5px;
}
footer .container .links > *:first-child {
border-left: 0;
}
footer .ui.language .menu {
max-height: 500px;
overflow-y: auto;
margin-bottom: 7px;
}
footer .ui.language .svg {
margin-right: 0.15em;
vertical-align: top;
margin-top: calc(2em - 16px);
}
footer .ui.left,
footer .ui.right {
line-height: 39px; /* there is a border-top on the footer, so make the line-height 1px less */
}
.center:not(.popup) { .center:not(.popup) {
text-align: center; text-align: center;
} }

View file

@ -43,9 +43,41 @@
color: var(--color-green); color: var(--color-green);
} }
footer {
background-color: var(--color-footer);
border-top: 1px solid var(--color-secondary);
line-height: 39px;
flex-basis: 40px;
color: var(--color-text-light);
padding: 0 20px;
}
footer .right.links {
min-width: 180px; /* make sure the menu dropdown doesn't overflow horizontally when language name is short */
}
footer .right.links > * {
border-left: 1px solid var(--color-secondary-dark-1);
padding-left: 8px;
margin-left: 5px;
}
footer .right.links > *:first-child {
border-left: none;
}
footer .ui.dropdown.language .menu {
height: 500px;
max-height: calc(100vh - 60px);
overflow-y: auto;
margin-bottom: 10px;
}
@media (max-width: 880px) { @media (max-width: 880px) {
footer .ui.container .left, footer .ui.left,
footer .ui.container .right { footer .ui.right {
width: 100%;
display: block; display: block;
text-align: center; text-align: center;
float: none; float: none;