Nulo/forgejo
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix successful return value for SyncAndGetUserSpecificDiff (#27152) (#27156)

Browse source 
Backport #27152 by @delvh

A function should not return an error when it is successful.
Otherwise, things like
https://discord.com/channels/322538954119184384/322538954119184384/1153705341620600833
happen…

Co-authored-by: delvh <dev.lh@web.de>
(cherry picked from commit 25233a9bdcfd8d74c803be7712bdaed72eb41455)
This commit is contained in:
Giteabot 2023-09-21 06:58:13 +08:00 committed by Earl Warren
parent 99a93025d2
commit dc6020645b
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/gitdiff/gitdiff.go
View file

@ -1312,7 +1312,7 @@ outer:
}
}
return diff, err
return diff, nil
}
// CommentAsDiff returns c.Patch as *Diff