From ec6b255c2c2968f9bb36f9f47f735385ae7bf00f Mon Sep 17 00:00:00 2001 From: Earl Warren Date: Thu, 11 Apr 2024 07:36:59 +0200 Subject: [PATCH] [TESTS] disable test failure on log.Error for now (part 2) Fixes: https://codeberg.org/forgejo/forgejo/issues/3153 (cherry picked from commit fd62033b98ea40db0285309892ba61ae49abb85d) --- models/migrations/base/tests.go | 3 +-- tests/e2e/e2e_test.go | 3 +-- tests/integration/integration_test.go | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/models/migrations/base/tests.go b/models/migrations/base/tests.go index 0726211ea8..0989902a65 100644 --- a/models/migrations/base/tests.go +++ b/models/migrations/base/tests.go @@ -161,8 +161,7 @@ func MainTest(m *testing.M) { exitStatus := m.Run() if err := testlogger.WriterCloser.Reset(); err != nil && exitStatus == 0 { - fmt.Printf("testlogger.WriterCloser.Reset: %v\n", err) - os.Exit(1) + fmt.Printf("testlogger.WriterCloser.Reset: error ignored: %v\n", err) } if err := removeAllWithRetry(setting.RepoRootPath); err != nil { fmt.Fprintf(os.Stderr, "os.RemoveAll: %v\n", err) diff --git a/tests/e2e/e2e_test.go b/tests/e2e/e2e_test.go index 304dac0f45..92c90f52e6 100644 --- a/tests/e2e/e2e_test.go +++ b/tests/e2e/e2e_test.go @@ -60,8 +60,7 @@ func TestMain(m *testing.M) { exitVal := m.Run() if err := testlogger.WriterCloser.Reset(); err != nil { - fmt.Printf("testlogger.WriterCloser.Reset: %v\n", err) - os.Exit(1) + fmt.Printf("testlogger.WriterCloser.Reset: error ignored: %v\n", err) } if err = util.RemoveAll(setting.Indexer.IssuePath); err != nil { fmt.Printf("util.RemoveAll: %v\n", err) diff --git a/tests/integration/integration_test.go b/tests/integration/integration_test.go index e147d6a21b..8fd55d7fa8 100644 --- a/tests/integration/integration_test.go +++ b/tests/integration/integration_test.go @@ -184,8 +184,7 @@ func TestMain(m *testing.M) { exitCode := m.Run() if err := testlogger.WriterCloser.Reset(); err != nil { - fmt.Printf("testlogger.WriterCloser.Reset: %v\n", err) - os.Exit(1) + fmt.Printf("testlogger.WriterCloser.Reset: error ignored: %v\n", err) } if err = util.RemoveAll(setting.Indexer.IssuePath); err != nil {