From fc002860d8fee23ce6fe018e81c449398d9c51c0 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Mon, 25 Apr 2022 15:04:42 +0800 Subject: [PATCH] Simplify the code to get issue count (#19380) * Simple the code to get issue count * Improve codes --- models/issue.go | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/models/issue.go b/models/issue.go index b1fa2d02ad..68582b2b14 100644 --- a/models/issue.go +++ b/models/issue.go @@ -1510,20 +1510,10 @@ func Issues(opts *IssuesOptions) ([]*Issue, error) { func CountIssues(opts *IssuesOptions) (int64, error) { e := db.GetEngine(db.DefaultContext) - countsSlice := make([]*struct { - Count int64 - }, 0, 1) - sess := e.Select("COUNT(issue.id) AS count").Table("issue") sess.Join("INNER", "repository", "`issue`.repo_id = `repository`.id") opts.setupSessionNoLimit(sess) - if err := sess.Find(&countsSlice); err != nil { - return 0, fmt.Errorf("unable to CountIssues: %w", err) - } - if len(countsSlice) != 1 { - return 0, fmt.Errorf("unable to get one row result when CountIssues, row count=%d", len(countsSlice)) - } - return countsSlice[0].Count, nil + return sess.Count() } // GetParticipantsIDsByIssueID returns the IDs of all users who participated in comments of an issue,