Don't post process commit summary in templates (#6842)
* Don't post process commit summary in templates Don't run summary through render/post process to avoid it generating links and breaking certain views where the summary is already expected to be a link to the commit. For consistancy, disable processing of summary in all locations. Fixes #6809 * Do process title on diff page On second thought, the title is often the only place a pull request number will exists so do process it on the individual diff page. This fixes the list view and still gives easy access to the PR link
This commit is contained in:
parent
9148e45ed7
commit
00b883880d
2 changed files with 3 additions and 3 deletions
|
@ -68,7 +68,7 @@
|
|||
</a>
|
||||
</td>
|
||||
<td class="message collapsing">
|
||||
<span class="has-emoji{{if gt .ParentCount 1}} grey text{{end}}">{{RenderCommitMessage .Summary $.RepoLink $.Repository.ComposeMetas}}</span>
|
||||
<span class="has-emoji{{if gt .ParentCount 1}} grey text{{end}}">{{.Summary}}</span>
|
||||
{{if IsMultilineCommitMessage .Message}}
|
||||
<button class="basic compact mini ui icon button commit-button"><i class="ellipsis horizontal icon"></i></button>
|
||||
<pre class="commit-body" style="display: none;">{{RenderCommitBody .Message $.RepoLink $.Repository.ComposeMetas}}</pre>
|
||||
|
|
|
@ -27,7 +27,7 @@
|
|||
</div>
|
||||
{{end}}
|
||||
</a>
|
||||
<span class="grey has-emoji">{{RenderCommitMessage .LatestCommit.Summary .RepoLink $.Repository.ComposeMetas}}
|
||||
<span class="grey has-emoji">{{.LatestCommit.Summary}}
|
||||
{{if IsMultilineCommitMessage .LatestCommit.Message}}
|
||||
<button class="basic compact mini ui icon button commit-button"><i class="ellipsis horizontal icon"></i></button>
|
||||
<pre class="commit-body" style="display: none;">{{RenderCommitBody .LatestCommit.Message $.RepoLink $.Repository.ComposeMetas}}</pre>
|
||||
|
@ -79,7 +79,7 @@
|
|||
</td>
|
||||
{{end}}
|
||||
<td class="message collapsing has-emoji">
|
||||
{{RenderCommitMessageLink $commit.Summary $.RepoLink (print $.RepoLink "/commit/" $commit.ID) $.Repository.ComposeMetas}}
|
||||
<a href="{{$.RepoLink}}/commit/{{$commit.ID}}">{{$commit.Summary}}</a>
|
||||
</td>
|
||||
<td class="text grey right age">{{TimeSince $commit.Committer.When $.Lang}}</td>
|
||||
</tr>
|
||||
|
|
Reference in a new issue