Nulo/gitea
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Activity

internal/ssh: ignore env command totally (#6825)

Browse source 
* ssh: ignore env command totally

* Remove commented code 

Needed fix described in issue #6889
This commit is contained in:
Antoine GIRARD 2019-05-10 00:41:43 +02:00 committed by techknowlogick
parent 2f21bc33a5
commit 10ff527fae
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/ssh/ssh.go
View file

@ -52,18 +52,6 @@ func handleServerConn(keyID string, chans <-chan ssh.NewChannel) {
for req := range in { for req := range in {
payload := cleanCommand(string(req.Payload)) payload := cleanCommand(string(req.Payload))
switch req.Type { switch req.Type {
case "env":
args := strings.Split(strings.Replace(payload, "\x00", "", -1), "\v")
if len(args) != 2 {
log.Warn("SSH: Invalid env arguments: '%#v'", args)
continue
}
args[0] = strings.TrimLeft(args[0], "\x04")
_, _, err := com.ExecCmdBytes("env", args[0]+"="+args[1])
if err != nil {
log.Error("env: %v", err)
return
}
case "exec": case "exec":
cmdName := strings.TrimLeft(payload, "'()") cmdName := strings.TrimLeft(payload, "'()")
log.Trace("SSH: Payload: %v", cmdName) log.Trace("SSH: Payload: %v", cmdName)