From 117dcf1c02b6560ab71feffd35f33084834c8ba8 Mon Sep 17 00:00:00 2001 From: zeripath Date: Mon, 17 Feb 2020 20:50:59 +0000 Subject: [PATCH] Set the initial commit status to Success otherwise it will always be Pending (#10317) (#10318) Backport #10317 The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success. --- services/pull/commit_status.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/pull/commit_status.go b/services/pull/commit_status.go index 3dccfb1f0..77aca4855 100644 --- a/services/pull/commit_status.go +++ b/services/pull/commit_status.go @@ -23,7 +23,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*models.CommitStatus, re return structs.CommitStatusSuccess } - var returnedStatus = structs.CommitStatusPending + var returnedStatus = structs.CommitStatusSuccess for _, ctx := range requiredContexts { var targetStatus structs.CommitStatusState for _, commitStatus := range commitStatuses {