From 1a4e2bfcd115ada6cb859cb87964c227e0e082b9 Mon Sep 17 00:00:00 2001 From: singuliere <35190819+singuliere@users.noreply.github.com> Date: Sat, 1 Jan 2022 04:31:24 +0100 Subject: [PATCH] tests: s/GITEA_UNIT_TESTS_VERBOSE/GITEA_UNIT_TESTS_LOG_SQL/ (#18142) The GITEA_UNIT_TESTS_VERBOSE variable is an undocumented variable introduced in 2017 (see 1028ef2defd94a64f2433b07fe5d93681864cebb) whose sole purpose has been to log SQL statements when running unit tests. It is renamed for clarity and a warning is displayed for backward compatibility for people and scripts that know about it. The documentation is updated to reflect this change. --- docs/content/doc/developers/hacking-on-gitea.en-us.md | 2 +- models/unittest/testdb.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/content/doc/developers/hacking-on-gitea.en-us.md b/docs/content/doc/developers/hacking-on-gitea.en-us.md index a0a372595..5f52856d1 100644 --- a/docs/content/doc/developers/hacking-on-gitea.en-us.md +++ b/docs/content/doc/developers/hacking-on-gitea.en-us.md @@ -277,7 +277,7 @@ There are two types of test run by Gitea: Unit tests and Integration Tests. ### Unit Tests Unit tests are covered by `*_test.go` in `go test` system. -You can set environment variable `GITEA_UNIT_TESTS_VERBOSE=1` to see detail logs during the test. +You can set the environment variable `GITEA_UNIT_TESTS_LOG_SQL=1` to display all SQL statements when running the tests in verbose mode (i.e. when `GOTESTFLAGS=-v` is set). ```bash TAGS="bindata sqlite sqlite_unlock_notify" make test # Runs the unit tests diff --git a/models/unittest/testdb.go b/models/unittest/testdb.go index c798dbefb..6f3a36ed2 100644 --- a/models/unittest/testdb.go +++ b/models/unittest/testdb.go @@ -152,7 +152,7 @@ func CreateTestEngine(opts FixturesOptions) error { if err = db.SyncAllTables(); err != nil { return err } - switch os.Getenv("GITEA_UNIT_TESTS_VERBOSE") { + switch os.Getenv("GITEA_UNIT_TESTS_LOG_SQL") { case "true", "1": x.ShowSQL(true) }