From 51db7b03dd85c6de808a2882afc1fd825ba11356 Mon Sep 17 00:00:00 2001
From: 6543 <6543@obermui.de>
Date: Tue, 21 Jun 2022 20:09:24 +0200
Subject: [PATCH] Release page show all tags in compare dropdown (#20070)
(#20071)
Backport #20070
Just get all tags when creating the compare dropdown. (Also updates the changelog.)
Fix #19936
---
CHANGELOG.md | 3 ++-
routers/web/repo/release.go | 9 ++++++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index c8143a92b..8d8d7acfe 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,9 +4,10 @@ This changelog goes through all the changes that have been made in each release
without substantial changes to our git log; to see the highlights of what has
been added to each release, please refer to the [blog](https://blog.gitea.io).
-## [1.16.9](https://github.com/go-gitea/gitea/releases/tag/1.16.9) - 2022-06-20
+## [1.16.9](https://github.com/go-gitea/gitea/releases/tag/v1.16.9) - 2022-06-21
* BUGFIXES
+ * Release page show all tags in compare dropdown (#20070) (#20071)
* Fix permission check for delete tag (#19985) (#20001)
* Only log non ErrNotExist errors in git.GetNote (#19884) (#19905)
* Use exact search instead of fuzzy search for branch filter dropdown (#19885) (#19893)
diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go
index 806880280..781ef5545 100644
--- a/routers/web/repo/release.go
+++ b/routers/web/repo/release.go
@@ -98,7 +98,14 @@ func releasesOrTags(ctx *context.Context, isTagList bool) {
listOptions.PageSize = setting.API.MaxResponseItems
}
- tags, err := ctx.Repo.GitRepo.GetTags(listOptions.GetStartEnd())
+ // TODO(20073) tags are used for compare feature witch needs all tags
+ // filtering is doen at the client side atm
+ tagListStart, tagListEnd := 0, 0
+ if isTagList {
+ tagListStart, tagListEnd = listOptions.GetStartEnd()
+ }
+
+ tags, err := ctx.Repo.GitRepo.GetTags(tagListStart, tagListEnd)
if err != nil {
ctx.ServerError("GetTags", err)
return