Fix issue sidebar menus having an infinite height (#10239)

* Revert "Limit label list height on edit issue page"

* Fix issue sidebar menus having an infinite height
This commit is contained in:
James Lakin 2020-02-11 20:40:47 +00:00 committed by GitHub
parent d9c79986ea
commit 54af3c90c7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions

View file

@ -7,7 +7,7 @@
<strong>{{.i18n.Tr "repo.issues.new.labels"}}</strong> <strong>{{.i18n.Tr "repo.issues.new.labels"}}</strong>
{{svg "octicon-gear" 16}} {{svg "octicon-gear" 16}}
</span> </span>
<div class="filter menu labels" data-action="update" data-issue-id="{{$.Issue.ID}}" data-update-url="{{$.RepoLink}}/issues/labels"> <div class="filter menu" data-action="update" data-issue-id="{{$.Issue.ID}}" data-update-url="{{$.RepoLink}}/issues/labels">
<div class="no-select item">{{.i18n.Tr "repo.issues.new.clear_labels"}}</div> <div class="no-select item">{{.i18n.Tr "repo.issues.new.clear_labels"}}</div>
{{range .Labels}} {{range .Labels}}
<a class="{{if .IsChecked}}checked{{end}} item has-emoji" href="#" data-id="{{.ID}}" data-id-selector="#label_{{.ID}}"><span class="octicon-check {{if not .IsChecked}}invisible{{end}}">{{svg "octicon-check" 16}}</span><span class="label color" style="background-color: {{.Color}}"></span> {{.Name}} <a class="{{if .IsChecked}}checked{{end}} item has-emoji" href="#" data-id="{{.ID}}" data-id-selector="#label_{{.ID}}"><span class="octicon-check {{if not .IsChecked}}invisible{{end}}">{{svg "octicon-check" 16}}</span><span class="label color" style="background-color: {{.Color}}"></span> {{.Name}}

View file

@ -83,6 +83,7 @@
.metas { .metas {
.menu { .menu {
overflow-x: auto; overflow-x: auto;
max-height: 300px;
} }
.ui.list { .ui.list {
@ -152,8 +153,6 @@
} }
&.labels { &.labels {
max-height: 300px;
.label-filter .menu .info { .label-filter .menu .info {
display: inline-block; display: inline-block;
padding: 9px 7px 7px 7px; padding: 9px 7px 7px 7px;