Nulo/gitea
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Activity

models: break out of loops (#12159)

Browse source 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
Lars Lehtonen 2020-07-06 05:07:07 -07:00 committed by GitHub
parent ae2916c792
commit 56f222d44c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
models/repo_sign.go
View file

@ -103,12 +103,13 @@ func SignInitialCommit(repoPath string, u *User) (bool, string, error) {
return false, "", &ErrWontSign{noKey} return false, "", &ErrWontSign{noKey}
} }
Loop:
for _, rule := range rules { for _, rule := range rules {
switch rule { switch rule {
case never: case never:
return false, "", &ErrWontSign{never} return false, "", &ErrWontSign{never}
case always: case always:
break break Loop
case pubkey: case pubkey:
keys, err := ListGPGKeys(u.ID, ListOptions{}) keys, err := ListGPGKeys(u.ID, ListOptions{})
if err != nil { if err != nil {
@ -138,12 +139,13 @@ func (repo *Repository) SignWikiCommit(u *User) (bool, string, error) {
return false, "", &ErrWontSign{noKey} return false, "", &ErrWontSign{noKey}
} }
Loop:
for _, rule := range rules { for _, rule := range rules {
switch rule { switch rule {
case never: case never:
return false, "", &ErrWontSign{never} return false, "", &ErrWontSign{never}
case always: case always:
break break Loop
case pubkey: case pubkey:
keys, err := ListGPGKeys(u.ID, ListOptions{}) keys, err := ListGPGKeys(u.ID, ListOptions{})
if err != nil { if err != nil {
@ -190,12 +192,13 @@ func (repo *Repository) SignCRUDAction(u *User, tmpBasePath, parentCommit string
return false, "", &ErrWontSign{noKey} return false, "", &ErrWontSign{noKey}
} }
Loop:
for _, rule := range rules { for _, rule := range rules {
switch rule { switch rule {
case never: case never:
return false, "", &ErrWontSign{never} return false, "", &ErrWontSign{never}
case always: case always:
break break Loop
case pubkey: case pubkey:
keys, err := ListGPGKeys(u.ID, ListOptions{}) keys, err := ListGPGKeys(u.ID, ListOptions{})
if err != nil { if err != nil {