Remove check for negative length (#5120)

This commit is contained in:
Oleg Kovalov 2018-10-20 23:25:14 +02:00 committed by techknowlogick
parent 583b1b8429
commit 5a4648cdd6
7 changed files with 8 additions and 8 deletions

View file

@ -134,7 +134,7 @@ func NewLabels(labels ...*Label) error {
// If pass repoID as 0, then ORM will ignore limitation of repository
// and can return arbitrary label with any valid ID.
func getLabelInRepoByName(e Engine, repoID int64, labelName string) (*Label, error) {
if len(labelName) <= 0 {
if len(labelName) == 0 {
return nil, ErrLabelNotExist{0, repoID}
}

View file

@ -677,7 +677,7 @@ func (env *accessibleReposEnv) Repos(page, pageSize int) ([]*Repository, error)
}
repos := make([]*Repository, 0, len(repoIDs))
if len(repoIDs) <= 0 {
if len(repoIDs) == 0 {
return repos, nil
}
@ -705,7 +705,7 @@ func (env *accessibleReposEnv) MirrorRepos() ([]*Repository, error) {
}
repos := make([]*Repository, 0, len(repoIDs))
if len(repoIDs) <= 0 {
if len(repoIDs) == 0 {
return repos, nil
}

View file

@ -376,7 +376,7 @@ func calcFingerprint(publicKeyContent string) (string, error) {
}
func addKey(e Engine, key *PublicKey) (err error) {
if len(key.Fingerprint) <= 0 {
if len(key.Fingerprint) == 0 {
key.Fingerprint, err = calcFingerprint(key.Content)
if err != nil {
return err

View file

@ -36,7 +36,7 @@ func SignedInID(ctx *macaron.Context, sess session.Store) int64 {
// Check access token.
if IsAPIPath(ctx.Req.URL.Path) {
tokenSHA := ctx.Query("token")
if len(tokenSHA) <= 0 {
if len(tokenSHA) == 0 {
tokenSHA = ctx.Query("access_token")
}
if len(tokenSHA) == 0 {

View file

@ -18,7 +18,7 @@ func getWhoamiOutput() (string, error) {
func TestCurrentUsername(t *testing.T) {
user := CurrentUsername()
if len(user) <= 0 {
if len(user) == 0 {
t.Errorf("expected non-empty user, got: %s", user)
}
// Windows whoami is weird, so just skip remaining tests

View file

@ -80,7 +80,7 @@ import (
func sudo() macaron.Handler {
return func(ctx *context.APIContext) {
sudo := ctx.Query("sudo")
if len(sudo) <= 0 {
if len(sudo) == 0 {
sudo = ctx.Req.Header.Get("Sudo")
}

View file

@ -213,7 +213,7 @@ func Issues(ctx *context.Context) {
return
}
}
if len(userRepoIDs) <= 0 {
if len(userRepoIDs) == 0 {
userRepoIDs = []int64{-1}
}