Nulo/gitea
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Activity

Enhance healthcheck for database connectivity (#3754)

Browse source 
Modify the call to ping the database to fail gracefully if the
database has not yet been configured by the end user, such as
after a clean install. This allows /healthcheck to return a 200
with a modified status message instead of causing a PANIC.

Signed-off-by: Evan Sherwood <evan@sherwood.io>
This commit is contained in:
Evan Sherwood 2018-04-04 02:34:27 -07:00 committed by Lunny Xiao
parent 3e06490d38
commit 6b6c414bc3
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
models/models.go
View file

@ -335,8 +335,11 @@ func GetStatistic() (stats Statistic) {
// Ping tests if database is alive // Ping tests if database is alive
func Ping() error { func Ping() error {
if x != nil {
return x.Ping() return x.Ping()
} }
return errors.New("database not configured")
}
// DumpDatabase dumps all data from database according the special database SQL syntax to file system. // DumpDatabase dumps all data from database according the special database SQL syntax to file system.
func DumpDatabase(filePath string, dbType string) error { func DumpDatabase(filePath string, dbType string) error {