From 74a4a1e17f99d147db9329718a5ecc87984b0ecd Mon Sep 17 00:00:00 2001 From: mavenbline <42911384+mavenbline@users.noreply.github.com> Date: Sat, 8 Feb 2020 17:59:40 +0300 Subject: [PATCH] Fix invalid repo urls after change username (#10150) * Fix invalid repo urls after change username * Update user.go Co-authored-by: Lauris BH Co-authored-by: Antoine GIRARD --- models/user.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/models/user.go b/models/user.go index 213b5f76a..a68db6cf4 100644 --- a/models/user.go +++ b/models/user.go @@ -1044,13 +1044,23 @@ func ChangeUserName(u *User, newUserName string) (err error) { } else if isExist { return ErrUserAlreadyExist{newUserName} } + + sess := x.NewSession() + defer sess.Close() + if err = sess.Begin(); err != nil { + return err + } + + if _, err = sess.Exec("UPDATE `repository` SET owner_name=? WHERE owner_name=?", newUserName, u.Name); err != nil { + return fmt.Errorf("Change repo owner name: %v", err) + } // Do not fail if directory does not exist if err = os.Rename(UserPath(u.Name), UserPath(newUserName)); err != nil && !os.IsNotExist(err) { return fmt.Errorf("Rename user directory: %v", err) } - return nil + return sess.Commit() } // checkDupEmail checks whether there are the same email with the user