From 858197b4538cc0fe057f1bea4e62e6bdb8e8b331 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guillermo=20Bonveh=C3=AD?= Date: Wed, 28 Jun 2017 05:55:28 -0300 Subject: [PATCH] Fix #1271: Call location.reload after XHR finishes (#2071) location.reload was being called when the related dropdown was hidden, even if a request initiated before to update this value hadn't finished. This caused troubles on Firefox. --- public/js/index.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/public/js/index.js b/public/js/index.js index 80d9486fd..25915bc2a 100644 --- a/public/js/index.js +++ b/public/js/index.js @@ -189,12 +189,6 @@ function initCommentForm() { var $list = $('.ui' + select_id + '.list'); var hasUpdateAction = $menu.data('action') == 'update'; - $(select_id).dropdown('setting', 'onHide', function(){ - if (hasUpdateAction) { - location.reload(); - } - }); - $menu.find('.item:not(.no-select)').click(function () { $(this).parent().find('.item').each(function () { $(this).removeClass('selected active') @@ -206,7 +200,8 @@ function initCommentForm() { $menu.data('update-url'), "", $menu.data('issue-id'), - $(this).data('id') + $(this).data('id'), + function() { location.reload(); } ); } switch (input_id) { @@ -232,7 +227,8 @@ function initCommentForm() { $menu.data('update-url'), "", $menu.data('issue-id'), - $(this).data('id') + $(this).data('id'), + function() { location.reload(); } ); }