Nulo/gitea
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Activity

Fix 500 when getting user as unauthenticated user (#8653) (#8663)

Browse source 
Backport #8653

When doing GET /api/v1/users/{user} as an unauthenticated user,
gitea throws a 500 because it's trying to dereference elements
from the context user. It wants to do this to see whether to
show the primary email and will do that if the logged in user
is admin or the user in question. However, if ctx.User is nil there is a panic
This commit is contained in:
Monty Taylor 2019-10-25 21:09:15 +09:00 committed by zeripath
parent fa03af8456
commit 9bde52ffc1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
routers/api/v1/user/user.go
View file

@ -104,7 +104,7 @@ func GetInfo(ctx *context.APIContext) {
return return
} }
ctx.JSON(200, convert.ToUser(u, ctx.IsSigned, ctx.User.ID == u.ID || ctx.User.IsAdmin)) ctx.JSON(200, convert.ToUser(u, ctx.IsSigned, ctx.User != nil && (ctx.User.ID == u.ID || ctx.User.IsAdmin)))
} }
// GetAuthenticatedUser get current user's information // GetAuthenticatedUser get current user's information