Fix panic when an invalid oauth2 name is passed (#20820)
This commit is contained in:
parent
7503cd35c2
commit
c138e76c1c
1 changed files with 5 additions and 1 deletions
|
@ -512,10 +512,14 @@ func GetActiveOAuth2ProviderSources() ([]*Source, error) {
|
||||||
func GetActiveOAuth2SourceByName(name string) (*Source, error) {
|
func GetActiveOAuth2SourceByName(name string) (*Source, error) {
|
||||||
authSource := new(Source)
|
authSource := new(Source)
|
||||||
has, err := db.GetEngine(db.DefaultContext).Where("name = ? and type = ? and is_active = ?", name, OAuth2, true).Get(authSource)
|
has, err := db.GetEngine(db.DefaultContext).Where("name = ? and type = ? and is_active = ?", name, OAuth2, true).Get(authSource)
|
||||||
if !has || err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if !has {
|
||||||
|
return nil, fmt.Errorf("oauth2 source not found, name: %q", name)
|
||||||
|
}
|
||||||
|
|
||||||
return authSource, nil
|
return authSource, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Reference in a new issue