Nulo/gitea
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Activity

Stop calling WriteHeader in Write (#15862) (#15873)

Browse source 
Backport #15862

Fixes http: superfluous response.WriteHeader call from code.gitea.io/gitea/modules/context.(*Response).WriteHeader (response.go:67)

* Looking again we don't need this writeHeader as all of our downstream
implementations will always do it for us

Signed-off-by: Andrew Thornton <art27@cantab.net>
This commit is contained in:
zeripath 2021-05-14 15:38:35 +01:00 committed by GitHub
parent 1bf46836da
commit cbaf8e8785
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/context/response.go
View file

@ -49,7 +49,7 @@ func (r *Response) Write(bs []byte) (int, error) {
return size, err return size, err
} }
if r.status == 0 { if r.status == 0 {
r.WriteHeader(200) r.status = http.StatusOK
} }
return size, nil return size, nil
} }