Nulo/gitea
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Activity

Fix an error while adding a dependency via UI. (Backport #5862) (#5876)

Browse source 
Fixes: #5783.
This commit is contained in:
Harshit Bansal 2019-01-28 18:21:30 +05:30 committed by zeripath
parent 28d9305ea3
commit d3a334d99a
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
models/issue_comment.go
View file

@ -748,6 +748,9 @@ func createIssueDependencyComment(e *xorm.Session, doer *User, issue *Issue, dep
if !add { if !add {
cType = CommentTypeRemoveDependency cType = CommentTypeRemoveDependency
} }
if err = issue.loadRepo(e); err != nil {
return
}
// Make two comments, one in each issue // Make two comments, one in each issue
_, err = createComment(e, &CreateCommentOptions{ _, err = createComment(e, &CreateCommentOptions{

2
models/issue_dependency_test.go
View file

@ -19,11 +19,9 @@ func TestCreateIssueDependency(t *testing.T) {
issue1, err := GetIssueByID(1) issue1, err := GetIssueByID(1)
assert.NoError(t, err) assert.NoError(t, err)
issue1.LoadAttributes()
issue2, err := GetIssueByID(2) issue2, err := GetIssueByID(2)
assert.NoError(t, err) assert.NoError(t, err)
issue2.LoadAttributes()
// Create a dependency and check if it was successful // Create a dependency and check if it was successful
err = CreateIssueDependency(user1, issue1, issue2) err = CreateIssueDependency(user1, issue1, issue2)