Nulo/gitea
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Activity

Add doctor dbconsistency check for release and attachment (#16978)

Browse source
This commit is contained in:
Lunny Xiao 2021-09-15 03:41:40 +08:00 committed by GitHub
parent 87505a9464
commit e2f0ab3343
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 49 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
models/attachment.go
View file

@ -272,3 +272,16 @@ func IterateAttachment(f func(attach *Attachment) error) error {
} }
} }
} }
// CountOrphanedAttachments returns the number of bad attachments
func CountOrphanedAttachments() (int64, error) {
return x.Where("(issue_id > 0 and issue_id not in (select id from issue)) or (release_id > 0 and release_id not in (select id from `release`))").
Count(new(Attachment))
}
// DeleteOrphanedAttachments delete all bad attachments
func DeleteOrphanedAttachments() error {
_, err := x.Where("(issue_id > 0 and issue_id not in (select id from issue)) or (release_id > 0 and release_id not in (select id from `release`))").
Delete(new(Attachment))
return err
}

36
modules/doctor/dbconsistency.go
View file

@ -74,6 +74,24 @@ func checkDBConsistency(logger log.Logger, autofix bool) error {
} }
} }
// find releases without existing repository
count, err = models.CountOrphanedObjects("release", "repository", "release.repo_id=repository.id")
if err != nil {
logger.Critical("Error: %v whilst counting orphaned objects", err)
return err
}
if count > 0 {
if autofix {
if err = models.DeleteOrphanedObjects("release", "repository", "release.repo_id=repository.id"); err != nil {
logger.Critical("Error: %v whilst deleting orphaned objects", err)
return err
}
logger.Info("%d releases without existing repository deleted", count)
} else {
logger.Warn("%d releases without existing repository", count)
}
}
// find pulls without existing issues // find pulls without existing issues
count, err = models.CountOrphanedObjects("pull_request", "issue", "pull_request.issue_id=issue.id") count, err = models.CountOrphanedObjects("pull_request", "issue", "pull_request.issue_id=issue.id")
if err != nil { if err != nil {
@ -110,6 +128,24 @@ func checkDBConsistency(logger log.Logger, autofix bool) error {
} }
} }
// find attachments without existing issues or releases
count, err = models.CountOrphanedAttachments()
if err != nil {
logger.Critical("Error: %v whilst counting orphaned objects", err)
return err
}
if count > 0 {
if autofix {
if err = models.DeleteOrphanedAttachments(); err != nil {
logger.Critical("Error: %v whilst deleting orphaned objects", err)
return err
}
logger.Info("%d attachments without existing issue or release deleted", count)
} else {
logger.Warn("%d attachments without existing issue or release", count)
}
}
// find null archived repositories // find null archived repositories
count, err = models.CountNullArchivedRepository() count, err = models.CountNullArchivedRepository()
if err != nil { if err != nil {