diff --git a/integrations/issue_test.go b/integrations/issue_test.go new file mode 100644 index 000000000..61ddc12ad --- /dev/null +++ b/integrations/issue_test.go @@ -0,0 +1,21 @@ +// Copyright 2017 The Gitea Authors. All rights reserved. +// Use of this source code is governed by a MIT-style +// license that can be found in the LICENSE file. + +package integrations + +import ( + "net/http" + "testing" + + "github.com/stretchr/testify/assert" +) + +func TestNoLoginViewIssue(t *testing.T) { + prepareTestEnv(t) + + req, err := http.NewRequest("GET", "/user2/repo1/issues/1", nil) + assert.NoError(t, err) + resp := MakeRequest(req) + assert.EqualValues(t, http.StatusOK, resp.HeaderCode) +} diff --git a/models/fixtures/repo_unit.yml b/models/fixtures/repo_unit.yml new file mode 100644 index 000000000..a41784db9 --- /dev/null +++ b/models/fixtures/repo_unit.yml @@ -0,0 +1,15 @@ +- + id: 1 + repo_id: 1 + type: 1 + index: 0 + config: "{}" + created_unix: 946684810 + +- + id: 2 + repo_id: 1 + type: 2 + index: 0 + config: "{}" + created_unix: 946684810 \ No newline at end of file diff --git a/routers/repo/issue.go b/routers/repo/issue.go index 61f79a239..254e182bc 100644 --- a/routers/repo/issue.go +++ b/routers/repo/issue.go @@ -465,16 +465,20 @@ func ViewIssue(ctx *context.Context) { } ctx.Data["Title"] = fmt.Sprintf("#%d - %s", issue.Index, issue.Title) - iw, exists, err := models.GetIssueWatch(ctx.User.ID, issue.ID) - if err != nil { - ctx.Handle(500, "GetIssueWatch", err) - return - } - if !exists { - iw = &models.IssueWatch{ - UserID: ctx.User.ID, - IssueID: issue.ID, - IsWatching: models.IsWatching(ctx.User.ID, ctx.Repo.Repository.ID), + var iw *models.IssueWatch + var exists bool + if ctx.User != nil { + iw, exists, err = models.GetIssueWatch(ctx.User.ID, issue.ID) + if err != nil { + ctx.Handle(500, "GetIssueWatch", err) + return + } + if !exists { + iw = &models.IssueWatch{ + UserID: ctx.User.ID, + IssueID: issue.ID, + IsWatching: models.IsWatching(ctx.User.ID, ctx.Repo.Repository.ID), + } } } ctx.Data["IssueWatch"] = iw diff --git a/templates/repo/issue/view_content/sidebar.tmpl b/templates/repo/issue/view_content/sidebar.tmpl index 28bd755e4..cfb6f183b 100644 --- a/templates/repo/issue/view_content/sidebar.tmpl +++ b/templates/repo/issue/view_content/sidebar.tmpl @@ -99,6 +99,7 @@ + {{if $.IssueWatch}}