From edf85b820d4d281b281b862e3f66f950616eb62c Mon Sep 17 00:00:00 2001 From: Jimmy Praet Date: Sat, 12 Feb 2022 13:24:49 +0100 Subject: [PATCH] Fix source code line highlighting (#18729) (#18740) Backport #18729 When the issues repo unit is disabled, or an external issue tracker is used, there is no "a.ref-in-new-issue". Fixes #18721 Co-authored-by: wxiaoguang --- web_src/js/features/repo-code.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/web_src/js/features/repo-code.js b/web_src/js/features/repo-code.js index 1855f86b4..96a923571 100644 --- a/web_src/js/features/repo-code.js +++ b/web_src/js/features/repo-code.js @@ -15,11 +15,14 @@ function selectRange($list, $select, $from) { const $issue = $('a.ref-in-new-issue'); const $copyPermalink = $('a.copy-line-permalink'); - if ($issue.length === 0 || $copyPermalink.length === 0) { + if ($copyPermalink.length === 0) { return; } - const updateIssueHref = function(anchor) { + const updateIssueHref = function (anchor) { + if ($issue.length === 0) { + return; + } let href = $issue.attr('href'); href = `${href.replace(/%23L\d+$|%23L\d+-L\d+$/, '')}%23${anchor}`; $issue.attr('href', href);