Backport #22453 In #22447 it was noticed that display environments were not working correctly. This was due to the setting displayMode not being set. Further it was noticed that the error was not being displayed correctly. This PR fixes both of these issues by forcibly setting the displayMode setting and corrects an error in displayError. Fix #22447 Signed-off-by: Andrew Thornton <art27@cantab.net>
This commit is contained in:
parent
29bbfcc118
commit
ee37edc465
1 changed files with 9 additions and 5 deletions
|
@ -1,6 +1,6 @@
|
||||||
function displayError(el, err) {
|
function displayError(el, err) {
|
||||||
const target = targetElement(el);
|
const target = targetElement(el);
|
||||||
target.remove('is-loading');
|
target.classList.remove('is-loading');
|
||||||
const errorNode = document.createElement('div');
|
const errorNode = document.createElement('div');
|
||||||
errorNode.setAttribute('class', 'ui message error markup-block-error mono');
|
errorNode.setAttribute('class', 'ui message error markup-block-error mono');
|
||||||
errorNode.textContent = err.str || err.message || String(err);
|
errorNode.textContent = err.str || err.message || String(err);
|
||||||
|
@ -23,12 +23,16 @@ export async function renderMath() {
|
||||||
|
|
||||||
for (const el of els) {
|
for (const el of els) {
|
||||||
const source = el.textContent;
|
const source = el.textContent;
|
||||||
const options = {display: el.classList.contains('display')};
|
const displayMode = el.classList.contains('display');
|
||||||
|
const nodeName = displayMode ? 'p' : 'span';
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const markup = katex.renderToString(source, options);
|
const tempEl = document.createElement(nodeName);
|
||||||
const tempEl = document.createElement(options.display ? 'p' : 'span');
|
katex.render(source, tempEl, {
|
||||||
tempEl.innerHTML = markup;
|
maxSize: 25,
|
||||||
|
maxExpand: 50,
|
||||||
|
displayMode,
|
||||||
|
});
|
||||||
targetElement(el).replaceWith(tempEl);
|
targetElement(el).replaceWith(tempEl);
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
displayError(el, error);
|
displayError(el, error);
|
||||||
|
|
Reference in a new issue