Backport: Fix lint, fmt and integration testing errors (#2553)

* Fix lint errors

* Fix fmt errors (#2544)

* Hotfix for integration testing (#2473)

* Hotfix for integration testing

integrations/mysql.ini

@@ -3,7 +3,7 @@ RUN_MODE = prod
 
 [database]
 DB_TYPE  = mysql
-HOST     = 127.0.0.1:3306
+HOST     = mysql:3306
 NAME     = testgitea
 USER     = root
 PASSWD   =

integrations/pgsql.ini

@@ -3,7 +3,7 @@ RUN_MODE = prod
 
 [database]
 DB_TYPE  = postgres
-HOST     = 127.0.0.1:5432
+HOST     = pgsql:5432
 NAME     = testgitea
 USER     = postgres
 PASSWD   = postgres

integrations/sqlite.ini

@@ -3,11 +3,6 @@ RUN_MODE = prod
 
 [database]
 DB_TYPE  = sqlite3
-HOST     = 127.0.0.1:3306
-NAME     = testgitea
-USER     = gitea
-PASSWD   =
-SSL_MODE = disable
 PATH     = :memory:
 
 [repository]

models/gpg_key.go

@@ -276,11 +276,7 @@ func DeleteGPGKey(doer *User, id int64) (err error) {
 		return err
 	}
 
-	if err = sess.Commit(); err != nil {
+	return sess.Commit()
-		return err
-	}
-
-	return nil
 }
 
 // CommitVerification represents a commit validation of signature

models/issue.go

@@ -572,11 +572,7 @@ func (issue *Issue) ReadBy(userID int64) error {
 		return err
 	}
 
-	if err := setNotificationStatusReadIfUnread(x, userID, issue.ID); err != nil {
+	return setNotificationStatusReadIfUnread(x, userID, issue.ID)
-		return err
-	}
-
-	return nil
 }
 
 func updateIssueCols(e Engine, issue *Issue, cols ...string) error {

models/login_source.go

@@ -509,10 +509,7 @@ func SMTPAuth(a smtp.Auth, cfg *SMTPConfig) error {
 	}
 
 	if ok, _ := c.Extension("AUTH"); ok {
-		if err = c.Auth(a); err != nil {
+		return c.Auth(a)
-			return err
-		}
-		return nil
 	}
 	return ErrUnsupportedLoginType
 }

models/migrations/v16.go

@@ -119,9 +119,5 @@ func addUnitsToTables(x *xorm.Engine) error {
 		}
 	}
 
-	if err := sess.Commit(); err != nil {
+	return sess.Commit()
-		return err
-	}
-
-	return nil
 }

models/migrations/v21.go

@@ -51,8 +51,5 @@ func useNewPublickeyFormat(x *xorm.Engine) error {
 	}
 
 	f.Close()
-	if err = os.Rename(tmpPath, fpath); err != nil {
+	return os.Rename(tmpPath, fpath)
-		return err
-	}
-	return nil
 }

models/org.go

@@ -235,11 +235,7 @@ func DeleteOrganization(org *User) (err error) {
 		}
 	}
 
-	if err = sess.Commit(); err != nil {
+	return sess.Commit()
-		return err
-	}
-
-	return nil
 }
 
 func deleteOrg(e *xorm.Session, u *User) error {

models/ssh_key.go

@@ -609,11 +609,7 @@ func RewriteAllPublicKeys() error {
 		defer f.Close()
 	}
 
-	if err = os.Rename(tmpPath, fPath); err != nil {
+	return os.Rename(tmpPath, fPath)
-		return err
-	}
-
-	return nil
 }
 
 // ________                .__                 ____  __.

modules/lfs/content_store.go

@@ -70,10 +70,7 @@ func (s *ContentStore) Put(meta *models.LFSMetaObject, r io.Reader) error {
 		return errHashMismatch
 	}
 
-	if err := os.Rename(tmpPath, path); err != nil {
+	return os.Rename(tmpPath, path)
-		return err
-	}
-	return nil
 }
 
 // Exists returns true if the object exists in the content store.

modules/log/file.go

@@ -110,10 +110,7 @@ func (w *FileLogWriter) StartLogger() error {
 		return err
 	}
 	w.mw.SetFd(fd)
-	if err = w.initFd(); err != nil {
+	return w.initFd()
-		return err
-	}
-	return nil
 }
 
 func (w *FileLogWriter) docheck(size int) {