Nulo/gitea
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Activity

Make sure email recipients can see issue (#13820)

Browse source 
* Initial pass

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Remove over-op

Signed-off-by: jolheiser <john.olheiser@gmail.com>
This commit is contained in:
John Olheiser 2020-12-03 14:25:49 -06:00 committed by GitHub
parent 5d43d2965a
commit f0cc29761d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
services/mailer/mail_issue.go
View file

@ -122,7 +122,17 @@ func mailIssueCommentBatch(ctx *mailCommentContext, ids []int64, visited map[int
if err != nil { if err != nil {
return err return err
} }
// TODO: Check issue visibility for each user
// Make sure all recipients can still see the issue
idx := 0
for _, r := range recipients {
if ctx.Issue.Repo.CheckUnitUser(r, models.UnitTypeIssues) {
recipients[idx] = r
idx++
}
}
recipients = recipients[:idx]
// TODO: Separate recipients by language for i18n mail templates // TODO: Separate recipients by language for i18n mail templates
tos := make([]string, len(recipients)) tos := make([]string, len(recipients))
for i := range recipients { for i := range recipients {