markup: microoptimise for many short filenames in directory (#1534)
* markup: microoptimise for many short filenames in directory Move strings.ToLower() after the early-return length check. This is a safe operation in all cases and should slightly improve directory listing performance when a directory contains many thousands of files with short filenames. * markup: expand test cases for IsReadmeFile()
This commit is contained in:
parent
d98a86d2a2
commit
fd76f090a2
2 changed files with 6 additions and 2 deletions
|
@ -71,11 +71,14 @@ func ReadmeFileType(name string) (string, bool) {
|
|||
// IsReadmeFile reports whether name looks like a README file
|
||||
// based on its name.
|
||||
func IsReadmeFile(name string) bool {
|
||||
name = strings.ToLower(name)
|
||||
if len(name) < 6 {
|
||||
return false
|
||||
} else if len(name) == 6 {
|
||||
}
|
||||
|
||||
name = strings.ToLower(name)
|
||||
if len(name) == 6 {
|
||||
return name == "readme"
|
||||
}
|
||||
return name[:7] == "readme."
|
||||
}
|
||||
|
||||
|
|
|
@ -25,6 +25,7 @@ func TestMisc_IsReadmeFile(t *testing.T) {
|
|||
"abcdefg",
|
||||
"abcdefghijklmnopqrstuvwxyz",
|
||||
"test.md.test",
|
||||
"readmf",
|
||||
}
|
||||
|
||||
for _, testCase := range trueTestCases {
|
||||
|
|
Reference in a new issue