5d3dbffa15
- Instead of returning a 500 Internal Server when the user wasn't found, return 404 Not found
58 lines
1.8 KiB
Go
58 lines
1.8 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package user
|
|
|
|
import (
|
|
"strings"
|
|
"time"
|
|
|
|
"code.gitea.io/gitea/models/avatars"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/context"
|
|
"code.gitea.io/gitea/modules/httpcache"
|
|
)
|
|
|
|
func cacheableRedirect(ctx *context.Context, location string) {
|
|
// here we should not use `setting.StaticCacheTime`, it is pretty long (default: 6 hours)
|
|
// we must make sure the redirection cache time is short enough, otherwise a user won't see the updated avatar in 6 hours
|
|
// it's OK to make the cache time short, it is only a redirection, and doesn't cost much to make a new request
|
|
httpcache.AddCacheControlToHeader(ctx.Resp.Header(), 5*time.Minute)
|
|
ctx.Redirect(location)
|
|
}
|
|
|
|
// AvatarByUserName redirect browser to user avatar of requested size
|
|
func AvatarByUserName(ctx *context.Context) {
|
|
userName := ctx.Params(":username")
|
|
size := int(ctx.ParamsInt64(":size"))
|
|
|
|
var user *user_model.User
|
|
if strings.ToLower(userName) != "ghost" {
|
|
var err error
|
|
if user, err = user_model.GetUserByName(ctx, userName); err != nil {
|
|
if user_model.IsErrUserNotExist(err) {
|
|
ctx.NotFound("GetUserByName", err)
|
|
return
|
|
}
|
|
ctx.ServerError("Invalid user: "+userName, err)
|
|
return
|
|
}
|
|
} else {
|
|
user = user_model.NewGhostUser()
|
|
}
|
|
|
|
cacheableRedirect(ctx, user.AvatarLinkWithSize(size))
|
|
}
|
|
|
|
// AvatarByEmailHash redirects the browser to the email avatar link
|
|
func AvatarByEmailHash(ctx *context.Context) {
|
|
hash := ctx.Params(":hash")
|
|
email, err := avatars.GetEmailForHash(hash)
|
|
if err != nil {
|
|
ctx.ServerError("invalid avatar hash: "+hash, err)
|
|
return
|
|
}
|
|
size := ctx.FormInt("size")
|
|
cacheableRedirect(ctx, avatars.GenerateEmailAvatarFinalLink(email, size))
|
|
}
|