Nulo/kawipiko
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[runtime] Fix StringToBytes implementation.

Browse source
This commit is contained in:
Ciprian Dorin Craciun 2021-11-17 21:42:36 +02:00
parent 438de23373
commit c977ec393a
1 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
sources/lib/common/runtime.go
View file

@ -1,6 +1,7 @@
package common package common
import "reflect"
import "unsafe" import "unsafe"
@ -13,11 +14,11 @@ func NoEscape (p unsafe.Pointer) (unsafe.Pointer) {
} }
func NoEscapeBytes (p *[]byte) (*[]byte) { func NoEscapeBytes (p *[]byte) (*[]byte) {
return (*[]byte) (NoEscape (unsafe.Pointer (&p))) return (*[]byte) (NoEscape (unsafe.Pointer (p)))
} }
func NoEscapeString (p *string) (*string) { func NoEscapeString (p *string) (*string) {
return (*string) (NoEscape (unsafe.Pointer (&p))) return (*string) (NoEscape (unsafe.Pointer (p)))
} }
@ -25,7 +26,18 @@ func BytesToString (b []byte) (string) {
return *(*string) (unsafe.Pointer (&b)) return *(*string) (unsafe.Pointer (&b))
} }
func StringToBytes (s string) ([]byte) { func StringToBytes (_string string) ([]byte) {
return *(*[]byte) (unsafe.Pointer (&s))
// NOTE: The following is broken!
// return *(*[]byte) (unsafe.Pointer (&_string))
// NOTE: Based on `https://github.com/valyala/fasthttp/blob/2a6f7db5bbc4d7c11f1ccc0cb827e145b9b7d7ea/bytesconv.go#L342`
_bytes := []byte (nil)
_bytesHeader := (*reflect.SliceHeader) (unsafe.Pointer (&_bytes))
_stringHeader := (*reflect.StringHeader) (unsafe.Pointer (&_string))
_bytesHeader.Data = _stringHeader.Data
_bytesHeader.Len = _stringHeader.Len
_bytesHeader.Cap = _stringHeader.Len
return _bytes
} }