Nulo/qmk_firmware
1
0
Fork 0
Code Releases Activity

move #include "rgb.h" from quantum.h to quantum.c

Browse source 
I think `quantum.h` should contain only API declarations that `quantum.c` provides externally. `rgb.h` contains function weak definitions. This should not be in `quantum.h`.
This commit is contained in:
mtei 2019-01-10 12:04:01 +09:00 committed by Drashna Jaelre
parent 79b58937f4
commit 2e8b32b9b5
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
quantum/quantum.c
View file

@ -15,6 +15,11 @@
*/ */
#include "quantum.h" #include "quantum.h"
#if !defined(RGBLIGHT_ENABLE) && !defined(RGB_MATRIX_ENABLE)
#include "rgb.h"
#endif
#ifdef PROTOCOL_LUFA #ifdef PROTOCOL_LUFA
#include "outputselect.h" #include "outputselect.h"
#endif #endif

3
quantum/quantum.h
View file

@ -30,9 +30,6 @@
#ifdef BACKLIGHT_ENABLE #ifdef BACKLIGHT_ENABLE
#include "backlight.h" #include "backlight.h"
#endif #endif
#if !defined(RGBLIGHT_ENABLE) && !defined(RGB_MATRIX_ENABLE)
#include "rgb.h"
#endif
#ifdef RGBLIGHT_ENABLE #ifdef RGBLIGHT_ENABLE
#include "rgblight.h" #include "rgblight.h"
#else #else