Nulo/qmk_firmware
1
0
Fork 0
Code Releases Activity

Add setup, clone, and env to the list of commands we allow even with broken modules (#12868)

Browse source
This commit is contained in:
Zach White 2021-05-12 09:40:58 -07:00 committed by GitHub
parent 3a1ce81d29
commit 6da60d4a5d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 40 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
lib/python/qmk/cli/__init__.py
View file

@ -13,6 +13,21 @@ from milc import cli, __VERSION__
from milc.questions import yesno from milc.questions import yesno
import_names = {
# A mapping of package name to importable name
'pep8-naming': 'pep8ext_naming',
'pyusb': 'usb.core',
}
safe_commands = [
# A list of subcommands we always run, even when the module imports fail
'clone',
'config',
'env',
'setup',
]
def _run_cmd(*command): def _run_cmd(*command):
"""Run a command in a subshell. """Run a command in a subshell.
""" """
@ -50,10 +65,8 @@ def _find_broken_requirements(requirements):
module_import = module_name.replace('-', '_') module_import = module_name.replace('-', '_')
# Not every module is importable by its own name. # Not every module is importable by its own name.
if module_name == "pep8-naming": if module_name in import_names:
module_import = "pep8ext_naming" module_import = import_names[module_name]
elif module_name == 'pyusb':
module_import = 'usb.core'
if not find_spec(module_import): if not find_spec(module_import):
broken_modules.append(module_name) broken_modules.append(module_name)
@ -109,8 +122,12 @@ if int(milc_version[0]) < 2 and int(milc_version[1]) < 3:
# Check to make sure we have all our dependencies # Check to make sure we have all our dependencies
msg_install = 'Please run `python3 -m pip install -r %s` to install required python dependencies.' msg_install = 'Please run `python3 -m pip install -r %s` to install required python dependencies.'
args = sys.argv[1:]
while args and args[0][0] == '-':
del args[0]
if _broken_module_imports('requirements.txt'): if not args or args[0] not in safe_commands:
if _broken_module_imports('requirements.txt'):
if yesno('Would you like to install the required Python modules?'): if yesno('Would you like to install the required Python modules?'):
_run_cmd(sys.executable, '-m', 'pip', 'install', '-r', 'requirements.txt') _run_cmd(sys.executable, '-m', 'pip', 'install', '-r', 'requirements.txt')
else: else:
@ -119,12 +136,7 @@ if _broken_module_imports('requirements.txt'):
print() print()
exit(1) exit(1)
if cli.config.user.developer: if cli.config.user.developer and _broken_module_imports('requirements-dev.txt'):
args = sys.argv[1:]
while args and args[0][0] == '-':
del args[0]
if not args or args[0] != 'config':
if _broken_module_imports('requirements-dev.txt'):
if yesno('Would you like to install the required developer Python modules?'): if yesno('Would you like to install the required developer Python modules?'):
_run_cmd(sys.executable, '-m', 'pip', 'install', '-r', 'requirements-dev.txt') _run_cmd(sys.executable, '-m', 'pip', 'install', '-r', 'requirements-dev.txt')
elif yesno('Would you like to disable developer mode?'): elif yesno('Would you like to disable developer mode?'):